flipper-api 0.16.0 → 0.16.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1fe848186acddf2d53ab3068d5f2ec2246ab688c
-  data.tar.gz: 20c08ae092d4b61c9a1412778a55f84ca9602c1b
+  metadata.gz: debf12af06cb2052a93e762b577c84ca00947468
+  data.tar.gz: 80243f08329c85997012c0a2a0c436d22b9ccc4d
 SHA512:
-  metadata.gz: 8e7e1c899f4a5cd09ac3e129e8e83d0085a46b1ccb4bd05a6d849ad4ccc7a4a158313a08d22201d644f4d35820d70482b248e1a81283f5434ccfc93e70b88863
-  data.tar.gz: 4d367bab12c168329609aa4c9cac1b7098bd68d428d49d927c4c5ee22584864482877866a49d733c9a36fa4874d698b632277cff90ee027f800a0196343febbd
+  metadata.gz: d00f668b0162f64d431058bee93d475d9c24e79e01c495cb943d968654cb2f898cfb315fe649c1e1b1143ec0089296fc103ee1c7b666c78b2d3d2d3735aeb480
+  data.tar.gz: 0ca3db409714648246d2a8bb8641485502bd38188e39980208b708d758638657fa14e4ec18aebfbb6b46dbaffdc08676eca34b234c89d5d15fa897af58b76053

data/lib/flipper/api/action.rb

@@ -10,7 +10,7 @@ module Flipper
         def feature_name
           @feature_name ||= begin
             match = request.path_info.match(self.class.route_regex)
-            match ? match[:feature_name] : nil
+            match ? Rack::Utils.unescape(match[:feature_name]) : nil
           end
         end
         private :feature_name

data/lib/flipper/api/middleware.rb

@@ -20,6 +20,7 @@ module Flipper
         @action_collection.add Api::V1::Actions::GroupsGate
         @action_collection.add Api::V1::Actions::BooleanGate
         @action_collection.add Api::V1::Actions::ClearFeature
+        @action_collection.add Api::V1::Actions::Actors
         @action_collection.add Api::V1::Actions::Feature
         @action_collection.add Api::V1::Actions::Features
       end

data/lib/flipper/api/v1/actions/actors.rb

@@ -0,0 +1,39 @@
+require 'flipper/api/action'
+require 'flipper/api/v1/decorators/actor'
+
+module Flipper
+  module Api
+    module V1
+      module Actions
+        class Actors < Api::Action
+          route %r{\A/actors/(?<flipper_id>.*)/?\Z}
+
+          def get
+            keys = params['keys']
+            features = if keys
+                         names = keys.split(',')
+                         if names.empty?
+                           []
+                         else
+                           flipper.preload(names)
+                         end
+                       else
+                         flipper.features
+                       end
+
+            actor = Flipper::Actor.new(flipper_id)
+            decorated_actor = Decorators::Actor.new(actor, features)
+            json_response(decorated_actor.as_json)
+          end
+
+          private
+
+          def flipper_id
+            match = request.path_info.match(self.class.route_regex)
+            match ? match[:flipper_id] : nil
+          end
+        end
+      end
+    end
+  end
+end

data/lib/flipper/api/v1/decorators/actor.rb

@@ -0,0 +1,35 @@
+module Flipper
+  module Api
+    module V1
+      module Decorators
+        class Actor < SimpleDelegator
+          # Public: the actor and features.
+          attr_reader :actor, :features
+
+          def initialize(actor, features)
+            @actor = actor
+            @features = features
+          end
+
+          def as_json
+            {
+              'flipper_id' => actor.flipper_id,
+              'features' => features_data,
+            }
+          end
+
+          private
+
+          def features_data
+            features.each_with_object({}) do |feature, features_hash|
+              features_hash[feature.name] = {
+                'enabled' => feature.enabled?(actor),
+              }
+              features_hash
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = '0.16.0'.freeze
+  VERSION = '0.16.1'.freeze
 end

data/spec/flipper/api/v1/actions/actors_spec.rb

@@ -0,0 +1,105 @@
+require 'helper'
+
+RSpec.describe Flipper::Api::V1::Actions::Actors do
+  let(:app) { build_api(flipper) }
+  let(:actor) { Flipper::Actor.new('User123') }
+
+  describe 'GET /actors/:flipper_id' do
+    before do
+      flipper[:my_feature_1].enable
+      flipper[:my_feature_2].disable
+      flipper[:my_feature_3].enable_actor(actor)
+    end
+
+    context 'when no feature is specified' do
+      before do
+        get "/actors/#{actor.flipper_id}"
+      end
+
+      it 'responds with success' do
+        expect(last_response.status).to eq(200)
+      end
+
+      it 'returns all features' do
+        expected_response = {
+          'flipper_id' => 'User123',
+          'features' => {
+            'my_feature_1' => {
+              'enabled' => true,
+            },
+            'my_feature_2' => {
+              'enabled' => false,
+            },
+            'my_feature_3' => {
+              'enabled' => true,
+            },
+          },
+        }
+
+        expect(json_response).to eq(expected_response)
+      end
+    end
+
+    context 'when features are specified' do
+      before do
+        get "/actors/#{actor.flipper_id}", keys: "my_feature_2,my_feature_3"
+      end
+
+      it 'responds with success' do
+        expect(last_response.status).to eq(200)
+      end
+
+      it 'returns all specified features' do
+        expected_response = {
+          'flipper_id' => 'User123',
+          'features' => {
+            'my_feature_2' => {
+              'enabled' => false,
+            },
+            'my_feature_3' => {
+              'enabled' => true,
+            },
+          },
+        }
+
+        expect(json_response).to eq(expected_response)
+      end
+    end
+
+    context 'when non-existent features are specified' do
+      before do
+        get "/actors/#{actor.flipper_id}", keys: "my_feature_3,not_a_feature"
+      end
+
+      it 'responds with success' do
+        expect(last_response.status).to eq(200)
+      end
+
+      it 'returns false for a non-existent feature' do
+        expected_response = {
+          'flipper_id' => 'User123',
+          'features' => {
+            'my_feature_3' => {
+              'enabled' => true,
+            },
+            'not_a_feature' => {
+              'enabled' => false,
+            },
+          },
+        }
+
+        expect(json_response).to eq(expected_response)
+      end
+    end
+
+    context 'when flipper id is missing' do
+      before do
+        get "/actors"
+      end
+
+      it 'responds with a 404' do
+        expect(last_response.status).to eq(404)
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-api
 version: !ruby/object:Gem::Version
-  version: 0.16.0
+  version: 0.16.1
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-01 00:00:00.000000000 Z
+date: 2019-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -36,14 +36,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.16.0
+        version: 0.16.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.16.0
+        version: 0.16.1
 description: Rack middleware that provides an API for the flipper gem.
 email:
 - nunemaker@gmail.com
@@ -60,6 +60,7 @@ files:
 - lib/flipper/api/error_response.rb
 - lib/flipper/api/json_params.rb
 - lib/flipper/api/middleware.rb
+- lib/flipper/api/v1/actions/actors.rb
 - lib/flipper/api/v1/actions/actors_gate.rb
 - lib/flipper/api/v1/actions/boolean_gate.rb
 - lib/flipper/api/v1/actions/clear_feature.rb
@@ -68,12 +69,14 @@ files:
 - lib/flipper/api/v1/actions/groups_gate.rb
 - lib/flipper/api/v1/actions/percentage_of_actors_gate.rb
 - lib/flipper/api/v1/actions/percentage_of_time_gate.rb
+- lib/flipper/api/v1/decorators/actor.rb
 - lib/flipper/api/v1/decorators/feature.rb
 - lib/flipper/api/v1/decorators/gate.rb
 - lib/flipper/version.rb
 - spec/flipper/api/action_spec.rb
 - spec/flipper/api/json_params_spec.rb
 - spec/flipper/api/v1/actions/actors_gate_spec.rb
+- spec/flipper/api/v1/actions/actors_spec.rb
 - spec/flipper/api/v1/actions/boolean_gate_spec.rb
 - spec/flipper/api/v1/actions/clear_feature_spec.rb
 - spec/flipper/api/v1/actions/feature_spec.rb
@@ -111,6 +114,7 @@ test_files:
 - spec/flipper/api/action_spec.rb
 - spec/flipper/api/json_params_spec.rb
 - spec/flipper/api/v1/actions/actors_gate_spec.rb
+- spec/flipper/api/v1/actions/actors_spec.rb
 - spec/flipper/api/v1/actions/boolean_gate_spec.rb
 - spec/flipper/api/v1/actions/clear_feature_spec.rb
 - spec/flipper/api/v1/actions/feature_spec.rb