flipper-active_record 0.7.5 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a81520344638895f43c0e1b4993d3e5d5fae5667
-  data.tar.gz: 1629de83c8f79141b91978b1aaf603e37e09f85e
+  metadata.gz: 474a975f3793633635b2c32cb0d3f7d55ade54ce
+  data.tar.gz: 60e86070951aab98717c5fb2804aeccda57e6881
 SHA512:
-  metadata.gz: b02a26809928457bee641aba482c3b955827f8d6b46f338f9a5665358d7fe75c4a78f50e8b7717b072b28a1a7d0e60eccf997a6831ce9cc306d8b2b9f698667b
-  data.tar.gz: d09d90bacb12b8a7ec37089c3e2c357a7b40351f666ff611cef7cbf6a5f1a482ff4e45d7385fbb8a4b92b14d74837a1882c151a2a77127867517b4eb38c3d72c
+  metadata.gz: 38abfe042ac090eb5854ccc3f346f99035a0b4a4a5b3571d477bb6c7d5a69550302e7bd069fd22ac4bf177a27d95e79792e2731d6ba453af613e4233978332f2
+  data.tar.gz: 5c2beec8be19d9b198af5886f2362b88018fe428c69a69ff4a9e9a6f3bd54de5a667c1613ee2485702010417b1d4ef1b3b51b2cd4cd1ff9df0dd03944845f4a4

data/lib/flipper/adapters/active_record.rb

@@ -5,7 +5,7 @@ require 'active_record'
 module Flipper
   module Adapters
     class ActiveRecord
-      include Flipper::Adapter
+      include ::Flipper::Adapter
 
       # Private: Do not use outside of this adapter.
       class Feature < ::ActiveRecord::Base
@@ -40,7 +40,7 @@ module Flipper
 
       # Public: The set of known features.
       def features
-        @feature_class.select(:key).map(&:key).to_set
+        @feature_class.all.map(&:key).to_set
       end
 
       # Public: Adds a feature to the set of known features.
@@ -105,11 +105,18 @@ module Flipper
       def enable(feature, gate, thing)
         case gate.data_type
         when :boolean, :integer
-          @gate_class.create!({
-            feature_key: feature.key,
-            key: gate.key,
-            value: thing.value.to_s,
-          })
+          @gate_class.transaction do
+            @gate_class.where(
+              feature_key: feature.key,
+              key: gate.key
+            ).delete_all
+
+            @gate_class.create!({
+              feature_key: feature.key,
+              key: gate.key,
+              value: thing.value.to_s,
+            })
+          end
         when :set
           @gate_class.create!({
             feature_key: feature.key,
@@ -135,11 +142,18 @@ module Flipper
         when :boolean
           clear(feature)
         when :integer
-          @gate_class.create!({
-            feature_key: feature.key,
-            key: gate.key,
-            value: thing.value.to_s,
-          })
+          @gate_class.transaction do
+            @gate_class.where(
+              feature_key: feature.key,
+              key: gate.key
+            ).delete_all
+
+            @gate_class.create!({
+              feature_key: feature.key,
+              key: gate.key,
+              value: thing.value.to_s,
+            })
+          end
         when :set
           @gate_class.where(feature_key: feature.key, key: gate.key, value: thing.value).delete_all
         else

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = "0.7.5"
+  VERSION = "0.8.0"
 end

data/test/adapters/active_record_test.rb

@@ -0,0 +1,24 @@
+require 'test_helper'
+require 'flipper/adapters/active_record'
+require 'generators/flipper/templates/migration'
+
+# Turn off migration logging for specs
+ActiveRecord::Migration.verbose = false
+
+class ActiveRecordTest < MiniTest::Test
+  prepend SharedAdapterTests
+
+  ActiveRecord::Base.establish_connection({
+    adapter: "sqlite3",
+    database: ":memory:",
+  })
+
+  def setup
+    @adapter = Flipper::Adapters::ActiveRecord.new
+    CreateFlipperTables.up
+  end
+
+  def teardown
+    CreateFlipperTables.down
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-active_record
 version: !ruby/object:Gem::Version
-  version: 0.7.5
+  version: 0.8.0
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-25 00:00:00.000000000 Z
+date: 2016-06-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flipper
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.5
+        version: 0.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.5
+        version: 0.8.0
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
@@ -61,6 +61,7 @@ files:
 - lib/generators/flipper/active_record_generator.rb
 - lib/generators/flipper/templates/migration.rb
 - spec/flipper/adapters/active_record_spec.rb
+- test/adapters/active_record_test.rb
 - test/generators/flipper/active_record_generator_test.rb
 homepage: https://github.com/jnunemaker/flipper
 licenses:
@@ -88,4 +89,5 @@ specification_version: 4
 summary: ActiveRecord adapter for Flipper
 test_files:
 - spec/flipper/adapters/active_record_spec.rb
+- test/adapters/active_record_test.rb
 - test/generators/flipper/active_record_generator_test.rb