flipper-active_record 0.10.2 → 0.11.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b3f630ced8e147d7e7278e14d09ef3ea8cf43c7c
-  data.tar.gz: 5686e445a68398169fc238d09446cdf87e0bd4ab
+  metadata.gz: ab2e2560bca689141f6f486224f97abe87ded3a2
+  data.tar.gz: a26ecd4f4a019af72b44c3aa38a93332c3d7b0e0
 SHA512:
-  metadata.gz: 862d115e1492cb8a10c1351609ac05c01027400032bbc7845e7a9bf24adef731b9266c6efa35deb84447e0852714c21cd87b9db164c397d16345a8048d8b0980
-  data.tar.gz: 4a7bb4aba98a72cbf907dae022d96b539d73f00d41bd6ae807cb504e215e599c435ffdbc21963f1e6b96c01b36a3c4de2e92cce99c8b42525e9050881e3222b1
+  metadata.gz: c829cb8be44d1881630fef42431519d547df19bd74fa19ef486d09b287161fc5e8d7fde69f93e0c2be2d9a0eb58300e8d772c4bc7b1f2a4f295453308a1d0779
+  data.tar.gz: 1675a0478c9313f3a7f6e4056cd11d1548e17f4583e8741d44908bd1ce2445f588c0eecda84e2bb106b2073444a2f9c51ef9bb837349c1997da2a7808cad873b

data/docs/active_record/README.md

@@ -6,6 +6,7 @@ Supported Active Record versions:
 
 * 3.2.x
 * 4.2.x
+* 5.0.x
 
 ## Installation
 
@@ -23,7 +24,7 @@ Or install it yourself with:
 
 ## Usage
 
-For your convenience a migration generator is provided to create the necessary migrations for using the active record adapter. By default this generates a migration that will create two database tables - flipper_features and flipper_gates.   
+For your convenience a migration generator is provided to create the necessary migrations for using the active record adapter. By default this generates a migration that will create two database tables - flipper_features and flipper_gates.
 
     $ rails g flipper:active_record
 

data/flipper-active_record.gemspec

@@ -1,28 +1,28 @@
 # -*- encoding: utf-8 -*-
 require File.expand_path('../lib/flipper/version', __FILE__)
 
-flipper_active_record_files = lambda { |file|
+flipper_active_record_files = lambda do |file|
   file =~ /active_record/
-}
+end
 
 Gem::Specification.new do |gem|
-  gem.authors       = ["John Nunemaker"]
-  gem.email         = ["nunemaker@gmail.com"]
-  gem.summary       = "ActiveRecord adapter for Flipper"
-  gem.description   = "ActiveRecord adapter for Flipper"
-  gem.license       = "MIT"
-  gem.homepage      = "https://github.com/jnunemaker/flipper"
+  gem.authors       = ['John Nunemaker']
+  gem.email         = ['nunemaker@gmail.com']
+  gem.summary       = 'ActiveRecord adapter for Flipper'
+  gem.description   = 'ActiveRecord adapter for Flipper'
+  gem.license       = 'MIT'
+  gem.homepage      = 'https://github.com/jnunemaker/flipper'
 
   extra_files = [
-    "lib/generators/flipper/templates/migration.rb",
-    "lib/flipper/version.rb",
+    'lib/generators/flipper/templates/migration.rb',
+    'lib/flipper/version.rb',
   ]
   gem.files         = `git ls-files`.split("\n").select(&flipper_active_record_files) + extra_files
   gem.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n").select(&flipper_active_record_files)
-  gem.name          = "flipper-active_record"
-  gem.require_paths = ["lib"]
+  gem.name          = 'flipper-active_record'
+  gem.require_paths = ['lib']
   gem.version       = Flipper::VERSION
 
   gem.add_dependency 'flipper', "~> #{Flipper::VERSION}"
-  gem.add_dependency 'activerecord', ">= 3.2", "< 6"
+  gem.add_dependency 'activerecord', '>= 3.2', '< 6'
 end

data/lib/flipper/adapters/active_record.rb

@@ -9,12 +9,12 @@ module Flipper
 
       # Private: Do not use outside of this adapter.
       class Feature < ::ActiveRecord::Base
-        self.table_name = "flipper_features"
+        self.table_name = 'flipper_features'
       end
 
       # Private: Do not use outside of this adapter.
       class Gate < ::ActiveRecord::Base
-        self.table_name = "flipper_gates"
+        self.table_name = 'flipper_gates'
       end
 
       # Public: The name of the adapter.
@@ -78,7 +78,7 @@ module Flipper
 
       def get_multi(features)
         db_gates = @gate_class.where(feature_key: features.map(&:key))
-        grouped_db_gates = db_gates.group_by { |gate| gate.feature_key }
+        grouped_db_gates = db_gates.group_by(&:feature_key)
         result = {}
         features.each do |feature|
           result[feature.key] = result_for_feature(feature, grouped_db_gates[feature.key])
@@ -90,7 +90,7 @@ module Flipper
       #
       # feature - The Flipper::Feature for the gate.
       # gate - The Flipper::Gate to disable.
-      # thing - The Flipper::Type being disabled for the gate.
+      # thing - The Flipper::Type being enabled for the gate.
       #
       # Returns true.
       def enable(feature, gate, thing)
@@ -165,20 +165,21 @@ module Flipper
         db_gates ||= []
         result = {}
         feature.gates.each do |gate|
-          result[gate.key] = case gate.data_type
-          when :boolean
-            if db_gate = db_gates.detect { |db_gate| db_gate.key == gate.key.to_s }
-              db_gate.value
-            end
-          when :integer
-            if db_gate = db_gates.detect { |db_gate| db_gate.key == gate.key.to_s }
-              db_gate.value
+          result[gate.key] =
+            case gate.data_type
+            when :boolean
+              if db_gate = db_gates.detect { |db_gate| db_gate.key == gate.key.to_s }
+                db_gate.value
+              end
+            when :integer
+              if db_gate = db_gates.detect { |db_gate| db_gate.key == gate.key.to_s }
+                db_gate.value
+              end
+            when :set
+              db_gates.select { |db_gate| db_gate.key == gate.key.to_s }.map(&:value).to_set
+            else
+              unsupported_data_type gate.data_type
             end
-          when :set
-            db_gates.select { |db_gate| db_gate.key == gate.key.to_s }.map(&:value).to_set
-          else
-            unsupported_data_type gate.data_type
-          end
         end
         result
       end

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = "0.10.2".freeze
+  VERSION = '0.11.0.beta1'.freeze
 end

data/lib/generators/flipper/active_record_generator.rb

@@ -1,15 +1,15 @@
-require "rails/generators/active_record"
+require 'rails/generators/active_record'
 
 module Flipper
   module Generators
     class ActiveRecordGenerator < ::Rails::Generators::Base
       include ::Rails::Generators::Migration
-      desc "Generates migration for flipper tables"
+      desc 'Generates migration for flipper tables'
 
-      source_paths << File.join(File.dirname(__FILE__), "templates")
+      source_paths << File.join(File.dirname(__FILE__), 'templates')
 
       def create_migration_file
-        migration_template "migration.rb", "db/migrate/create_flipper_tables.rb"
+        migration_template 'migration.rb', 'db/migrate/create_flipper_tables.rb'
       end
 
       def self.next_migration_number(dirname)

data/spec/flipper/adapters/active_record_spec.rb

@@ -11,10 +11,8 @@ RSpec.describe Flipper::Adapters::ActiveRecord do
   subject { described_class.new }
 
   before(:all) do
-    ActiveRecord::Base.establish_connection({
-      adapter: "sqlite3",
-      database: ":memory:",
-    })
+    ActiveRecord::Base.establish_connection(adapter: 'sqlite3',
+                                            database: ':memory:')
   end
 
   before(:each) do

data/test/adapters/active_record_test.rb

@@ -8,10 +8,8 @@ ActiveRecord::Migration.verbose = false
 class ActiveRecordTest < MiniTest::Test
   prepend Flipper::Test::SharedAdapterTests
 
-  ActiveRecord::Base.establish_connection({
-    adapter: "sqlite3",
-    database: ":memory:",
-  })
+  ActiveRecord::Base.establish_connection(adapter: 'sqlite3',
+                                          database: ':memory:')
 
   def setup
     @adapter = Flipper::Adapters::ActiveRecord.new

data/test/generators/flipper/active_record_generator_test.rb

@@ -5,12 +5,12 @@ require 'generators/flipper/active_record_generator'
 
 class FlipperActiveRecordGeneratorTest < Rails::Generators::TestCase
   tests Flipper::Generators::ActiveRecordGenerator
-  destination File.expand_path("../../../../tmp", __FILE__)
+  destination File.expand_path('../../../../tmp', __FILE__)
   setup :prepare_destination
 
   def test_generates_migration
     run_generator
-    assert_migration "db/migrate/create_flipper_tables.rb", <<-EOM
+    assert_migration 'db/migrate/create_flipper_tables.rb', <<-EOM
 class CreateFlipperTables < ActiveRecord::Migration
   def self.up
     create_table :flipper_features do |t|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-active_record
 version: !ruby/object:Gem::Version
-  version: 0.10.2
+  version: 0.11.0.beta1
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-08 00:00:00.000000000 Z
+date: 2017-04-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flipper
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.2
+        version: 0.11.0.beta1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.2
+        version: 0.11.0.beta1
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
@@ -78,12 +78,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: ActiveRecord adapter for Flipper