flippant 0.5.1 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 789d87077103358106ef05baa2f5b9e1092381f7
-  data.tar.gz: 0faa56a65bf93a2b5188ab4955d3053d36827a15
+  metadata.gz: 8c259d40ca6b2cbd3305d2ab5a1c2ba425794886
+  data.tar.gz: 913b5c2043ae9b6c6c2ecea20666f0c82e3dc444
 SHA512:
-  metadata.gz: a9ce9e3308dfc90b92ed293f4b0c15c0173af582431f07fb5b9d711cba1370599849f8288415fd1b1405938eef438126c5dcab4b9bf98bdd68e442cff5c2ecd8
-  data.tar.gz: de554386d07953e2b7f70ee0dfb1d41032a9ed5bfcad582fd9223bc3531eef3766269f84a574d382af3d197ecd85451cd744be6949de71334ed93cbeac69c875
+  metadata.gz: 627e7caa8606d1d7b002f513553be1a5e0bea1647ae35d111ccc71962b496fb2b0f0b93669233fe67e97e283321a41dbb54f03d545a09b35c3e8fd9adc1041ce
+  data.tar.gz: 919ce1da13ee2f5e7353eb0f96b892aea75bf006b148cb125e0cbbed25ffec8c421a3658df4a9766a8210f741037a4f71744d6447cdd5ee9a16160546f508aa0

data/.rubocop.yml

@@ -4,6 +4,15 @@ AllCops:
     - "vendor/**/*"
   TargetRubyVersion: 2.3
 
+Metrics/AbcSize:
+  Max: 20
+
+Metrics/ClassLength:
+  Max: 200
+
+Metrics/MethodLength:
+  Max: 20
+
 Style/FrozenStringLiteralComment:
   EnforcedStyle: always
   Exclude:

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## v0.6.0 - 2017-08-08
+
+### Changes
+
+* [Flippant] - Allow passing symbols to disable a feature.
+* [Flippant] - Raise an error when enabling a feature for a group that doesn't
+  exist. This forces an order of defining groups before enabling features, but
+  it will prevent trying to register groups that don't exist or with typos.
+
 ## v0.5.1 - 2017-01-26
 
 ### Changes

data/Rakefile

@@ -15,4 +15,4 @@ rescue LoadError
   puts "rubocop not loaded"
 end
 
-task default: [:rubocop, :spec]
+task default: %i[rubocop spec]

data/flippant.gemspec

@@ -1,4 +1,5 @@
 # coding: utf-8
+
 lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "flippant/version"
@@ -21,8 +22,8 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.13"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "bundler"
+  spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec", "~> 3.2"
   spec.add_development_dependency "redis", "~> 3.3"
   spec.add_development_dependency "rubocop", "~> 0.47"

data/lib/flippant.rb

@@ -3,6 +3,7 @@
 require "json"
 
 module Flippant
+  autoload :Error, "flippant/errors"
   autoload :Registry, "flippant/registry"
 
   module Adapter
@@ -17,20 +18,31 @@ module Flippant
 
   def_delegators :adapter,
                  :add,
-                 :remove,
-                 :enable,
+                 :breakdown,
+                 :clear,
+                 :disable,
                  :enabled?,
                  :exists?,
-                 :disable,
                  :features,
-                 :breakdown,
-                 :clear
+                 :remove,
+                 :rename
 
   def_delegators :registry,
                  :register,
                  :registered,
+                 :registered?,
                  :clear
 
+  # Guarded Delegation
+
+  def enable(feature, group, values = [])
+    raise Flippant::Error, "Unknown group: #{group}" unless registered?(group)
+
+    adapter.enable(feature, group, values)
+  end
+
+  # Configuration
+
   def adapter
     @adapter ||= Flippant::Adapter::Memory.new
   end

data/lib/flippant/adapters/memory.rb

@@ -10,7 +10,7 @@ module Flippant
       end
 
       def add(feature)
-        table[feature.to_s] ||= {}
+        table[normalize(feature)] ||= {}
       end
 
       def remove(feature)
@@ -18,21 +18,19 @@ module Flippant
       end
 
       def enable(feature, group, values = [])
-        fkey = feature.to_s
+        fkey = normalize(feature)
         gkey = group.to_s
-        mutex = Mutex.new
 
-        mutex.synchronize do
+        Mutex.new.synchronize do
           table[fkey][gkey] ||= []
           table[fkey][gkey] = (table[fkey][gkey] | values).sort
         end
       end
 
       def disable(feature, group, values = [])
-        rules = table[feature.to_s]
-        mutex = Mutex.new
+        rules = table[normalize(feature)]
 
-        mutex.synchronize do
+        Mutex.new.synchronize do
           if values.any?
             remove_values(rules, group, values)
           else
@@ -41,8 +39,15 @@ module Flippant
         end
       end
 
+      def rename(old_feature, new_feature)
+        old_feature = normalize(old_feature)
+        new_feature = normalize(new_feature)
+
+        table[new_feature] = table.delete(old_feature)
+      end
+
       def enabled?(feature, actor, registered = Flippant.registered)
-        table[feature.to_s].any? do |group, values|
+        table[normalize(feature)].any? do |group, values|
           if (block = registered[group.to_s])
             block.call(actor, values)
           end
@@ -50,6 +55,8 @@ module Flippant
       end
 
       def exists?(feature, group = nil)
+        feature = normalize(feature)
+
         if group.nil?
           table.key?(feature)
         else
@@ -81,12 +88,16 @@ module Flippant
 
       private
 
+      def normalize(feature)
+        feature.to_s.downcase.strip
+      end
+
       def remove_group(rules, to_remove)
         rules.reject! { |(group, _)| group == to_remove.to_s }
       end
 
       def remove_values(rules, group, values)
-        rules[group] = (rules[group] - values)
+        rules[group.to_s] = (rules[group.to_s] - values)
       end
     end
   end

data/lib/flippant/adapters/redis.rb

@@ -22,7 +22,7 @@ module Flippant
       end
 
       def add(feature)
-        client.sadd(key, feature)
+        client.sadd(key, normalize(feature))
       end
 
       def remove(feature)
@@ -54,6 +54,21 @@ module Flippant
         maybe_cleanup(feature)
       end
 
+      def rename(old_feature, new_feature)
+        old_feature = normalize(old_feature)
+        new_feature = normalize(new_feature)
+        old_namespaced = namespace(old_feature)
+        new_namespaced = namespace(new_feature)
+
+        client.watch(old_namespaced, new_namespaced) do
+          client.multi do
+            client.srem(key, old_feature)
+            client.sadd(key, new_feature)
+            client.rename(old_namespaced, new_namespaced)
+          end
+        end
+      end
+
       def enabled?(feature, actor, registered = Flippant.registered)
         client.hgetall(namespace(feature)).any? do |group, values|
           if (block = registered[group])
@@ -111,7 +126,11 @@ module Flippant
       end
 
       def namespace(feature)
-        "#{key}-#{feature}"
+        "#{key}-#{normalize(feature)}"
+      end
+
+      def normalize(feature)
+        feature.to_s.downcase.strip
       end
 
       def change_values(namespaced, group)

data/lib/flippant/errors.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+module Flippant
+  Error = Class.new(StandardError)
+end

data/lib/flippant/registry.rb

@@ -14,6 +14,10 @@ module Flippant
       table
     end
 
+    def registered?(group)
+      table.key?(group.to_s)
+    end
+
     def clear
       @table = {}
     end

data/lib/flippant/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Flippant
-  VERSION = "0.5.1"
+  VERSION = "0.6.0"
 end

metadata

@@ -1,43 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: flippant
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.6.0
 platform: ruby
 authors:
 - Parker Selbert
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-01-26 00:00:00.000000000 Z
+date: 2017-08-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.13'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.13'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -104,6 +104,7 @@ files:
 - lib/flippant.rb
 - lib/flippant/adapters/memory.rb
 - lib/flippant/adapters/redis.rb
+- lib/flippant/errors.rb
 - lib/flippant/registry.rb
 - lib/flippant/rules.rb
 - lib/flippant/version.rb