flipflop 2.5.0 → 2.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2285d1f81e213c214eba67b891e72bd671b2dea7096759ba142bd8457197c671
-  data.tar.gz: d560e6dc20e028641bea194e4626b2103e0e4999e40308b3f3d9009574090c64
+  metadata.gz: 8a26786a65478a45e78fe52884fd99b5a5a7e390bde362ce211832e57e3f66f9
+  data.tar.gz: 6a75c2816df20f8ead6f24bcab02f4c2460fad380f6fbcd2ef1a79c3f9234fb9
 SHA512:
-  metadata.gz: 31b1406c3ab135e4bf628040914ea4057ab37bef82909e180da668d60365abf480081819720d4d044baabea59940167f3353d2478ba3433a1867e035dce981e9
-  data.tar.gz: 2f78138c8de1ae3b96bdf511effbad20cf0e08b66764ce82b159f024c32868c78f9ced8c6918bc52ce316b7599a4301f03583006d58de441f72835a694aa4a09
+  metadata.gz: 47ecb8aeb5efb349c5a7366a559bd8eab2beb38dde0b19aa1202deae013072a3b158c1e77825241a372f2543287022d6a1d9e649755bf0130c3d823e6f604fdf
+  data.tar.gz: fba2c4ca6ab07e14623d06470f733f54f1415198586792e5aee6e2f81e896a5c02973c0b2efb550d10e63d861cb0d617e23fbd6b87e4681c289322a408838f27

data/CHANGES.md

@@ -1,3 +1,7 @@
+## 2.6.0
+
+* Failure to load strategies in test environments will result in a warning instead of an error. This should aid in running Rake tasks.
+
 ## 2.5.0
 
 * Add Sequel strategy. ActiveRecord/Sequel can be used side by side.

data/lib/flipflop/configurable.rb

@@ -32,6 +32,12 @@ module Flipflop
       end
 
       FeatureSet.current.use(strategy)
+    rescue StandardError => err
+      if FeatureSet.current.raise_strategy_errors
+        raise err
+      else
+        warn "WARNING: Unable to load Flipflop strategy #{strategy}: #{err}"
+      end
     end
   end
 end

data/lib/flipflop/feature_set.rb

@@ -28,7 +28,10 @@ module Flipflop
       private :new
     end
 
+    attr_reader :raise_strategy_errors
+
     def initialize
+      @raise_strategy_errors = (ENV["RACK_ENV"] || ENV["RAILS_ENV"]) != "test"
       @features = {}
       @strategies = {}
     end

data/lib/flipflop/version.rb

@@ -1,3 +1,3 @@
 module Flipflop
-  VERSION = "2.5.0"
+  VERSION = "2.6.0"
 end

data/test/test_helper.rb

@@ -31,6 +31,20 @@ def create_request
   request
 end
 
+def capture_stdout
+  stdout, $stdout = $stdout, StringIO.new
+  yield rescue nil
+  stdout, $stdout = $stdout, stdout
+  stdout.string
+end
+
+def capture_stderr
+  stderr, $stderr = $stderr, StringIO.new
+  yield rescue nil
+  stderr, $stderr = $stderr, stderr
+  stderr.string
+end
+
 def reload_constant(name)
   ActiveSupport::Dependencies.remove_constant(name.to_s)
   path = ActiveSupport::Dependencies.search_for_file(name.to_s.underscore).sub!(/\.rb\z/, "")
@@ -162,7 +176,7 @@ class TestApp
   def migrate!
     ActiveRecord::Base.establish_connection
 
-    silence_stdout { ActiveRecord::Tasks::DatabaseTasks.create_current }
+    capture_stdout { ActiveRecord::Tasks::DatabaseTasks.create_current }
     ActiveRecord::Migration.verbose = false
 
     if defined?(ActiveRecord::Migrator.migrate)
@@ -174,6 +188,7 @@ class TestApp
   end
 
   def unload!
+    ENV["RAILS_ENV"] = nil
     Flipflop::Strategies::AbstractStrategy::RequestInterceptor.request = nil
     Flipflop::FeatureLoader.instance_variable_set(:@current, nil)
 
@@ -192,12 +207,6 @@ class TestApp
 
   private
 
-  def silence_stdout
-    stdout, $stdout = $stdout, StringIO.new
-    yield rescue nil
-    $stdout = stdout
-  end
-
   def path
     "tmp/" + name
   end

data/test/unit/configurable_test.rb

@@ -1,5 +1,12 @@
 require File.expand_path("../../test_helper", __FILE__)
 
+class FailingStrategy < Flipflop::Strategies::AbstractStrategy
+  def initialize(*)
+    raise "Oops"
+  end
+end
+
+
 describe Flipflop::Configurable do
   subject do
     Flipflop::FeatureSet.current.send(:initialize)
@@ -100,5 +107,30 @@ describe Flipflop::Configurable do
       assert_equal ["awesome"],
         Flipflop::FeatureSet.current.strategies.map(&:description)
     end
+
+    it "should raise error when strategy fails to load" do
+      begin
+        rack_env, ENV["RACK_ENV"] = ENV["RACK_ENV"], nil
+        rails_env, ENV["RAILS_ENV"] = ENV["RAILS_ENV"], nil
+        assert_raises "Oops" do
+          subject.strategy(FailingStrategy)
+        end
+      ensure
+        ENV["RACK_ENV"] = rack_env
+        ENV["RAILS_ENV"] = rails_env
+      end
+    end
+
+    it "should not raise error when strategy fails to load in test mode" do
+      begin
+        rack_env, ENV["RACK_ENV"] = ENV["RACK_ENV"], "test"
+        rails_env, ENV["RAILS_ENV"] = ENV["RAILS_ENV"], "test"
+        assert_equal "WARNING: Unable to load Flipflop strategy FailingStrategy: Oops\n",
+          capture_stderr { subject.strategy(FailingStrategy) }
+      ensure
+        ENV["RACK_ENV"] = rack_env
+        ENV["RAILS_ENV"] = rails_env
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: flipflop
 version: !ruby/object:Gem::Version
-  version: 2.5.0
+  version: 2.6.0
 platform: ruby
 authors:
 - Paul Annesley
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-19 00:00:00.000000000 Z
+date: 2019-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -128,7 +128,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubyforge_project: 
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: A feature flipflopper for Rails web applications.