flipflop 2.3.0 → 2.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0a2273ae05773bcf363232d55a5220c8da41f39a
-  data.tar.gz: 8fd2d51b80011ef69c993b389e15170f29f9d5eb
+  metadata.gz: 79ce3ddc4c05be4f6b655519b73fc592b749177a
+  data.tar.gz: 9de114a7fa334e5689d9bb49e6b2c0e0189b59b4
 SHA512:
-  metadata.gz: 5aaab9397951347310618fce6c9e3223a4b0435f7bcbf9f34ce51785465d6d6bdbb0060c60563e4ef9bf6abf560c437551644a2eb9077c62b58746c451deac1d
-  data.tar.gz: c7c18fcb35fb1eb5adcd55ca6ae1c5c8fad679a1aa9a2612774f6ef27b969a2d784b0a3784cf9e1f6d5a3ac98f8d5013a0f860093afde5c1e7a911728bc2fc86
+  metadata.gz: d89175f3cdf7c36f31fa22ec6b3174bf3d69399ec2ad58d1c1c68bbb5e239456b85c3386144414e5e40ce87d4c504f49cdbc54293aa5b9659dedcba237b94e9c
+  data.tar.gz: d5a233ec2f53cdfb4d1aacd6afda3b385618887cfb524a6f7fc6de5eb0ad2ad05b949080a34e8e48eab5f4c18fd6dae571affee63ca576533ebf6277f153360c

data/.travis.yml

@@ -32,10 +32,6 @@ matrix:
   - rvm: jruby-9.1.2.0
   - rvm: ruby-head
   - rvm: jruby-head
-notifications:
-  email: false
-  slack:
-    secure: crOO1QGnFn9T1DpVgxkukTSiN8lQq09X8WF8oi1Eoa7Liex4gzWq7f8wlIXPrRFAsNjU47fSrz+L1C6Eg068Vd2df9pkqjW0pLNeqUViJ35TzpYISTtzJrX+x3nvCQLlvS4leP6lkijlsvlu1IN0xnXadW5cmcMoEcPo4Yma1RUklwlreSRIEmJiutYKVFRw3gIZA9vsnXNEcD408mvSY/8Kuw+hmRQupODUalXDpZo1q3HH+ZPQq+/rGuJ7XRf9sBtxjpUF0G4FJZQhVP4CrLNYVBE/83rHJ6HSf6u3SlYVIMiautq0nWpVLPHUrkOPJVeVh6EPtoFeI/cehH1NyoAVvL5a39wFRBlJ4jVPWUrrnihJT/6+P6GM9PSnYogxtIoTsdrYES2FgtWGgwG5uLyw8U6bW7G7rCzQwBP7enVHWVCbDgdSSjE1Mg1I9qhRuL6pHs5des4VKk6pfD3p+BRqLmOZR2jx4v8MFwakSFqQWOMxaD0U1lfxecqSx9OkwWEhCFSnHeXeHInEhY6qKCdZZzT+beYn0xppUMPJGMTqe5+po8gL+5MxQwI8Xs/5hSve5frfmuS7UQf5BnFMOzwoThQrXCFRz58wXvcZTD9eTdVBV44Hsi5OLdYn9K58sNUhgcxGfRgdE7Gy9P7DD4fHPGakD/Tz++HuCmCUXNs=
 before_deploy: rake assets:compile
 deploy:
   provider: rubygems

data/CHANGES.md

@@ -1,3 +1,7 @@
+## 2.3.1
+
+* Fixed backwards compatibility of strategies controller. The incompatibility was introduced in 2.3.0. (@jcoyne)
+
 ## 2.3.0
 
 * Support for Rails API only apps.

data/LICENSE

@@ -1,7 +1,7 @@
 The MIT License
 
 Copyright (c) 2011-2013 Learnable Pty Ltd
-Copyright (c) 2016 Voormedia
+Copyright (c) 2016-2017 Voormedia
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -285,6 +285,15 @@ class MyEngine < Rails::Engine
 end
 ```
 
+## Internationalization
+
+The dashboard is translatable. Make sure `I18n.locale` is set to the correct
+value in your `ApplicationController` or alternatively in
+`dashboard_access_filter`.
+
+Take a look at [the English translations](config/locales/en.yml) to see which
+keys should be present and translated in your locale file.
+
 ## Testing
 
 In your test environment, you typically want to keep your features. But to make

data/app/controllers/flipflop/strategies_controller.rb

@@ -14,8 +14,13 @@ module Flipflop
 
     private
 
+    # Modeled after ActiveModel::Type::Boolean, but only returns boolean values
+    # (never nil) and checks for true values, because that's what earlier
+    # versions of Flipflop did.
+    ENABLE_VALUES = %w(1 on ON t T).to_set.freeze
+
     def enable?
-      params[:commit].to_s == "1"
+      ENABLE_VALUES.include?(params[:commit])
     end
 
     def feature_key

data/lib/flipflop/version.rb

@@ -1,3 +1,3 @@
 module Flipflop
-  VERSION = "2.3.0"
+  VERSION = "2.3.1"
 end

data/test/unit/strategies_controller_test.rb

@@ -0,0 +1,29 @@
+require File.expand_path("../../test_helper", __FILE__)
+
+describe "Flipflop::StrategiesController" do
+  subject do
+    Flipflop::StrategiesController.new
+  end
+
+  describe "enable?" do
+    it "should return false when commit is empty" do
+      subject.params = ActionController::Parameters.new(commit: "")
+      assert_same subject.send(:enable?), false
+    end
+
+    it "should return false when commit is nil" do
+      subject.params = ActionController::Parameters.new
+      assert_same subject.send(:enable?), false
+    end
+
+    it "should return true when commit is on" do
+      subject.params = ActionController::Parameters.new(commit: "on")
+      assert_same subject.send(:enable?), true
+    end
+
+    it "should return true when commit is 1" do
+      subject.params = ActionController::Parameters.new(commit: "1")
+      assert_same subject.send(:enable?), true
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: flipflop
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.3.1
 platform: ruby
 authors:
 - Paul Annesley
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-28 00:00:00.000000000 Z
+date: 2017-03-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -109,6 +109,7 @@ files:
 - test/unit/strategies/redis_strategy_test.rb
 - test/unit/strategies/session_strategy_test.rb
 - test/unit/strategies/test_strategy_test.rb
+- test/unit/strategies_controller_test.rb
 homepage: https://github.com/voormedia/flipflop
 licenses:
 - MIT