flip 0.0.3 → 0.0.4

data/lib/flip/declaration_strategy.rb

@@ -8,7 +8,7 @@ module Flip
     end
 
     def knows? definition
-      definition.options.key? :default
+      !definition.options[:default].nil?
     end
 
     def on? definition

data/lib/flip/version.rb

@@ -1,3 +1,3 @@
 module Flip
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/declaration_strategy_spec.rb

@@ -7,26 +7,32 @@ describe Flip::DeclarationStrategy do
   end
 
   describe "#knows?" do
-    specify "definition without default should be false" do
+    it "does not know definition with no default specified" do
       subject.knows?(Flip::Definition.new :feature).should be_false
     end
-    specify " should be true" do
+    it "does not know definition with default of nil" do
+      subject.knows?(definition(nil)).should be_false
+    end
+    it "knows definition with default set to true" do
       subject.knows?(definition(true)).should be_true
     end
+    it "knows definition with default set to false" do
+      subject.knows?(definition(false)).should be_true
+    end
   end
 
-  describe "#on? for Flip::Definition with default of" do
-    specify "true" do
-      subject.on?(definition(true)).should be_true
-    end
-    specify "false" do
-      subject.on?(definition(false)).should be_false
-    end
-    specify "proc returning true" do
-      subject.on?(definition(proc { true })).should be_true
-    end
-    specify "proc returning false" do
-      subject.on?(definition(proc { false })).should be_false
+  describe "#on? for Flip::Definition" do
+    subject { Flip::DeclarationStrategy.new.on? definition(default) }
+    [
+      { default: true, result: true },
+      { default: false, result: false },
+      { default: proc { true }, result: true, name: "proc returning true" },
+      { default: proc { false }, result: false, name: "proc returning false" },
+    ].each do |parameters|
+      context "with default of #{parameters[:name] || parameters[:default]}" do
+        let(:default) { parameters[:default] }
+        it { should == parameters[:result] }
+      end
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: flip
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-10 00:00:00.000000000 Z
+date: 2011-12-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70214336000200 !ruby/object:Gem::Requirement
+  requirement: &70160385209800 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70214336000200
+  version_requirements: *70160385209800
 - !ruby/object:Gem::Dependency
   name: i18n
-  requirement: &70214335999180 !ruby/object:Gem::Requirement
+  requirement: &70160385207660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70214335999180
+  version_requirements: *70160385207660
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70214335997480 !ruby/object:Gem::Requirement
+  requirement: &70160380032000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: '2.5'
   type: :development
   prerelease: false
-  version_requirements: *70214335997480
+  version_requirements: *70160380032000
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70214335996600 !ruby/object:Gem::Requirement
+  requirement: &70160380031580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +54,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70214335996600
+  version_requirements: *70160380031580
 description: Declarative API for specifying features, switchable in declaration, database
   and cookies.
 email: