flinks 0.5.1 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 304cf08db5ce170b00ab1e0612aed08897782944311ffa712c4f166e635b5858
-  data.tar.gz: 5ae67cbe3eb0e5bcd530d1393e36b0324dfd2a1030939b7ad68d1c035744ed00
+  metadata.gz: 6b40e64a6fdd3224f7d5a86a3502d1e5a02fdff126185d423242344cab8c258b
+  data.tar.gz: 0aa9f408a0dd6035c12b2c8d19c0bae39fc36cc0067ad6a418fafa03a7a087af
 SHA512:
-  metadata.gz: e6f79ff1f8067e3fed0f85c625da31e749621e7e4ef8d420e1dca10ec0f8e8494d371b100899db4b18ba4ec6950501ca6179ad3e771d3ad12d673bc48b91c36f
-  data.tar.gz: d362cfe96d541365a37b6138b5857889c0ee433e830ea05d0553285863a3bf8c33313d332aebed46cc13528e16d4f4d54dc520f6eb321110f7eb33888e4fef41
+  metadata.gz: 5327ea28eb69a990f2ec97bf598f575c59782dfe994370802f142489aee171749d02b85c5b70f4479960ad5c40b7f33ce0aa79a9ee164065adb20080d85496e7
+  data.tar.gz: af1c6fef96e05380e20391394fce5687a2f79d2d8204ca29f8bf9d97b92d87d45a911c00c11f50637e3600967818fa7fe506ae732b61b2ca34deca5849340d95

data/VERSION

@@ -1 +1 @@
-0.5.1
+0.5.2

data/flinks.gemspec

@@ -2,11 +2,11 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: flinks 0.5.1 ruby lib
+# stub: flinks 0.5.2 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "flinks".freeze
-  s.version = "0.5.1"
+  s.version = "0.5.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]

data/lib/flinks/api/card.rb

@@ -8,7 +8,9 @@ module Flinks
       # @param [String] login_id
       # @return [Hash]
       def delete_card(login_id:)
-        delete("#{customer_id}/BankingServices/DeleteCard/#{login_id}")
+        delete("#{customer_id}/BankingServices/DeleteCard/#{login_id}").tap do |response|
+          raise Flinks::NotFound, "Invalid LoginId" if response.match(/Invalid LoginId/)
+        end
       end
     end
   end

data/lib/flinks/error.rb

@@ -2,7 +2,7 @@
 
 module Flinks
   class Error < StandardError
-    attr_reader :response, :code
+    attr_accessor :response, :code
 
     # @param [HTTP::Response] response
     # @return [Flinks::Error]
@@ -28,7 +28,11 @@ module Flinks
                 self
               end
 
-      klass.new(response)
+      error          = klass.new(build_message(response))
+      error.response = response
+      error.code     = response.code
+
+      error
     end
 
     # @param [HTTP::Response] response
@@ -62,16 +66,8 @@ module Flinks
     end
 
     # @param [HTTP::Response] response
-    # @return [Flinks::Error]
-    def initialize(response)
-      @response = response
-      @code = response.code
-
-      super(build_message)
-    end
-
     # @return [String]
-    def build_message
+    def self.build_message(response)
       message = response.parse['Message']
       message << " - FlinksCode: #{response.parse['FlinksCode']}"
     rescue HTTP::Error

data/lib/flinks/request.rb

@@ -34,6 +34,15 @@ module Flinks
       request(:patch, path, params: params, body: body)
     end
 
+    # Performs a HTTP Delete request
+    #
+    # @param [String] path
+    # @param [Hash] params
+    # @param [Hash] body
+    def delete(path, params: {}, body: {})
+      request(:delete, path, params: params, body: body)
+    end
+
 
     private
 
@@ -74,10 +83,10 @@ module Flinks
       data = response.parse
 
       # Transform data
-      if raw
-        data
-      else
+      if !raw && raw.is_a?(Hash)
         data.deep_transform_keys { |k| k.underscore }.with_indifferent_access
+      else
+        data
       end
     end
   end

data/spec/lib/api/card_spec.rb

@@ -3,16 +3,16 @@ require 'spec_helper'
 describe Flinks::API::Card do
   let(:api_endpoint) { Flinks::Client.dry_initializer.definitions[:api_endpoint].default.call }
   let(:client) { Flinks.new(customer_id: 'customer_id') }
-  let(:card_id) { 'card_id' }
+  let(:login_id) { 'login_id' }
 
   describe '#delete_card' do
     before do
-      stub_request(:get, /#{api_endpoint}/)
+      stub_request(:delete, /#{api_endpoint}/)
         .to_return(status: 200, body: "{}", headers: { 'Content-Type'=>'application/json' })
     end
 
     it "returns an object" do
-      expect(client.delete_card(card_id: card_id)).to be_a(Hash)
+      expect(client.delete_card(login_id: login_id)).to be_a(Hash)
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: flinks
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.2
 platform: ruby
 authors:
 - Philippe Dionne