flexirest 1.7.5 → 1.7.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: cc25c4790b42d7d6c5f17f1bccf38af464ae9acc
-  data.tar.gz: 851bdde04eb58f1e9b38753fd8c6ad72324c92d8
+SHA256:
+  metadata.gz: 1d623cd3e54c69cc619786ce8c462434491ef7b3985d4323e22401d861c7e2ed
+  data.tar.gz: 65d440f279dbe3bb452d9f7dcbdc5eee171dc3a62ee3fa0973256041b37d0841
 SHA512:
-  metadata.gz: '0179fd825262037792935e82e26c86d262c4d3675410850fc05aeefb37b72e8d620b60e6e245487825e50aa69cae40e4e2e13020b40704b856fb61e025dbaeec'
-  data.tar.gz: 79aa3524f59de9ff2932d2ee07c69170bb281031ba393551fe6dbe63f3ae5583dff88c93e6ecce0a4e7110afbb1750808bbe78fec9efe625667c702559699da4
+  metadata.gz: cd94c74ad17f1fad4a39f2888934d98add27fc7bcb79ebdcbdb14872e167d1fa90c9a76274da8d5ea771fa4e4e62711daeded34494ac12ab60068faa643e3ad4
+  data.tar.gz: 750b9fa6f4d5c86d56d465f11d8b9d653667e4c0bd1ba189b9f2bd3eab3e77534bb348d8e2c6ebc6a47c9e70117b25f86d30718487c592adb873c5d25d91526e

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 1.7.6
+
+Feature:
+
+- Changed `Flexirest::HTTPException#message` and `#to_s` for a better description of the error than just the class name.
+
 ## 1.7.5
 
 Feature:

data/lib/flexirest/request.rb

@@ -817,7 +817,11 @@ module Flexirest
 
     def message
       method = @method.try(:upcase)
-      "Sending #{method} to '#{@request_url}' returned a #{@status} with the body of - #{@raw_response}"
+      "The #{method} to '#{@request_url}' returned a #{@status} status, which raised a #{self.class.to_s} with a body of: #{@raw_response}"
+    end
+
+    def to_s
+      message
     end
   end
   class HTTPClientException < HTTPException ; end

data/lib/flexirest/version.rb

@@ -1,3 +1,3 @@
 module Flexirest
-  VERSION = "1.7.5"
+  VERSION = "1.7.6"
 end

data/spec/lib/request_spec.rb

@@ -249,6 +249,13 @@ describe Flexirest::Request do
     ExampleClient.all debug:true
   end
 
+  it "should correctly serialise array parameters" do
+    # name: ["john", "bill"] should become name[]=john&name[]=bill (but URL-safe so %5B%5D)
+    expect_any_instance_of(Flexirest::Connection).to receive(:get).with("/?name%5B%5D=john&name%5B%5D=bill", an_instance_of(Hash)).
+      and_return(::FaradayResponseMock.new(OpenStruct.new(body:'{"result":true}', response_headers:{})))
+    ExampleClient.all name: ["john", "bill"]
+  end
+
   it "should pass through get parameters, using defaults specified" do
     expect_any_instance_of(Flexirest::Connection).to receive(:get).with("/defaults?overwrite=yes&persist=yes", an_instance_of(Hash)).and_return(::FaradayResponseMock.new(OpenStruct.new(body:'{"result":true}', response_headers:{})))
     ExampleClient.defaults overwrite:"yes"
@@ -753,6 +760,7 @@ describe Flexirest::Request do
     rescue Flexirest::HTTPClientException => e
       e
     end
+    expect(e.to_s).to eq("The POST to '/create' returned a 409 status, which raised a Flexirest::HTTPConflictClientException with a body of: {\"first_name\":\"John\", \"id\":1234}")
     expect(e).to be_a(Flexirest::HTTPClientException)
     expect(e).to be_instance_of(Flexirest::HTTPConflictClientException)
     expect(e.status).to eq(409)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flexirest
 version: !ruby/object:Gem::Version
-  version: 1.7.5
+  version: 1.7.6
 platform: ruby
 authors:
 - Andy Jeffries
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-03 00:00:00.000000000 Z
+date: 2019-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -347,8 +347,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: This gem is for accessing REST services in a flexible way.  ActiveResource