flexirest 1.3.26 → 1.3.27

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7e5d860a92f3a3ce66635458548eeffa50fa9bde
-  data.tar.gz: 1992115ebc006ee19ad9650e61641ca01ed60a47
+  metadata.gz: 41037b044f911e96fa8ef57aaacae1c8ab7b4c46
+  data.tar.gz: fa0e305dfa953cab72072df58e10d8fbad96bef9
 SHA512:
-  metadata.gz: f3d01faf990a544d09f734d123842a456c2dfdad898549a88b4555f2042b82d24962fc155a26ef24a952e946d4e09731a36625fd2fd9c1f175b8f5cea8920bd1
-  data.tar.gz: 76382e77ae23a93feddb2317ecb9b515a9e65e7cfb05cf43dfa8ac0b35b4856c840f527c068fc12937ba914f76c4cbb6dcbea6e8c78bbfb4a10607df3d384d14
+  metadata.gz: aea60eaa4a88d43f48c87d3e7753660f7042b1cfc7ddc682454c21c9bbab28db9fcb29839a703409326166f9e02bc80479900d791b47aec0c782829e1bd440e5
+  data.tar.gz: c7f4e0e891019152782e07fc3546bccdab28a401ccb40e3b37d922d89cfe65ff2980260e5f03595273271caf13f1f40ebc501d3359c910145cec19618c742eaf

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 1.3.27
+
+Bugfix:
+
+- HTTP GET requests shouldn't send any body, JSON-encoded or otherwise
+
 ## 1.3.26
 
 Bugfix:

data/flexirest.gemspec

@@ -46,5 +46,6 @@ Gem::Specification.new do |spec|
   if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.0.0')
     spec.add_runtime_dependency "json", "< 2.0.0"
     spec.add_runtime_dependency "tins", "~> 1.6.0"
+    spec.add_runtime_dependency "term-ansicolor", "~> 1.3.2"
   end
 end

data/lib/flexirest/request.rb

@@ -287,7 +287,9 @@ module Flexirest
     end
 
     def prepare_request_body(params = nil)
-      if request_body_type == :form_encoded
+      if http_method == :get
+        @body = ""
+      elsif request_body_type == :form_encoded
         @body ||= (params || @post_params || {}).to_query
         headers["Content-Type"] ||= "application/x-www-form-urlencoded"
       elsif request_body_type == :json

data/lib/flexirest/version.rb

@@ -1,3 +1,3 @@
 module Flexirest
-  VERSION = "1.3.26"
+  VERSION = "1.3.27"
 end

data/spec/lib/request_spec.rb

@@ -238,6 +238,12 @@ describe Flexirest::Request do
     ExampleClient.update id:1234, debug:true, test:'foo'
   end
 
+  it "should not pass through an encoded empty body parameter" do
+    expect_any_instance_of(Flexirest::Connection).to receive(:get).with("/1234", an_instance_of(Hash)).and_return(::FaradayResponseMock.new(OpenStruct.new(body:"{\"result\":true}", response_headers:{})))
+    ExampleClient.request_body_type :json
+    ExampleClient.find id:1234
+  end
+
   it "allows forcing a request_body_type per request" do
     expect_any_instance_of(Flexirest::Connection).to receive(:post).with("/encoding", %q({"id":1234,"test":"something"}), an_instance_of(Hash)).and_return(::FaradayResponseMock.new(OpenStruct.new(body:"{\"result\":true}", response_headers:{})))
     ExampleClient.request_body_type :form_encoded # Should be ignored and the per_method :json used

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flexirest
 version: !ruby/object:Gem::Version
-  version: 1.3.26
+  version: 1.3.27
 platform: ruby
 authors:
 - Andy Jeffries
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-02 00:00:00.000000000 Z
+date: 2016-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler