flexirest 1.3.1 → 1.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bd8c9e532875def5d80496e08867b0f12579dc1d
-  data.tar.gz: f4e81c7652797f5fc3dac4c02870691b2b356583
+  metadata.gz: fc944642eeec80748c437111eb7e7b5b5ee98d40
+  data.tar.gz: f931c97b2a77159732a14e78e69f125ef006cd69
 SHA512:
-  metadata.gz: 80628e8db4f74a856ba72a017d74f2bbd0225fe4bc5088f06b20e8a7e9b4d6a18f8132ff3adb43b14c2d7fc1e08571c3a3e9a3dc78a0ae3208146eaeb2f4fb19
-  data.tar.gz: 5599b5a95be27c4c391a7cd60654cc0329d32e1f1faad43696b24c4baef0762ec2d907cd945250d74bdedaf50273c2919166e631277754b40986094051420cdc
+  metadata.gz: 72e1f0677d501933a37699452787dc2f7a43ee7919c94e362b6daf6f7eb1b5fd0fe65c5c7cd8254d90a1c9c2027ddbd4fa26151205f2976de7074421e7b9d1b4
+  data.tar.gz: 86f2aa14d43f8d16a3bdc69824e443eedb30ee6e645c402898d0dab9e0d41514f0ac26ae30acabecc90d599507fb9f19f85db0b2681d9be90b4fee3f5c300964

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 1.3.2
+
+Features:
+
+- Allow setting the body for a delete request - whether this is within HTTP spec is dubious, but a few APIs require it (thanks to Jeffrey Gu)
+
 ## 1.3.1
 
 Features:

data/lib/flexirest/connection.rb

@@ -81,12 +81,13 @@ module Flexirest
       end
     end
 
-    def delete(path, options={})
+    def delete(path, data, options={})
       set_defaults(options)
       make_safe_request(path) do
         @session.delete(path) do |req|
           set_per_request_timeout(req, options) if options[:timeout]
           req.headers = req.headers.merge(options[:headers])
+          req.body = data
           sign_request(req, options[:api_auth])
         end
       end

data/lib/flexirest/request.rb

@@ -350,7 +350,7 @@ module Flexirest
       when :patch
         response = connection.patch(@url, @body, request_options)
       when :delete
-        response = connection.delete(@url, request_options)
+        response = connection.delete(@url, @body, request_options)
       else
         raise InvalidRequestException.new("Invalid method #{http_method}")
       end

data/lib/flexirest/version.rb

@@ -1,3 +1,3 @@
 module Flexirest
-  VERSION = "1.3.1"
+  VERSION = "1.3.2"
 end

data/spec/lib/connection_spec.rb

@@ -45,8 +45,8 @@ describe Flexirest::Connection do
   end
 
   it "should pass a DELETE request through to Faraday" do
-    stub_request(:delete, "www.example.com/foo").to_return(body: "{result:true}")
-    result = @connection.delete("/foo")
+    stub_request(:delete, "www.example.com/foo").with(body: "body").to_return(body: "{result:true}")
+    result = @connection.delete("/foo", "body")
     expect(result.body).to eq("{result:true}")
   end
 
@@ -102,7 +102,7 @@ describe Flexirest::Connection do
         with(:headers => @default_headers).
         to_return(body: "{result:true}")
 
-      result = @connection.delete("/foo")
+      result = @connection.delete("/foo", "body")
       expect(result.body).to eq("{result:true}")
     end
   end

data/spec/lib/proxy_spec.rb

@@ -113,7 +113,7 @@ describe Flexirest::Base do
   end
 
   it "handles DELETE requests" do
-    expect_any_instance_of(Flexirest::Connection).to receive(:delete).with("/remove", instance_of(Hash)).and_return(::FaradayResponseMock.new(OpenStruct.new(body:"{\"result\":true}", status:200, response_headers:{})))
+    expect_any_instance_of(Flexirest::Connection).to receive(:delete).with("/remove", "", instance_of(Hash)).and_return(::FaradayResponseMock.new(OpenStruct.new(body:"{\"result\":true}", status:200, response_headers:{})))
     ProxyClientExample.remove
   end
 

data/spec/lib/request_spec.rb

@@ -104,7 +104,7 @@ describe Flexirest::Request do
   end
 
   it "should get an HTTP connection when called and call delete on it" do
-    expect_any_instance_of(Flexirest::Connection).to receive(:delete).with("/remove/1", an_instance_of(Hash)).and_return(::FaradayResponseMock.new(OpenStruct.new(body:'{"result":true}', response_headers:{})))
+    expect_any_instance_of(Flexirest::Connection).to receive(:delete).with("/remove/1", "", an_instance_of(Hash)).and_return(::FaradayResponseMock.new(OpenStruct.new(body:'{"result":true}', response_headers:{})))
     ExampleClient.remove(id:1)
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flexirest
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.3.2
 platform: ruby
 authors:
 - Andy Jeffries
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-24 00:00:00.000000000 Z
+date: 2016-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler