flexirest 1.3.10 → 1.3.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5e651c2b737f396357909fdc4aaab2d28997ee1f
-  data.tar.gz: e38300b96dcace5b1da4f5d81c7d523f3304e6e7
+  metadata.gz: 6ccb5f8a0bd924da53a93a997101f645c495581b
+  data.tar.gz: b5de1887d8f72fd6748e564a1dc35442f8a1469b
 SHA512:
-  metadata.gz: a358ba93a1e908eac336bed2c07697d77b7e1a780da1b1059d5c7c7de4caa9e50dd9a7f40f19ed1f835f927d3208029dd70cc87c75b73657c45f9d2e4620f8c0
-  data.tar.gz: a616506f250aa49f5e517542b170a338d24ec10683c0db9e1be9081ac87ee8cf586c4355b291e7fa9b0af501fa9a3cada17c695a6095534d5b2d1e95ba7dff8a
+  metadata.gz: 78a7b8f44082d9368f8826bdfcf5441b354c6bcaddbd7b71cdd2a96439e68aaa0d3eba53a6fc15c64d0d02c02929c8f33241b2b7521a9fd5089e552fa3f3e440
+  data.tar.gz: bea87e9a033c49a21fac8a8b64aee4fc612a3b6aff5f8c94ab70aa2d2844fa4a9a1ce1b3655c69e151e4aeae2c504d4777b1cbbbad3c9ae9aafd092b3a8c6fa4

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## 1.3.12
+
+Bugfix:
+
+- The Travis build was breaking because Guard pulls in Listen, which only runs on Ruby 2.2 and above. So I removed Guard so the gem can be tested to work against older Ruby versions still.
+
+## 1.3.11
+
+Feature:
+
+- Made the `Flexirest::*Exception#message` much nicer to help debugging applications, e.g. `Sending PUT to '/enable' returned a 500 with the body of - {"error":"John doesn't exist", "code":1234}`.
+
 ## 1.3.10
 
 Feature:

data/flexirest.gemspec

@@ -26,8 +26,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec_junit_formatter"
   spec.add_development_dependency "simplecov"
   spec.add_development_dependency "simplecov-rcov"
-  spec.add_development_dependency "guard-rspec"
-  spec.add_development_dependency 'terminal-notifier-guard'
   spec.add_development_dependency 'coveralls'
   spec.add_development_dependency "api-auth", ">= 1.3.1"
   spec.add_development_dependency 'typhoeus'

data/lib/flexirest/request.rb

@@ -407,17 +407,17 @@ module Flexirest
           error_response = @response.body
         end
         if status == 400
-          raise HTTPBadRequestClientException.new(status:status, result:error_response, url:@url)
+          raise HTTPBadRequestClientException.new(status:status, result:error_response, raw_response: @response.body, url:@url, method: http_method)
         elsif status == 401
-          raise HTTPUnauthorisedClientException.new(status:status, result:error_response, url:@url)
+          raise HTTPUnauthorisedClientException.new(status:status, result:error_response, raw_response: @response.body, url:@url, method: http_method)
         elsif status == 403
-          raise HTTPForbiddenClientException.new(status:status, result:error_response, url:@url)
+          raise HTTPForbiddenClientException.new(status:status, result:error_response, raw_response: @response.body, url:@url, method: http_method)
         elsif status == 404
-          raise HTTPNotFoundClientException.new(status:status, result:error_response, url:@url)
+          raise HTTPNotFoundClientException.new(status:status, result:error_response, raw_response: @response.body, url:@url, method: http_method)
         elsif (400..499).include? status
-          raise HTTPClientException.new(status:status, result:error_response, url:@url)
+          raise HTTPClientException.new(status:status, result:error_response, raw_response: @response.body, url:@url, method: http_method)
         elsif (500..599).include? status
-          raise HTTPServerException.new(status:status, result:error_response, url:@url)
+          raise HTTPServerException.new(status:status, result:error_response, raw_response: @response.body, url:@url, method: http_method)
         elsif status == 0
           raise TimeoutException.new("Timed out getting #{response.url}")
         end
@@ -603,6 +603,12 @@ module Flexirest
       @status = options[:status]
       @result = options[:result]
       @request_url = options[:url]
+      @raw_response = options[:raw_response]
+      @method = options[:method]
+    end
+
+    def message
+      "Sending #{@method.upcase} to '#{@request_url}' returned a #{@status} with the body of - #{@raw_response}"
     end
   end
   class HTTPClientException < HTTPException ; end

data/lib/flexirest/version.rb

@@ -1,3 +1,3 @@
 module Flexirest
-  VERSION = "1.3.10"
+  VERSION = "1.3.12"
 end

data/spec/lib/request_spec.rb

@@ -494,6 +494,20 @@ describe Flexirest::Request do
     expect(e.result.first_name).to eq("John")
   end
 
+  it "should return a useful message for errors" do
+    expect_any_instance_of(Flexirest::Connection).
+      to receive(:post).
+      with("/create", "first_name=John&should_disappear=true", an_instance_of(Hash)).
+      and_return(::FaradayResponseMock.new(OpenStruct.new(body:"{\"first_name\":\"John\", \"id\":1234}", response_headers:{}, status:500)))
+    object = ExampleClient.new(first_name:"John", should_disappear:true)
+    begin
+      object.create
+    rescue Flexirest::HTTPServerException => e
+      e
+    end
+    expect(e.message).to eq(%q{Sending POST to '/create' returned a 500 with the body of - {"first_name":"John", "id":1234}})
+  end
+
   it "should raise a parse exception for invalid JSON returns" do
     error_content = "<h1>500 Server Error</h1>"
     expect_any_instance_of(Flexirest::Connection).

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flexirest
 version: !ruby/object:Gem::Version
-  version: 1.3.10
+  version: 1.3.12
 platform: ruby
 authors:
 - Andy Jeffries
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-19 00:00:00.000000000 Z
+date: 2016-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -108,34 +108,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: guard-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: terminal-notifier-guard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
@@ -248,7 +220,6 @@ files:
 - CHANGELOG.md
 - CONTRIBUTING.md
 - Gemfile
-- Guardfile
 - LICENSE.txt
 - Migrating-from-ActiveRestClient.md
 - README.md

data/Guardfile

@@ -1,9 +0,0 @@
-# A sample Guardfile
-# More info at https://github.com/guard/guard#readme
-
-guard :rspec, cmd: 'bundle exec rspec' do
-  watch(%r{^spec/.*/*_spec\.rb$})  { "spec" }
-  watch(%r{^lib/.*/(.+)\.rb$})  { "spec" }
-  watch('spec/spec_helper.rb')  { "spec" }
-end
-