flexirest 1.3.9 → 1.3.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8a9faf13ef3eccc8b4e00f771eac639c048eebac
-  data.tar.gz: 97436ce0b23e2edf6c56c88cf32f3bea86f86d3d
+  metadata.gz: 5e651c2b737f396357909fdc4aaab2d28997ee1f
+  data.tar.gz: e38300b96dcace5b1da4f5d81c7d523f3304e6e7
 SHA512:
-  metadata.gz: 01e5b88653f5b6f0c943dd0c742dd1320b27371b244bda060ad7af86cf5ec0df8f41ce9a2a42137a7849e4460af72f3c85bf379eb923592003d061c964319b30
-  data.tar.gz: cd4c7b5d05801455c9956d0edd64134471525f8900d594b0d0b9b99b1042059f2db7009f7b56d85d5b14f7ef65708be42b2c10118c5dba86b8d13fefbc01406b
+  metadata.gz: a358ba93a1e908eac336bed2c07697d77b7e1a780da1b1059d5c7c7de4caa9e50dd9a7f40f19ed1f835f927d3208029dd70cc87c75b73657c45f9d2e4620f8c0
+  data.tar.gz: a616506f250aa49f5e517542b170a338d24ec10683c0db9e1be9081ac87ee8cf586c4355b291e7fa9b0af501fa9a3cada17c695a6095534d5b2d1e95ba7dff8a

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 1.3.10
+
+Feature:
+
+- Added per-request params encoding so you can choose between `param[]=foo&param[]=bar` or `param=foo&param=bar` (thanks to bkubic for the PR).
+
 ## 1.3.9
 
 Feature:

data/README.md

@@ -617,6 +617,33 @@ class Person < Flexirest::Base
 end
 ```
 
+### Per-request Params Encoding
+
+When url-encoding get parameters, Rudy adds brackets([]) by default to any parameters in an Array. For example, if you tried to pass these parameters:
+
+```ruby
+Person.all(param: [1, 2, 3])
+```
+
+Ruby would encode the url as 
+
+```
+?param[]=1&param[]=2&param[]=3
+```
+
+If you prefer flattened notation instead, pass a `params_encoder` option of `:flat` when mapping the call. So this call:
+
+```ruby
+class Person < Flexirest::Base
+  get :all, '/people', params_encoder: :flat
+end
+```
+would output the following url
+
+```
+?param=1&param=2&param=3
+```
+
 ### Raw Requests
 
 Sometimes you have have a URL that you just want to force through, but have the response handled in the same way as normal objects or you want to have the filters run (say for authentication).  The easiest way to do that is to call `_request` on the class:

data/lib/flexirest/request.rb

@@ -266,7 +266,11 @@ module Flexirest
 
     def append_get_parameters
       if @get_params.any?
-        @url += "?" + @get_params.to_query
+        if @method[:options][:params_encoder] == :flat
+          @url += "?" + URI.encode_www_form(@get_params)
+        else
+          @url += "?" + @get_params.to_query
+        end
       end
     end
 

data/lib/flexirest/version.rb

@@ -1,3 +1,3 @@
 module Flexirest
-  VERSION = "1.3.9"
+  VERSION = "1.3.10"
 end

data/spec/lib/request_spec.rb

@@ -22,6 +22,7 @@ describe Flexirest::Request do
       end
 
       get :all, "/", :has_many => {:expenses => ExampleOtherClient}
+      get :flat, "/", :params_encoder => :flat
       get :array, "/johnny", array: [:likes, :dislikes]
       get :babies, "/babies", :has_many => {:children => ExampleOtherClient}
       get :single_association, "/single", :has_one => {:single => ExampleSingleClient}, :has_many => {:children => ExampleOtherClient}
@@ -188,6 +189,11 @@ describe Flexirest::Request do
     ExampleClient.all :include => [:your,:friends]
   end
 
+  it "should pass through 'array type' get parameters using the same parameter name if a flat param_encoder is chosen" do
+    expect_any_instance_of(Flexirest::Connection).to receive(:get).with("/?include=your&include=friends", an_instance_of(Hash)).and_return(::FaradayResponseMock.new(OpenStruct.new(body:"{\"result\":true}", response_headers:{})))
+    ExampleClient.flat :include => [:your,:friends]
+  end
+
   it "should encode the body in a form-encoded format by default" do
     expect_any_instance_of(Flexirest::Connection).to receive(:put).with("/put/1234", "debug=true&test=foo", an_instance_of(Hash)).and_return(::FaradayResponseMock.new(OpenStruct.new(body:"{\"result\":true}", response_headers:{})))
     ExampleClient.update id:1234, debug:true, test:'foo'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flexirest
 version: !ruby/object:Gem::Version
-  version: 1.3.9
+  version: 1.3.10
 platform: ruby
 authors:
 - Andy Jeffries
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-08 00:00:00.000000000 Z
+date: 2016-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler