flexirecord 0.0.5 → 0.0.6

data/CHANGELOG

@@ -32,5 +32,12 @@
   - >
     Fixed a bug in the FlexiRecord::ListRecord module.
   - >
-    'src_to_dst_attr' and 'dst_to_src_attr' arguments of FlexiRecord::Reference.new are now allowed to be nil.
+    'src_to_dst_attr' and 'dst_to_src_attr' arguments of
+    FlexiRecord::Reference.new are now allowed to be nil.
+
+- Release of version 0.0.5.
+
+- 2007-02-16:
+  - >
+    SELECT DISTINCT has been replaced by SELECT (ALL).
 

data/lib/flexirecord.rb

@@ -358,7 +358,6 @@ module FlexiRecord
             end
             sql_snippet = sql_snippet.to_str
           end
-          # TODO: Do SELECT DISTINCT perhaps? (breaks for now, as ORDER BY expressions must appear in select list)
           destination_records = unless source_records.empty?
             destination_class.sql(
               'SELECT ' << FlexiRecord::DefaultTableAlias << '.* FROM (' <<
@@ -498,7 +497,7 @@ module FlexiRecord
       return @flexirecord_preloaded[cache_key] = loader.call(self, arguments)
     end
 
-    # Returns a RecordArray of re-selected objects. This can be used to re-sort records by the database, to do further filtering, or to reload all records at once. The result will not contain duplicates, even if there are duplicates in the receiver of the method call.
+    # Returns a RecordArray of re-selected objects. This can be used to re-sort records by the database, to do further filtering, or to reload all records at once.
     def reselect(sql_snippet=nil, *arguments)
       unless self.empty?
         @flexirecord_class.select_by_value_set(@flexirecord_class.primary_columns, self.collect { |record| @flexirecord_class.primary_columns.collect { |column| record.read(column) } }, sql_snippet, *arguments)
@@ -732,9 +731,9 @@ module FlexiRecord
         end
       end
 
-      # Wrapper for the 'sql' method including already a part of the SQL select command. Please see the source code to understand how this method works. If there is a primary key, the selection will not contain duplicates, even if there have been JOINs with other tables.
+      # Wrapper for the 'sql' method including already a part of the SQL select command. Please see the source code to understand how this method works.
       def select(sql_snippet=nil, *arguments)
-        sql("SELECT#{(sql_snippet.nil? or self.primary_columns.empty?) ? '' : ' DISTINCT'} #{FlexiRecord::DefaultTableAlias}.* FROM #{table} #{FlexiRecord::DefaultTableAlias}#{sql_snippet ? ' ' : ''}#{sql_snippet}", *arguments)
+        sql("SELECT #{FlexiRecord::DefaultTableAlias}.* FROM #{table} #{FlexiRecord::DefaultTableAlias}#{sql_snippet ? ' ' : ''}#{sql_snippet}", *arguments)
       end
 
       # Same as 'select', but returns only the first member of the Array, or nil.
@@ -742,7 +741,7 @@ module FlexiRecord
         select(*arguments).first
       end
 
-      # Executes an SQL query, selecting rows matching a given set of keys and values, optionally appending a given SQL snippet with parameters. Returns an Array of records. If there is a primary key, the selection will not contain duplicates, even if there have been JOINs with other tables.
+      # Executes an SQL query, selecting rows matching a given set of keys and values, optionally appending a given SQL snippet with parameters. Returns an Array of records.
       def select_by_value_set(keys, set_of_values, sql_snippet=nil, *arguments)
         flattened_values = set_of_values.to_ary.flatten
         if flattened_values.empty?
@@ -750,14 +749,14 @@ module FlexiRecord
         else
           if sql_snippet
             return sql(
-              'SELECT ' << (self.primary_columns.empty? ? '' : 'DISTINCT ') << FlexiRecord::DefaultTableAlias << '.* FROM (' <<
+              'SELECT ' << FlexiRecord::DefaultTableAlias << '.* FROM (' <<
               'SELECT * FROM ' << table << ' WHERE (' << keys.collect { |key| '"' << key << '"' }.join(', ') << ') ' << 'IN (' << set_of_values.collect { |values| '(' << values.collect { |value| '$' }.join(', ') << ')' }.join(', ') << ')' <<
               ') AS ' << FlexiRecord::DefaultTableAlias << ' ' << sql_snippet.to_s,
               *(flattened_values + arguments)
             )
           else
             return sql(
-              'SELECT' << (self.primary_columns.empty? ? '' : ' DISTINCT') << ' * FROM ' << table << ' WHERE (' << keys.collect { |key| '"' << key << '"' }.join(', ') << ') ' << 'IN (' << set_of_values.collect { |values| '(' << values.collect { |value| '$' }.join(', ') << ')' }.join(', ') << ')',
+              'SELECT * FROM ' << table << ' WHERE (' << keys.collect { |key| '"' << key << '"' }.join(', ') << ') ' << 'IN (' << set_of_values.collect { |values| '(' << values.collect { |value| '$' }.join(', ') << ')' }.join(', ') << ')',
               *(flattened_values + arguments)
             )
           end
@@ -884,7 +883,7 @@ module FlexiRecord
         nil
       end
 
-      # Helper mthod for dup and replace. Do not use directly.
+      # Helper method for dup and replace. Do not use directly.
       def read_internal_state
         return @data_hash.dup, @saved, @old_primary_key.dup
       end
@@ -1121,6 +1120,7 @@ module FlexiRecord
         end
       end
 
+      # TODO: write documentation
       def destroy
         if self.saved?
           self.class.db_execute('DELETE FROM ' << self.class.table <<
@@ -1434,7 +1434,7 @@ module FlexiRecord
       end
     end
 
-    # Closes a transaction, which can't not be used anymore.
+    # TODO: write documentation
     def close
       @backend_connection.close
       @backend_connection = nil

metadata

@@ -3,8 +3,8 @@ rubygems_version: 0.9.0
 specification_version: 1
 name: flexirecord
 version: !ruby/object:Gem::Version 
-  version: 0.0.5
-date: 2007-02-13 00:00:00 +00:00
+  version: 0.0.6
+date: 2007-02-16 00:00:00 +00:00
 summary: Object-Oriented Database Access Library
 require_paths: 
 - lib/