flexible_enum 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 261435611285df8117f8eb4507968098af93009c
-  data.tar.gz: b1cfddfb7d6e0829f8864ff2794619a2bb58bf59
+  metadata.gz: 94d3ef232899f6e7411f802a9f61afbb1b00e510
+  data.tar.gz: 9c833016c20aa62ede9032c45a81b370ad39c78c
 SHA512:
-  metadata.gz: 8768a09ca2910c8d36ebb3eb155702158ed6f74cce6d8f9b4e0a02a0d0248c648839c06c4fa4ee3ab39d74ce0b1eead390459c7701b882ac5dfcac8041417419
-  data.tar.gz: b30f0f5dbbe17899be3e5b2beb7602d11fc310bc25c1a6dfed034357a5433d37ef1bf8688941ff8da7297559f80c697f40daca53ed66c4bf13cb2a86ab394607
+  metadata.gz: 89a11ef2c046e548ce26ecfb752c2f7ed3c6df57b75136d39709ce4b0d7c4c50338d4d26d117011b92b5fc1e4f560f303ea949a887671156e179ae71a27c2267
+  data.tar.gz: faf22cccc8b2e56ef86e15eb1932abf2af07f738f59cd6079dd73891fa6ef878ae36910b886691944eaa9bc4773a2bd94247e0ebaf6435ad839e5e9ac382f3ef

data/CHANGELOG.md

@@ -1,7 +1,12 @@
 Current release (in development)
 --------------------------------
 
-* ...
+0.4.2
+-----
+
+*   Enum setter methods raise exceptions in accordance with Rails conventions for bang (`!`) methods. #27
+
+    *Adam Prescott*
 
 0.4.1
 -----
@@ -9,6 +14,7 @@ Current release (in development)
 *   Add support for Rails 5. #33
 
     *Alex Robbin*
+
 *   Add inverse scopes. #32
 
     *Zach Fletcher*

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2013–2015 MeYou Health
+Copyright (c) 2013–2016 MYH, Inc.
 
 MIT License
 

data/README.md

@@ -355,4 +355,4 @@ Please see [CONTRIBUTING.md](https://github.com/meyouhealth/flexible_enum/blob/m
 
 ![http://meyouhealth.com/](https://avatars3.githubusercontent.com/u/249181?v=3&s=200)
 
-FlexibleEnum is maintained by MeYou Health, LLC.
+FlexibleEnum is maintained by MYH, Inc.

data/lib/flexible_enum/setter_method_configurator.rb

@@ -12,7 +12,7 @@ module FlexibleEnum
           time = Time.now.utc
           attributes["#{timestamp_attribute_name}_on".to_sym] = time.to_date if self.class.attribute_method?("#{timestamp_attribute_name}_on")
           attributes["#{timestamp_attribute_name}_at".to_sym] = time if self.class.attribute_method?("#{timestamp_attribute_name}_at")
-          update_attributes(attributes)
+          update_attributes!(attributes)
         end
       end
     end

data/lib/flexible_enum/version.rb

@@ -1,3 +1,3 @@
 module FlexibleEnum
-  VERSION = "0.4.1"
+  VERSION = "0.4.2"
 end

data/spec/setter_methods_spec.rb

@@ -3,6 +3,8 @@ require 'spec_helper'
 describe "setter methods" do
   subject(:register) { CashRegister.new }
 
+  before { register.save! }
+
   it "adds default bang methods for setting a new value" do
     expect(register.status).to be_nil
     register.active!
@@ -20,29 +22,57 @@ describe "setter methods" do
   end
 
   describe "updating database" do
-    let!(:now) { Time.now }
+    let!(:now) { Time.at(Time.now.to_i) }
     let(:updates) { [] }
 
     before { allow(Time).to receive(:now).and_return(now) }
 
-    it "immediately dispatches a validation-free update" do
+    it "performs an update on the relevant attribute" do
       register.active!
       register.close!
 
+      register.reload
+
       expect(register).to be_active
       expect(register).to be_closed
     end
 
     it "updates default timestamp columns with the current date and time" do
       register.fill!
+
+      register.reload
+
       expect(register).to be_full
       expect(register.full_at).to eq(now)
     end
 
     it "updates custom timestamp columns with the current date and time" do
       register.empty!
+
+      register.reload
+
       expect(register).to be_empty
       expect(register.emptied_at).to eq(now)
     end
+
+    context "when there are validation errors" do
+      before { register.include_validations = true }
+
+      specify { expect(register).to_not be_valid }
+
+      it "raises and does not persist any changes" do
+        expect { register.empty! }.to raise_error(ActiveRecord::RecordInvalid, "Validation failed: Required attribute can't be blank")
+        expect { register.close! }.to raise_error(ActiveRecord::RecordInvalid, "Validation failed: Required attribute can't be blank")
+
+        expect(register).to be_empty
+        expect(register).to be_closed
+
+        register.reload
+
+        expect(register).to_not be_empty
+        expect(register).to_not be_closed
+        expect(register.emptied_at).to be_nil
+      end
+    end
   end
 end

data/spec/spec_helper.rb

@@ -42,4 +42,8 @@ class CashRegister < ActiveRecord::Base
     honeywell "HON"
     sharp "SHCAY"
   end
+
+  attr_accessor :include_validations, :required_attribute
+
+  validates_presence_of :required_attribute, if: -> { include_validations }
 end

metadata

@@ -1,28 +1,30 @@
 --- !ruby/object:Gem::Specification
 name: flexible_enum
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - Matt Daubert
 - Alex Robbin
-- Matthew Daubert
 - Adam Prescott
+- Matthew Daubert
 - Alex Robbin
 - Sean Santry
 - Chad Dressler
 - Adam Prescott
-- Zach Fletcher
 - David Larrabee
 - Sean Santry
-- jon.zeppieri
+- Zach Fletcher
+- Alex Robbin
+- Bolek
 - David C. Goldhirsch
 - Guillermo Guerini
 - Matthew Daubert
+- jon.zeppieri
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-15 00:00:00.000000000 Z
+date: 2017-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -140,19 +142,21 @@ description: Helpers for enum-like fields
 email:
 - matt.daubert@meyouhealth.com
 - alex.robbin@meyouhealth.com
-- mdaubert@gmail.com
 - adam@aprescott.com
+- mdaubert@gmail.com
 - alex@robbinsweb.biz
 - sean.santry@meyouhealth.com
 - chad@dresslerfamily.com
 - adam.prescott@meyouhealth.com
-- zach.fletcher@meyouhealth.com
 - david.larrabee@meyouhealth.com
 - sean@seansantry.com
-- jon.zeppieri@meyouhealth.com
+- zach.fletcher@meyouhealth.com
+- agrobbin@users.noreply.github.com
+- bolek@meyouhealth.com
 - dgoldhirsch@yahoo.com
 - guillermo@gguerini.com
 - mdaubert+github@gmail.com
+- jon.zeppieri@meyouhealth.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -211,7 +215,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Helpers for enum-like fields