flavour_saver 4.0.2 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 80a0e1999365ccda78e958e0155d4dbd22144714aa0aaf313d3a989e91b4679f
-  data.tar.gz: ee60228f697c8e271e733b42edb51c4a6fa45dec5178f2df1e6cd097f46401fe
+  metadata.gz: 23a4ae44f910bb19202d1336927b028f8f1678c3474a46d5ada75eeb67295ff6
+  data.tar.gz: dcbedf38a360efeed2e7319c22eb60730578457354d0dd2872eafb76526d07aa
 SHA512:
-  metadata.gz: c743bbef88d41fb1953d56fda4ef393109263ca609899e119e0e9f4e80ee9481c12737c7678ff037edec6ddebd169b4dc8343683a3efc81ace61a716a0d4e7c0
-  data.tar.gz: 65fb2bc85b97ea6d1f833521350870a637ea9736af104f98c33973d97d5aaf078f950eac0152b636bb7164a0c3483a83e1fffcece6816a9f51c50e09aeeedf07
+  metadata.gz: 754890fa64a87d71f5c53ad8f471c52490268361bb0adb91ec53207cfd27de9738b723a4022477e522324442fbb671a0f5613fe0e5e46013afe5db05d9bd2571
+  data.tar.gz: ccb789b768c7406b1453cdf635dec3e8737b28b7e81bd6b7323baaacb13b76846367623a00b27d3157005e4df2522448af4c83c224e891ad91c61d66990a369e

data/.github/workflows/ci.yml

@@ -25,6 +25,20 @@ jobs:
     - name: Run tests
       run: bundle exec rspec
 
+  standard:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v6
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: '3.4'
+        bundler-cache: true
+    - name: Run Standard
+      run: bundle exec standardrb
+
   publish-gem:
     if: github.ref_type == 'tag'
     runs-on: ubuntu-latest

data/.standard.yml

@@ -0,0 +1 @@
+ruby_version: 3.1

data/CHANGELOG.md

@@ -7,6 +7,63 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## 5.0.0
+
+### Removed
+
+* The `rltk` dependency, and with it its transitive `ffi` native extension.
+  RLTK's last release was in 2015 and FlavourSaver pinned it below 3.0, so the
+  gem could never be updated in an application's bundle. The lexer, parser and
+  AST base class are now part of FlavourSaver itself; `tilt` is the only
+  runtime dependency. Parsing is about five times faster.
+
+### Added
+
+* `FlavourSaver::Error`, a common base class for the errors raised by an
+  invalid template: `FlavourSaver::Lexer::LexingError`,
+  `FlavourSaver::Parser::NotInLanguage` and
+  `FlavourSaver::Parser::UnbalancedBlockError`.
+
+### Changed
+
+* Syntax errors raise `FlavourSaver::Parser::NotInLanguage` instead of
+  `RLTK::NotInLanguage`, and unlexable input raises
+  `FlavourSaver::Lexer::LexingError` instead of `RLTK::LexingError`. The
+  `LexingError` message now quotes the first 50 characters of the input the
+  lexer couldn't match.
+
+  **Migrating:** a `rescue RLTK::NotInLanguage` or `rescue RLTK::LexingError`
+  now raises `NameError` when an exception reaches it, because Ruby only looks
+  up the constants in a `rescue` clause at that point. Replace them with
+  `rescue FlavourSaver::Error`, which also catches
+  `FlavourSaver::Parser::UnbalancedBlockError` (raised for a closing tag with
+  no matching opening, such as `{{#foo}}{{#bar}}{{/foo}}`).
+* `FlavourSaver::Lexer`, `FlavourSaver::Parser` and `FlavourSaver::Node` no
+  longer inherit from RLTK classes. Tokens respond to `type` and `value` but
+  no longer carry a `position`.
+* AST node fields are type-checked as they were under RLTK. Setting one to
+  the wrong type, whether in the constructor or with a setter, raises
+  `FlavourSaver::Node::TypeMismatch` instead of `RLTK::TypeMismatch`. Like
+  RLTK's, it is a `StandardError` and not a `FlavourSaver::Error`, so
+  `rescue FlavourSaver::Error` doesn't catch it. An application that rewrites
+  the AST before rendering gets the error where it builds the bad node, not at
+  render time.
+* RLTK's core-class monkey patches (`Object#returning`, `TrueClass#to_i`,
+  `FalseClass#to_i`, `Integer#to_bool`, `Class#subclass_of?` and friends) are
+  no longer loaded into applications that use FlavourSaver.
+
+### Fixed
+
+* An inverted section with an `{{else}}`, such as
+  `{{^items}}none{{else}}some{{/items}}`, raised `RLTK::TypeMismatch` at parse
+  time. It now renders the body when the value is falsy and the `{{else}}`
+  section when it is truthy.
+* A deeply nested template overflowed the stack and raised `SystemStackError`,
+  which `rescue FlavourSaver::Error` doesn't catch. Inside a Fiber, rendering
+  that happened at fewer than 100 levels. A template that nests blocks and
+  subexpressions more than 32 levels deep (`FlavourSaver::Parser::MAX_DEPTH`)
+  now raises `FlavourSaver::Parser::NotInLanguage`.
+
 ## 4.0.2
 
 * Bump locked dependency versions

data/Gemfile

@@ -1,4 +1,4 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in flavour_saver.gemspec
 gemspec

data/Gemfile.lock

@@ -1,8 +1,7 @@
 PATH
   remote: .
   specs:
-    flavour_saver (4.0.2)
-      rltk (< 3.0)
+    flavour_saver (5.0.0)
       tilt (~> 2.6)
 
 GEM
@@ -20,6 +19,7 @@ GEM
       minitest (>= 5.1, < 6)
       securerandom (>= 0.3)
       tzinfo (~> 2.0, >= 2.0.5)
+    ast (2.4.3)
     base64 (0.3.0)
     benchmark (0.5.0)
     bigdecimal (4.1.2)
@@ -27,14 +27,22 @@ GEM
     connection_pool (2.5.5)
     diff-lcs (1.6.2)
     drb (2.2.3)
-    ffi (1.17.4)
     i18n (1.15.2)
       concurrent-ruby (~> 1.0)
+    json (2.21.2)
+    language_server-protocol (3.17.0.6)
+    lint_roller (1.1.0)
     logger (1.7.0)
     minitest (5.27.0)
+    parallel (1.28.0)
+    parser (3.3.12.0)
+      ast (~> 2.4.1)
+      racc
+    prism (1.9.0)
+    racc (1.8.1)
+    rainbow (3.1.1)
     rake (13.4.2)
-    rltk (2.2.1)
-      ffi (>= 1.0.0)
+    regexp_parser (2.13.1)
     rspec (3.13.2)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
@@ -48,10 +56,44 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.7)
+    rubocop (1.88.2)
+      json (~> 2.3)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
+      parallel (>= 1.10)
+      parser (>= 3.3.0.2)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.49.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.50.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.7)
+    rubocop-performance (1.26.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.47.1, < 2.0)
+    ruby-progressbar (1.13.0)
     securerandom (0.4.1)
+    standard (1.56.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.88.0)
+      standard-custom (~> 1.0.0)
+      standard-performance (~> 1.8)
+    standard-custom (1.0.2)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.50)
+    standard-performance (1.9.0)
+      lint_roller (~> 1.1)
+      rubocop-performance (~> 1.26.0)
     tilt (2.8.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
+    unicode-display_width (3.3.0)
+      unicode-emoji (~> 4.3)
+    unicode-emoji (4.3.0)
 
 PLATFORMS
   ruby
@@ -61,6 +103,7 @@ DEPENDENCIES
   flavour_saver!
   rake
   rspec
+  standard
 
 BUNDLED WITH
    2.3.7