flagship 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3cc791479b0f25f7d381e01b9dd1a34b214f4d7e
-  data.tar.gz: f485f304352532299eb3757ca01bcb1d9978cfc1
+  metadata.gz: b5e0f2c9053b747cfc441a1e3ba8f31a5453d00d
+  data.tar.gz: ba52d5627d54d495773f47649bb8333a37793dbe
 SHA512:
-  metadata.gz: 42632f27ed80b517a0662dc2ac8df22566aa3ae41a1ec80bcf7630ca46abdd19d52b0ce3f9ed83112d7ccf7120b580e3cbeb49d7abc299ad94819d1b1d1d7e94
-  data.tar.gz: 2a28a9460e250b90d43837c56d56e0ec9189cc3dc0df5a6e3dfc6e20c0982d0c34a10af5bac4b7b61000736e8ce8cc9b74ce0a65d95b8e27cf4d054e079c37f0
+  metadata.gz: cb5353d961b9a00391af1e0e42028b9bc432772073743d0f4ebb291a91342a3f7aa99bd555b234fee50128bcd85ae9bd0daa44e8fb7ad86e3b502390f21c8c46
+  data.tar.gz: 8db9f8a90a544de056952bccc6ab0b88dd2189029b40d62c1320a40a0eb99f499a54e4a488a95879bada243f8e7532ea774a9920d85938b33c56c4895b284a56

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Change Log
 
+## [0.4.0] - 2016-12-23
+
+### Added
+
+- Added methods to filter `Flagship.features` [#16](https://github.com/yuya-takeyama/flagship/pull/16) [#19](https://github.com/yuya-takeyama/flagship/pull/19)
+- `enabled?` method in DSL [#17](https://github.com/yuya-takeyama/flagship/pull/17)
+- `Flagship.disabled?` method [#18](https://github.com/yuya-takeyama/flagship/pull/18)
+
 ## [0.3.0] - 2016-11-24
 
 ### Added

data/README.md

@@ -38,6 +38,10 @@ Flagship.select_flagset(:app)
 if Flagship.enabled?(:some_feature)
   # Implement the feature here
 end
+
+if Flagship.disabled?(:some_feature)
+  # Run when :some_feature is not enabled
+end
 ```
 
 ### Set context variables
@@ -93,7 +97,10 @@ Flagship.features
 # => Array of Flagship::Feature
 
 Flagship.features.map(&:key)
-# => Array key of enabled features
+# => Array key of all features
+
+Flagship.features.enabled.map(&:key)
+# => Array key of all enabled features
 ```
 
 ### Categorize features with tags
@@ -102,14 +109,16 @@ Flagship.features.map(&:key)
 Flagship.define :blog do
   enable :post
   enable :comment, communication: true
-  enable :trackback, communication: true
+  enable :trackback, communication: true, tracking: true
 end
 
 Flagship.select_flagset(:blog)
 
-# Fetch keys of enabled communication features
-Flagship.features.select{ |feature| feature.tags[:communication] && feature.enabled? }.map(&:key)
+Flagship.features.enabled.tagged(communication: true).map(&:key)
 # => [:comment, :trackback]
+
+Flagship.features.enabled.tagged(communication: true, tracking: true).map(&:key)
+# => [:trackback]
 ```
 
 ### `with_tags`
@@ -127,6 +136,17 @@ Flagship.define :blog do
 end
 ```
 
+## Feature flag composition
+
+You can call `#enabled?` method inside of DSL.
+
+```rb
+Flagship.define :blog do
+  enable :comment, if: ->(context) { context.current_user.activated? }
+  enable :comment_deletion, if: ->(context) { enabled?(:comment) && context.current_user.moderator? }
+end
+```
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. You can also run `bin/console` for an interactive prompt that will allow you to experiment.

data/lib/flagship/dsl.rb

@@ -1,6 +1,8 @@
 class Flagship::Dsl
   class InvalidOptionError < ::StandardError; end
 
+  attr_reader :flagset
+
   def initialize(key, context, base = nil, &block)
     @key = key
     @context = context
@@ -8,6 +10,10 @@ class Flagship::Dsl
     @features = {}
     @definition = block
     @base_tags = {}
+
+    instance_eval(&@definition)
+
+    @flagset = ::Flagship::Flagset.new(@key, @features, @base)
   end
 
   def enable(key, opts = {})
@@ -36,8 +42,11 @@ class Flagship::Dsl
     @base_tags = orig_base_tags
   end
 
-  def flagset
-    instance_eval(&@definition)
-    ::Flagship::Flagset.new(@key, @features, @base)
+  def enabled?(key)
+    @flagset.enabled?(key)
+  end
+
+  def disabled?(key)
+    @flagset.disabled?(key)
   end
 end

data/lib/flagship/feature.rb

@@ -27,6 +27,10 @@ class Flagship::Feature
     end
   end
 
+  def disabled?
+    !enabled?
+  end
+
   def extend_feature(feature)
     self.class.new(@key, @enabled, @context, feature.tags.merge(@tags))
   end

data/lib/flagship/features.rb

@@ -0,0 +1,19 @@
+class Flagship::Features < Array
+  def tagged_any(tags)
+    self.class.new(select{|feature| tags.any?{|tag, val| feature.tags[tag] == val}})
+  end
+
+  def tagged(tags)
+    self.class.new(select{|feature| tags.all?{|tag, val| feature.tags[tag] == val}})
+  end
+
+  alias tagged_all tagged
+
+  def enabled
+    self.class.new(select(&:enabled?))
+  end
+
+  def disabled
+    self.class.new(select(&:disabled?))
+  end
+end

data/lib/flagship/flagset.rb

@@ -17,8 +17,12 @@ class Flagship::Flagset
     @features[key].enabled?
   end
 
+  def disabled?(key)
+    !enabled?(key)
+  end
+
   def features
-    @features.map { |key, feature| feature }
+    Flagship::Features.new @features.map { |key, feature| feature }
   end
 
   private

data/lib/flagship/version.rb

@@ -1,3 +1,3 @@
 module Flagship
-  VERSION = "0.3.0"
+  VERSION = "0.4.0"
 end

data/lib/flagship.rb

@@ -2,6 +2,7 @@ require "flagship/version"
 require "flagship/context"
 require "flagship/dsl"
 require "flagship/feature"
+require "flagship/features"
 require "flagship/flagset"
 require "flagship/flagsets_container"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flagship
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Yuya Takeyama
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-11-23 00:00:00.000000000 Z
+date: 2016-12-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -74,6 +74,7 @@ files:
 - lib/flagship/context.rb
 - lib/flagship/dsl.rb
 - lib/flagship/feature.rb
+- lib/flagship/features.rb
 - lib/flagship/flagset.rb
 - lib/flagship/flagsets_container.rb
 - lib/flagship/version.rb
@@ -97,7 +98,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Ship/unship features using flags defined with declarative DSL