flac2mp3 0.2.3 → 0.2.4

data/History.txt

@@ -1,3 +1,8 @@
+== 0.2.4 2008-04-28
+
+* 1 bug fix:
+  * Numeric track descriptions were converted to integers, which caused setting the MP3 data (using ruby-mp3info) to raise an exception. They are now left as strings.
+
 == 0.2.3 2008-04-18
 
 * 1 bug fix:

data/lib/flac2mp3.rb

@@ -39,7 +39,7 @@ module Flac2mp3
       data.tags.inject({}) do |hash, (key, value)|
         key = key.to_s.downcase.to_sym
         value = value.to_i if value.respond_to?(:match) and value.match(/^\d+$/)
-        value = value.to_s if key == :title
+        value = value.to_s if string_fields.include?(key)
         hash[key] = value
         hash
       end
@@ -56,5 +56,11 @@ module Flac2mp3
         end
       end
     end
+    
+    private
+    
+    def string_fields
+      [:title, :description]
+    end
   end
 end

data/lib/flac2mp3/version.rb

@@ -2,7 +2,7 @@ module Flac2mp3 #:nodoc:
   module VERSION #:nodoc:
     MAJOR = 0
     MINOR = 2
-    TINY  = 3
+    TINY  = 4
 
     STRING = [MAJOR, MINOR, TINY].join('.')
   end

data/spec/flac2mp3_spec.rb

@@ -250,6 +250,20 @@ describe Flac2mp3, 'when getting FLAC tag data' do
     data = Flac2mp3.flacdata(@filename)
     data[:title].should == '45'
   end
+  
+  it 'should leave numeric descriptions as strings' do
+    @tags[:description] = '1938'  # This was my first run-in with this problem, from the Boilermakers' version of "Minor Swing" where for the description all I had was the year of the original
+    
+    data = Flac2mp3.flacdata(@filename)
+    data[:description].should == '1938'
+  end
+  
+  it 'should leave numeric titles as strings even if the title key is not a simple downcased symbol' do
+    @tags['DESCRIPTION'] = '1938'
+    
+    data = Flac2mp3.flacdata(@filename)
+    data[:description].should == '1938'
+  end
 end
 
 describe Flac2mp3, 'when setting MP3 tag data' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: flac2mp3
 version: !ruby/object:Gem::Version 
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors: 
 - Yossef Mendelssohn
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-04-18 00:00:00 -05:00
+date: 2008-04-28 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency