flac2mp3 0.2.0 → 0.2.1

data/History.txt

@@ -1,3 +1,8 @@
+== 0.2.1 2008-03-30
+
+* 1 bug fix:
+  * Numeric track titles were converted to integers, which caused setting the MP3 data (using ruby-mp3info) to raise an exception. They are now left as strings.
+
 == 0.2.0 2007-12-07
 
 * 1 major enhancement:

data/lib/flac2mp3.rb

@@ -37,8 +37,10 @@ module Flac2mp3
     def flacdata(filename)
       data = FlacInfo.new(filename)
       data.tags.inject({}) do |hash, (key, value)|
+        key = key.to_s.downcase.to_sym
         value = value.to_i if value.respond_to?(:match) and value.match(/^\d+$/)
-        hash[key.to_s.downcase.to_sym] = value
+        value = value.to_s if key == :title
+        hash[key] = value
         hash
       end
     end

data/lib/flac2mp3/version.rb

@@ -2,7 +2,7 @@ module Flac2mp3 #:nodoc:
   module VERSION #:nodoc:
     MAJOR = 0
     MINOR = 2
-    TINY  = 0
+    TINY  = 1
 
     STRING = [MAJOR, MINOR, TINY].join('.')
   end

data/spec/flac2mp3_spec.rb

@@ -236,6 +236,20 @@ describe Flac2mp3, 'when getting FLAC tag data' do
     data = Flac2mp3.flacdata(@filename)
     data[:track].should == 12
   end
+  
+  it 'should leave numeric titles as strings' do
+    @tags[:title] = '45'  # This was my first run-in with this problem, the opening track on Elvis Costello's /When I Was Cruel/
+    
+    data = Flac2mp3.flacdata(@filename)
+    data[:title].should == '45'
+  end
+  
+  it 'should leave numeric titles as strings even if the title key is not a simple downcased symbol' do
+    @tags['TITLE'] = '45'
+    
+    data = Flac2mp3.flacdata(@filename)
+    data[:title].should == '45'
+  end
 end
 
 describe Flac2mp3, 'when setting MP3 tag data' do

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification 
 name: flac2mp3
 version: !ruby/object:Gem::Version 
-  version: 0.2.0
-platform: ""
+  version: 0.2.1
+platform: ruby
 authors: 
 - Yossef Mendelssohn
 autorequire: 
 bindir: bin
 cert_chain: []
 
-date: 2007-12-08 00:00:00 -06:00
+date: 2008-03-30 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -89,7 +89,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: yomendel
-rubygems_version: 0.9.5
+rubygems_version: 1.1.0
 signing_key: 
 specification_version: 2
 summary: description of gem