fixme 6.0.0 → 6.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 50eba448b6368b404c7303844a56adb0dc283e5c
-  data.tar.gz: 1bc4d4729eaf1f041c2ba51fc851f1552dca879e
+SHA256:
+  metadata.gz: 24a8df0ed4191847cd7aecd39f9de96855ba751989cd621d23e4bb2f9c67a878
+  data.tar.gz: 5d4d12fdff0076e36a48c7af44232f54ca7cb245e9095c62a486635912273279
 SHA512:
-  metadata.gz: feec415f5bcc57485e7c93b7fe3985dc5bbfca736fc5713b1f7ef55e402ee78e9a3d143b19b04d883480da15659fc86f70b53792805f35f2efc813d58e4ff856
-  data.tar.gz: cc8158246e5e91fab8153d604f5c882593527ec411065e9240d03947c263ce05eeea454fca980f466bedcfdbbe1a3cd9306341b3778a039250dacce18f11d1d1
+  metadata.gz: d74ddad10cbee0922f2371a97a00d6b0a5361f2ceb0c0f5b7a425d09e277c4d4b2e61991d932aa7f8d7839811e7a0c7cc62889174b64b4ca1f29d7737cb010a7
+  data.tar.gz: fa16ba3b894eed22cd4566ce0d191efd03faab16365802ee3c5ba3375db500cb6fd01e2e6dc77ea065984c12a08055bfe0c9d1c113d2c4d56d460dec664dc103

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 6.1.0
+
+* Checks `APP_ENV`, not just `RACK_ENV`, as this is [what Sinatra now encourages using](https://github.com/sinatra/sinatra/blob/master/CHANGELOG.md#200--2017-04-10).
+
 ## 6.0.0
 
 * Require zero-padded month and day, i.e. disallow `2019-1-2`. This enforced consistency makes it easier to grep for an exploded FIXME.

data/README.md

@@ -22,7 +22,7 @@ For simplicity, the date comparison uses machine-local time (not e.g. the Rails
 
 ### Environment awareness
 
-If `Rails.env` (Ruby on Rails) or `ENV["RACK_ENV"]` (e.g. Sinatra) is present, it will only ever raise in the `"test"` and `"development"` environments. That is, the production app will never raise these exceptions.
+If `Rails.env` (Ruby on Rails), `ENV["APP_ENV"]` or `ENV["RACK_ENV"]` (e.g. Sinatra) is present, it will only ever raise in the `"test"` and `"development"` environments. That is, the production app will never raise these exceptions.
 
 ### Do something other than raise
 
@@ -58,8 +58,8 @@ If you e.g. don't want your CI server to raise, make it set the environment vari
 
 ### Pro-tips
 
-* Make sure it's clear from the exception or from a separate comment just what should be done – sometimes not even the person who wrote the quickfix will remember what you're meant to change.
-* If a FIXME raises right in a class/module, rather than inside an instance method, there may be follow-on errors (about missing methods and such) since the rest of that file won't execute. Being aware of this can help understand otherwise confusing CI failures.
+* Make sure it's clear from the exception or from a separate comment just what should be done – sometimes not even the person who wrote the FIXME will remember what you're meant to change.
+* If a FIXME raises right in a class/module, rather than inside a method, there may be follow-on errors (about missing methods and such) since the rest of that file won't execute. Being aware of this can help understand otherwise confusing CI failures.
 
 
 ## Installation

data/fixme.gemspec

@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.5"
+  spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
   spec.add_development_dependency "timecop"

data/lib/fixme.rb

@@ -64,7 +64,11 @@ module Fixme
     private
 
     def framework_env
-      defined?(Rails) ? Rails.env : ENV["RACK_ENV"]
+      if defined?(Rails)
+        Rails.env
+      else
+        ENV["RACK_ENV"] || ENV["APP_ENV"]
+      end
     end
 
     def disallow_timecop(&block)

data/lib/fixme/version.rb

@@ -1,3 +1,3 @@
 module Fixme
-  VERSION = "6.0.0"
+  VERSION = "6.1.0"
 end

data/spec/fixme_spec.rb

@@ -101,7 +101,28 @@ describe Fixme, "#FIXME" do
     end
   end
 
-  context "when a Rack environment is detected" do
+  context "when an APP_ENV is detected" do
+    before do
+      stub_env "DISABLE_FIXME_LIB", nil
+    end
+
+    it "raises in the 'test' environment" do
+      stub_env "APP_ENV", "test"
+      expect_to_raise
+    end
+
+    it "raises in the 'development' environment" do
+      stub_env "APP_ENV", "development"
+      expect_to_raise
+    end
+
+    it "does not raise in other environments" do
+      stub_env "APP_ENV", "production"
+      expect_not_to_raise
+    end
+  end
+
+  context "when a RACK_ENV is detected" do
     before do
       stub_env "DISABLE_FIXME_LIB", nil
     end

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: fixme
 version: !ruby/object:Gem::Version
-  version: 6.0.0
+  version: 6.1.0
 platform: ruby
 authors:
 - Henrik Nyh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-20 00:00:00.000000000 Z
+date: 2020-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -101,8 +101,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Comments that raise after a certain point in time.