fixme 5.0.0 → 6.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 92e0825cac58243fb2c3ce48aa71479b2c11a789
-  data.tar.gz: 129bba3a82f2e7a34cc7b2314698595d3376367f
+  metadata.gz: 50eba448b6368b404c7303844a56adb0dc283e5c
+  data.tar.gz: 1bc4d4729eaf1f041c2ba51fc851f1552dca879e
 SHA512:
-  metadata.gz: 8f1a393618b27bb77ce171afa39de54e0d3096d9f4c73a54177291de1190b6b59428488e5b0f6b0e92523900eeadb8be58aa338e3bab95b3144718f08d3059ac
-  data.tar.gz: 97ad061f1c4edd245e5d4e299e59d24b3441b14e51b342763b2b2381075cc1a34ca0135fd0d80c1c9bf99b95f1565aa310160a1a337be134d6f5762e8363ae81
+  metadata.gz: feec415f5bcc57485e7c93b7fe3985dc5bbfca736fc5713b1f7ef55e402ee78e9a3d143b19b04d883480da15659fc86f70b53792805f35f2efc813d58e4ff856
+  data.tar.gz: cc8158246e5e91fab8153d604f5c882593527ec411065e9240d03947c263ce05eeea454fca980f466bedcfdbbe1a3cd9306341b3778a039250dacce18f11d1d1

data/CHANGELOG.md

@@ -0,0 +1,9 @@
+# Changelog
+
+## 6.0.0
+
+* Require zero-padded month and day, i.e. disallow `2019-1-2`. This enforced consistency makes it easier to grep for an exploded FIXME.
+
+## 5.0.0 and earlier
+
+* Please see commit history, or make a pull request to update this file.

data/README.md

@@ -20,8 +20,6 @@ You may want to use these bad boys next to:
 
 For simplicity, the date comparison uses machine-local time (not e.g. the Rails configured time zone).
 
-Protip: make sure it's clear from the exception or from a separate comment just what should be done – sometimes not even the person who wrote the quickfix will remember what you're meant to change.
-
 ### Environment awareness
 
 If `Rails.env` (Ruby on Rails) or `ENV["RACK_ENV"]` (e.g. Sinatra) is present, it will only ever raise in the `"test"` and `"development"` environments. That is, the production app will never raise these exceptions.
@@ -58,6 +56,11 @@ end
 
 If you e.g. don't want your CI server to raise, make it set the environment variable `DISABLE_FIXME_LIB`.
 
+### Pro-tips
+
+* Make sure it's clear from the exception or from a separate comment just what should be done – sometimes not even the person who wrote the quickfix will remember what you're meant to change.
+* If a FIXME raises right in a class/module, rather than inside an instance method, there may be follow-on errors (about missing methods and such) since the rest of that file won't execute. Being aware of this can help understand otherwise confusing CI failures.
+
 
 ## Installation
 

data/lib/fixme.rb

@@ -76,10 +76,10 @@ module Fixme
     end
 
     def parse
-      match = @date_and_message.match(/\A(\d\d\d\d-\d\d?-\d\d?): (.+)\z/)
+      match = @date_and_message.match(/\A(\d\d\d\d-\d\d-\d\d): (.+)\z/)
 
       unless match
-        raise %{FIXME does not follow the "2015-01-01: Foo" format: #{@date_and_message.inspect}}
+        raise %{FIXME does not follow the "2015-01-31: Foo" format: #{@date_and_message.inspect}}
       end
 
       raw_date, message = match.captures

data/lib/fixme/version.rb

@@ -1,3 +1,3 @@
 module Fixme
-  VERSION = "5.0.0"
+  VERSION = "6.0.0"
 end

data/spec/fixme_spec.rb

@@ -41,10 +41,16 @@ describe Fixme, "#FIXME" do
     }.to raise_error("Fix by 2013-12-31: Remove this: and this.")
   end
 
-  it "complains if the desired format is not adhered to" do
+  it "complains if the desired message format is not adhered to" do
     expect {
       FIXME "9999-01-01, Learn to: type"
-    }.to raise_error(%{FIXME does not follow the "2015-01-01: Foo" format: "9999-01-01, Learn to: type"})
+    }.to raise_error(%{FIXME does not follow the "2015-01-31: Foo" format: "9999-01-01, Learn to: type"})
+  end
+
+  it "complains if the extended ISO 8601 date format is not adhered to" do
+    expect {
+      FIXME "9999-01-1: Foo"
+    }.to raise_error(%{FIXME does not follow the "2015-01-31: Foo" format: "9999-01-1: Foo"})
   end
 
   it "is available everywhere" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fixme
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 6.0.0
 platform: ruby
 authors:
 - Henrik Nyh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-01 00:00:00.000000000 Z
+date: 2019-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -74,6 +74,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- CHANGELOG.md
 - Gemfile
 - README.md
 - Rakefile
@@ -101,7 +102,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Comments that raise after a certain point in time.