fixbraces 1.1.0 → 1.2.0

data/CHANGELOG.md

@@ -0,0 +1,12 @@
+# Fixbraces Changelog #
+
+## 1.2.0 ##
+- Error and exit if no file or directory is passed to the script
+- Print a message and gracefully handle non-existent path or directory
+
+## 1.0.0 ##
+- List the changed files.
+
+## 0.9.0 ##
+
+- Initial version.

data/README.md

@@ -43,6 +43,10 @@ or a number of files:
 
 Run `fixbraces --help` for details.
 
+## Changelog
+
+See the current version of the [Changelog](https://github.com/Abizern/fixbraces/blob/master/CHANGELOG.md) is part of the repository.
+
 ## Disclaimer
 
 I have tests, you can see them for yourself. The script works, but I'm

data/bin/fixbraces

@@ -20,8 +20,18 @@ end
 
 source_files = []
 
-ARGV.each do |f|
-  f = File.expand_path f
+# Bail if no path of file is given
+Trollop::die "fixbraces needs to know what directory or files to attempt to correct" if ARGV.length < 1
+
+ARGV.each do |path|
+  f = File.expand_path path
+
+  # Skip this file or dir if it doesn't exist
+  unless File.exist? f
+    puts "Invalid path #{path}"
+    next
+  end
+
   extension = File.extname f
 
   if File.directory? f

data/features/fixbraces.feature

@@ -23,3 +23,23 @@ Feature: The binary interface for fixbraces works
     And there should not be any .h files listed
     And the .h files in that directory are unchanged
     And the exit status should be 0
+
+  Scenario: Show an error message if no file or directory is provided
+    Given an Xcode project
+    When I run `fixbraces`
+    Then the output should contain "Error: fixbraces needs to know what directory or files to attempt to correct."
+    And the exit status should not be 0
+
+  Scenario: Show an error message for a non-existent file or directory
+    Given an Xcode project
+    When I run `fixbraces non_existent_path`
+    Then the output should contain "Invalid path"
+    And the exit status should be 0
+
+  Scenario: If one of the files is non-existent correct the file that can be changed and show an error message for the non-existent one
+    Given a single source file called MasterViewController.m
+    When I run `fixbraces MasterViewController.m some_file.m`
+    Then MasterViewController.m should be formatted correctly
+    And the output should contain "MasterViewController.m"
+    And the output should contain "Invalid path"
+    And the exit status should be 0

data/lib/fixbraces/version.rb

@@ -1,3 +1,3 @@
 module Fixbraces
-  VERSION = "1.1.0"
+  VERSION = "1.2.0"
 end

data/spec/fixbraces_spec.rb

@@ -62,6 +62,17 @@ describe Fixbraces do
       result = `diff -r --brief #{Dir.pwd + "/tmp/spec/"} #{Dir.pwd + "/spec/fixtures/expected/"}`
       expect(result).to eq ""
     end
+
+    it 'should preserve the original file mode' do
+      files = Dir.glob Dir.pwd + "/tmp/spec/*.{h,m}"
+      files.each do |f|
+        original_mode = File.new(f).stat.mode
+        Fixbraces.process_file f
+        new_mode = File.new(f).stat.mode
+
+        expect(new_mode).to eq original_mode
+      end
+    end
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fixbraces
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-29 00:00:00.000000000 Z
+date: 2013-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: trollop
@@ -91,6 +91,7 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .rspec
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md