fiveruns_tuneup 0.8.6 → 0.8.7

data/CHANGELOG

@@ -1,5 +1,11 @@
+v0.8.7. Sandboxed javascript for non-Prototype apps (Thanks, Howard Rauscher). The tuneup.log now written explicitly to RAILS_ROOT/log.  Removed History.rdoc in favor of CHANGELOG.
+
 v0.8.6. Performance optimizations, CSS fixes that prevents some layout issues that occurred when system doesn't have tuneup's preferred fonts.
 
 v0.8.5. Handle valid content types other than text/html (like strict XHTML with content type application/xhmtl+xml).
 
-v0.8.4. Alert notices push down absolute/fixed elements.
+v0.8.4. Fixes for forgery protection breaking the panel, significant work on display issues (including CSS isolation concerns and alert notices pushing down absolute/fixed elements), and support for environmental configuration.  Support for Rails 2.1 development mode as a gem dependency.
+
+v0.8.3. Beta release.
+
+v0.8.1. First gem package with basic functionality

data/CONTRIBUTORS

@@ -0,0 +1 @@
+* 2008-06-14: Howard Rauscher; merged javascript sandboxing code from git://github.com/howardr/fiveruns_tuneup.git (master:8cc558dbe)

data/Manifest

@@ -12,12 +12,13 @@ assets/images/schema.png
 assets/images/signin.gif
 assets/images/spinner.gif
 assets/images/warning.gif
+assets/javascripts/init.js
 assets/javascripts/prototype.js
 assets/javascripts/tuneup.js
 assets/stylesheets/tuneup.css
 bin/fiveruns_tuneup
 CHANGELOG
-History.rdoc
+CONTRIBUTORS
 init.rb
 install.rb
 lib/bumpspark_helper.rb
@@ -41,6 +42,7 @@ lib/fiveruns_tuneup.rb
 lib/tuneup_config.rb
 lib/tuneup_controller.rb
 lib/tuneup_helper.rb
+Manifest
 rails/init.rb
 Rakefile
 README.rdoc
@@ -56,4 +58,4 @@ views/tuneup/_sql.html.erb
 views/tuneup/_step.html.erb
 views/tuneup/panel/_registered.html.erb
 views/tuneup/panel/_unregistered.html.erb
-Manifest
+views/tuneup/sandbox.html.erb

data/assets/javascripts/init.js

@@ -0,0 +1,12 @@
+// setTimeout will not be called untilled the DOM is loaded
+setTimeout(function() {
+	var ifr = document.createElement('iframe');
+	ifr.src = '/tuneup/sandbox';
+	
+	var style        = ifr.style;
+	style.visibility = 'hidden';
+	style.width      = '0';
+	style.height     = '0';
+	
+	document.body.appendChild(ifr);
+}, 0);

data/assets/javascripts/tuneup.js

@@ -1,3 +1,29 @@
+var _window   = window.parent,    // window obj of the main page
+    _document = _window.document, // document obj of the main page
+    TuneUp    = _window.TuneUp;   // TuneUp obj from declared on main page
+
+var _$ = $; // rename Protoype bling
+// our new bling will reference our main window then call Prototype bling
+$ = function(element) {
+	if(typeof element == 'string') {
+		element = _document.getElementById(element);
+	}
+	
+	return _$(element);
+};
+
+var _$$ = $$;  // rename Protoype double  bling
+// our new double bling will reference our main window then call Prototype bling
+$$ = function() {
+  return Selector.findChildElements(_document, $A(arguments));
+}
+
+// ensures that Prototypes Element.extend actually exstend another frames node
+_nativeExtensions = false;
+
+_window.TuneUpSandbox = window;
+
+
 TuneUp.switchSchema = function(table) {
   var element = $('tuneup-schema-table-' + table);
   var operation = element.visible() ? 'hide' : 'show';
@@ -11,7 +37,7 @@ TuneUp.Spinner = {
 }
 
 TuneUp.adjustElement = function(e) {
-	var top = parseFloat(e.getStyle('top') || 0);
+	var top = parseFloat(Element.getStyle(e, 'top') || 0);
 	var adjust = 0;
 
 	if ($('tuneup-flash').hasClassName('tuneup-show')) {
@@ -36,8 +62,8 @@ TuneUp.adjustElement = function(e) {
 }
 
 TuneUp.adjustFixedElements = function(e) {
-	document.body.descendants().each(function(e) {
-		var pos = e.getStyle('position');
+	$(_document.body).descendants().each(function(e) {
+		var pos = Element.getStyle(e, 'position');
 		if (pos == 'fixed') {
 			TuneUp.adjustElement(e);
 		}
@@ -45,11 +71,11 @@ TuneUp.adjustFixedElements = function(e) {
 }
 
 TuneUp.adjustAbsoluteElements = function(e) {
-	e.immediateDescendants().each(function (e) {
+	$(e).immediateDescendants().each(function (e) {
 		if (e.id == "tuneup") {
 			return;
 		}
-		var pos = e.getStyle('position');
+		var pos = Element.getStyle(e, 'position');
 		if (pos == 'absolute') {
 			TuneUp.adjustElement(e);
 			TuneUp.adjustAbsoluteElements(e);
@@ -64,17 +90,16 @@ TuneUp.adjustAbsoluteElements = function(e) {
 }
 
 Event.observe(window, 'load', function() {
-  new Insertion.Top(document.body, "<div id='tuneup'><h1>FiveRuns TuneUp</h1><img id='tuneup_spinner' style='display:none' src='/images/tuneup/spinner.gif' alt=''/><div id='tuneup-content' style='display:block'></div></div><div id='tuneup-flash'></div>");
+  new Insertion.Top(_document.body, "<div id='tuneup'><h1>FiveRuns TuneUp</h1><img id='tuneup_spinner' style='display:none' src='/images/tuneup/spinner.gif' alt=''/><div id='tuneup-content' style='display:block'></div></div><div id='tuneup-flash'></div>");
   
-	TuneUp.adjustAbsoluteElements(document.body);
+	TuneUp.adjustAbsoluteElements(_document.body);
 	TuneUp.adjustFixedElements();
 
-	new Ajax.Request('/tuneup?uri=' + encodeURIComponent(document.location.href),
-    {
-      asynchronous:true,
-      evalScripts:true,
-      onLoading: TuneUp.Spinner.start,
-      onComplete: TuneUp.Spinner.stop
+	new Ajax.Request('/tuneup?uri=' + encodeURIComponent(_document.location.href), {
+      asynchronous : true,
+      evalScripts  : true,
+      onLoading    : TuneUp.Spinner.start,
+      onComplete   : TuneUp.Spinner.stop
     });
 });
 

data/fiveruns_tuneup.gemspec

@@ -1,28 +1,28 @@
 
-# Gem::Specification for Fiveruns_tuneup-0.8.6
+# Gem::Specification for Fiveruns_tuneup-0.8.7
 # Originally generated by Echoe
 
 Gem::Specification.new do |s|
   s.name = %q{fiveruns_tuneup}
-  s.version = "0.8.6"
+  s.version = "0.8.7"
 
   s.specification_version = 2 if s.respond_to? :specification_version=
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["FiveRuns Development Team"]
-  s.date = %q{2008-06-13}
+  s.date = %q{2008-06-18}
   s.default_executable = %q{fiveruns_tuneup}
   s.description = %q{Instrumentation for the FiveRuns TuneUp product.}
   s.email = %q{dev@fiveruns.com}
   s.executables = ["fiveruns_tuneup"]
   s.extra_rdoc_files = ["bin/fiveruns_tuneup", "CHANGELOG", "lib/bumpspark_helper.rb", "lib/fiveruns/tuneup/asset_tags.rb", "lib/fiveruns/tuneup/configuration.rb", "lib/fiveruns/tuneup/custom_methods.rb", "lib/fiveruns/tuneup/environment.rb", "lib/fiveruns/tuneup/instrumentation/action_controller/base.rb", "lib/fiveruns/tuneup/instrumentation/action_view/base.rb", "lib/fiveruns/tuneup/instrumentation/active_record/base.rb", "lib/fiveruns/tuneup/instrumentation/cgi/session.rb", "lib/fiveruns/tuneup/instrumentation/utilities.rb", "lib/fiveruns/tuneup/multipart.rb", "lib/fiveruns/tuneup/runs.rb", "lib/fiveruns/tuneup/schema.rb", "lib/fiveruns/tuneup/step.rb", "lib/fiveruns/tuneup/urls.rb", "lib/fiveruns/tuneup/version.rb", "lib/fiveruns/tuneup.rb", "lib/fiveruns_tuneup.rb", "lib/tuneup_config.rb", "lib/tuneup_controller.rb", "lib/tuneup_helper.rb", "README.rdoc", "tasks/assets.rake"]
-  s.files = ["assets/images/arrows.gif", "assets/images/edit.png", "assets/images/fade.png", "assets/images/fade_down.png", "assets/images/head.gif", "assets/images/logo.gif", "assets/images/logo_clear.png", "assets/images/magnify.png", "assets/images/pip.gif", "assets/images/pointer.gif", "assets/images/schema.png", "assets/images/signin.gif", "assets/images/spinner.gif", "assets/images/warning.gif", "assets/javascripts/prototype.js", "assets/javascripts/tuneup.js", "assets/stylesheets/tuneup.css", "bin/fiveruns_tuneup", "CHANGELOG", "History.rdoc", "init.rb", "install.rb", "lib/bumpspark_helper.rb", "lib/fiveruns/tuneup/asset_tags.rb", "lib/fiveruns/tuneup/configuration.rb", "lib/fiveruns/tuneup/custom_methods.rb", "lib/fiveruns/tuneup/environment.rb", "lib/fiveruns/tuneup/instrumentation/action_controller/base.rb", "lib/fiveruns/tuneup/instrumentation/action_view/base.rb", "lib/fiveruns/tuneup/instrumentation/active_record/base.rb", "lib/fiveruns/tuneup/instrumentation/cgi/session.rb", "lib/fiveruns/tuneup/instrumentation/utilities.rb", "lib/fiveruns/tuneup/multipart.rb", "lib/fiveruns/tuneup/runs.rb", "lib/fiveruns/tuneup/schema.rb", "lib/fiveruns/tuneup/step.rb", "lib/fiveruns/tuneup/urls.rb", "lib/fiveruns/tuneup/version.rb", "lib/fiveruns/tuneup.rb", "lib/fiveruns_tuneup.rb", "lib/tuneup_config.rb", "lib/tuneup_controller.rb", "lib/tuneup_helper.rb", "rails/init.rb", "Rakefile", "README.rdoc", "tasks/assets.rake", "test/test_helper.rb", "test/tuneup_test.rb", "uninstall.rb", "views/tuneup/_data.html.erb", "views/tuneup/_flash.html.erb", "views/tuneup/_link.html.erb", "views/tuneup/_schema.html.erb", "views/tuneup/_sql.html.erb", "views/tuneup/_step.html.erb", "views/tuneup/panel/_registered.html.erb", "views/tuneup/panel/_unregistered.html.erb", "Manifest", "fiveruns_tuneup.gemspec"]
+  s.files = ["assets/images/arrows.gif", "assets/images/edit.png", "assets/images/fade.png", "assets/images/fade_down.png", "assets/images/head.gif", "assets/images/logo.gif", "assets/images/logo_clear.png", "assets/images/magnify.png", "assets/images/pip.gif", "assets/images/pointer.gif", "assets/images/schema.png", "assets/images/signin.gif", "assets/images/spinner.gif", "assets/images/warning.gif", "assets/javascripts/init.js", "assets/javascripts/prototype.js", "assets/javascripts/tuneup.js", "assets/stylesheets/tuneup.css", "bin/fiveruns_tuneup", "CHANGELOG", "CONTRIBUTORS", "init.rb", "install.rb", "lib/bumpspark_helper.rb", "lib/fiveruns/tuneup/asset_tags.rb", "lib/fiveruns/tuneup/configuration.rb", "lib/fiveruns/tuneup/custom_methods.rb", "lib/fiveruns/tuneup/environment.rb", "lib/fiveruns/tuneup/instrumentation/action_controller/base.rb", "lib/fiveruns/tuneup/instrumentation/action_view/base.rb", "lib/fiveruns/tuneup/instrumentation/active_record/base.rb", "lib/fiveruns/tuneup/instrumentation/cgi/session.rb", "lib/fiveruns/tuneup/instrumentation/utilities.rb", "lib/fiveruns/tuneup/multipart.rb", "lib/fiveruns/tuneup/runs.rb", "lib/fiveruns/tuneup/schema.rb", "lib/fiveruns/tuneup/step.rb", "lib/fiveruns/tuneup/urls.rb", "lib/fiveruns/tuneup/version.rb", "lib/fiveruns/tuneup.rb", "lib/fiveruns_tuneup.rb", "lib/tuneup_config.rb", "lib/tuneup_controller.rb", "lib/tuneup_helper.rb", "Manifest", "rails/init.rb", "Rakefile", "README.rdoc", "tasks/assets.rake", "test/test_helper.rb", "test/tuneup_test.rb", "uninstall.rb", "views/tuneup/_data.html.erb", "views/tuneup/_flash.html.erb", "views/tuneup/_link.html.erb", "views/tuneup/_schema.html.erb", "views/tuneup/_sql.html.erb", "views/tuneup/_step.html.erb", "views/tuneup/panel/_registered.html.erb", "views/tuneup/panel/_unregistered.html.erb", "views/tuneup/sandbox.html.erb", "fiveruns_tuneup.gemspec"]
   s.has_rdoc = true
   s.homepage = %q{http://github.com/fiveruns/fiveruns_tuneup}
   s.rdoc_options = ["--line-numbers", "--inline-source", "--title", "Fiveruns_tuneup", "--main", "README.rdoc"]
   s.require_paths = ["lib"]
   s.rubyforge_project = %q{fiveruns}
-  s.rubygems_version = %q{1.0.1}
+  s.rubygems_version = %q{1.1.1}
   s.summary = %q{Instrumentation for the FiveRuns TuneUp product.}
   s.test_files = ["test/test_helper.rb", "test/tuneup_test.rb"]
 

data/lib/fiveruns/tuneup.rb

@@ -8,7 +8,7 @@ require File.dirname(__FILE__) << '/tuneup/step'
 module Fiveruns
   module Tuneup
     
-    LOGGER = Logger.new('log/tuneup.log')
+    LOGGER = Logger.new(File.join(RAILS_ROOT || '', "log/tuneup.log"))
         
     class << self
       

data/lib/fiveruns/tuneup/asset_tags.rb

@@ -9,15 +9,12 @@ module Fiveruns
         if after
           insertion = %(
           <!-- START FIVERUNS TUNEUP ASSETS -->
-          <link rel='stylesheet' type='text/css' href='/stylesheets/tuneup/tuneup.css'/>
-          #{insert_prototype unless response.body.include?('prototype.js')}
-          <script type='text/javascript'>
-            var TuneUp = {};
-            TuneUp.frontend_url = "#{Fiveruns::Tuneup.frontend_url}";
-          </script>
-          <script type='text/javascript' src='/javascripts/tuneup/tuneup.js'></script>
+          <link rel="stylesheet" type="text/css" href="/stylesheets/tuneup/tuneup.css" />
+          <script type="text/javascript"> var TuneUp = { frontend_url : '#{Fiveruns::Tuneup.frontend_url}'}; </script>
+          <script type="text/javascript" src="/javascripts/tuneup/init.js"></script>
           <!-- END FIVERUNS TUNEUP ASSETS -->
           )
+          
           response.headers["Content-Length"] += insertion.size
           response.body.replace(before << insertion << '</head>' << after)
           log :error, "Inserted asset tags"

data/lib/fiveruns/tuneup/instrumentation/action_controller/base.rb

@@ -34,7 +34,7 @@ module Fiveruns
             end
             def process_with_fiveruns_tuneup(request, response, *args, &block)
               result = process_without_fiveruns_tuneup(request, response, *args, &block)
-              if !request.xhr? && response.content_type && response.content_type.include?('html')
+              if !request.xhr? && response.content_type && response.content_type.include?('html') && controller_name != 'tuneup'
                 Fiveruns::Tuneup.add_asset_tags_to(response)
               end
               result

data/lib/fiveruns/tuneup/version.rb

@@ -66,7 +66,7 @@ module Fiveruns
 
       MAJOR = 0
       MINOR = 8
-      TINY  = 6
+      TINY  = 7
 
       # The current version as a Version instance
       CURRENT = new(MAJOR, MINOR, TINY)

data/lib/tuneup_controller.rb

@@ -75,6 +75,10 @@ class TuneupController < ActionController::Base
     collect false
   end
   
+  def sandbox
+    
+  end
+  
   #######
   private
   #######

data/lib/tuneup_helper.rb

@@ -12,7 +12,7 @@ module TuneupHelper #:nodoc:
   
   def tuneup_collection_link
     state = tuneup_collecting? ? :off : :on
-    link_to_remote "Turn #{state.to_s.titleize}", :url => "/tuneup/#{state}"
+    %|<a onclick="new TuneUpSandbox.Ajax.Request('/tuneup/#{state}', {asynchronous:true, evalScripts:true}); return false;" href="#">Turn #{state.to_s.titleize}</a>|
   end
   
   def tuneup_recording?
@@ -60,7 +60,7 @@ module TuneupHelper #:nodoc:
   def tuneup_step_link(step)
     name = tuneup_style_step_name(tuneup_truncate_step_name(step))
     link = if step.children.any?
-      link_to_function(name, "$('#{dom_id(step, :children)}').toggle();$('#{dom_id(step)}').toggleClassName('tuneup-opened');", :class => "tuneup-step-link")
+      link_to_function(name, "TuneUpSandbox.$('#{dom_id(step, :children)}').toggle();TuneUpSandbox.$('#{dom_id(step)}').toggleClassName('tuneup-opened');", :class => "tuneup-step-link")
     else
       name
     end
@@ -68,11 +68,7 @@ module TuneupHelper #:nodoc:
   end
   
   def link_to_upload
-    link_to_remote "Upload this Run",
-      :url => "/tuneup/upload?uri=#{CGI.escape(params[:uri])}",
-      :loading => '$("tuneup-top").hide(); TuneUp.Spinner.start()',
-      :complete => ' TuneUp.Spinner.stop(); $("tuneup-top").show();',
-      :html => {:id => 'tuneup-save-link'}
+     %|<a onclick="new TuneUpSandbox.Ajax.Request('/tuneup/upload?uri=#{CGI.escape(params[:uri])}', {asynchronous:true, evalScripts:true, onComplete:function(request){ TuneUp.Spinner.stop(); TuneUpSandbox.$('tuneup-top').show();}, onLoading:function(request){TuneUpSandbox.$('tuneup-top').hide(); TuneUp.Spinner.start()}}); return false;" id="tuneup-save-link" href="#">Share this Run</a>|
   end
   
   def additional_step_links(step)
@@ -162,7 +158,7 @@ module TuneupHelper #:nodoc:
     update_page do |page|
       page['tuneup-flash'].removeClassName('tuneup-show');
       page['tuneup-content'].replace_html(render(:partial => "tuneup/panel/#{@config.state}"))
-      page << 'TuneUp.adjustAbsoluteElements(document.body);'
+      page << 'TuneUp.adjustAbsoluteElements(_document.body);'
       page << 'TuneUp.adjustFixedElements();'
     end
   end
@@ -176,7 +172,7 @@ module TuneupHelper #:nodoc:
         page['tuneup-flash'].removeClassName("tuneup-#{other_type}")
       end
       page['tuneup-flash'].addClassName("tuneup-#{type}");
-      page << 'TuneUp.adjustAbsoluteElements(document.body);'
+      page << 'TuneUp.adjustAbsoluteElements(_document.body);'
       page << 'TuneUp.adjustFixedElements();'
     end
   end

data/views/tuneup/panel/_unregistered.html.erb

@@ -1,4 +1,4 @@
-<% form_remote_tag :url => '/tuneup/signin', :loading => 'TuneUp.Spinner.start()', :complete => 'TuneUp.Spinner.stop()' do %>
+<form onsubmit="new TuneUpSandbox.Ajax.Request('/tuneup/signin', {asynchronous:true, evalScripts:true, onComplete:function(request){TuneUp.Spinner.stop()}, onLoading:function(request){TuneUp.Spinner.start()}, parameters:Form.serialize(this)}); return false;" method="post" action="/tuneup/signin">
   <p class='tuneup-full'>
     <label for='email'>Email</label>
     <%= text_field_tag :email, nil, :size => 20 %>
@@ -10,5 +10,4 @@
     or  
     <%= link_to "Sign Up for an Account", tuneup_signup_url %>
   </p>
-  
-<% end %>
+</form>

data/views/tuneup/sandbox.html.erb

@@ -0,0 +1,6 @@
+<html><head>
+<script type="text/javascript" src="/javascripts/tuneup/prototype.js"></script>
+<script type="text/javascript" src="/javascripts/tuneup/tuneup.js"></script>
+<script type="text/javascript"></script>
+</head><body>
+</body></html>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: fiveruns_tuneup
 version: !ruby/object:Gem::Version 
-  version: 0.8.6
+  version: 0.8.7
 platform: ruby
 authors: 
 - FiveRuns Development Team
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-06-13 00:00:00 -05:00
+date: 2008-06-18 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -68,12 +68,13 @@ files:
 - assets/images/signin.gif
 - assets/images/spinner.gif
 - assets/images/warning.gif
+- assets/javascripts/init.js
 - assets/javascripts/prototype.js
 - assets/javascripts/tuneup.js
 - assets/stylesheets/tuneup.css
 - bin/fiveruns_tuneup
 - CHANGELOG
-- History.rdoc
+- CONTRIBUTORS
 - init.rb
 - install.rb
 - lib/bumpspark_helper.rb
@@ -97,6 +98,7 @@ files:
 - lib/tuneup_config.rb
 - lib/tuneup_controller.rb
 - lib/tuneup_helper.rb
+- Manifest
 - rails/init.rb
 - Rakefile
 - README.rdoc
@@ -112,7 +114,7 @@ files:
 - views/tuneup/_step.html.erb
 - views/tuneup/panel/_registered.html.erb
 - views/tuneup/panel/_unregistered.html.erb
-- Manifest
+- views/tuneup/sandbox.html.erb
 - fiveruns_tuneup.gemspec
 has_rdoc: true
 homepage: http://github.com/fiveruns/fiveruns_tuneup
@@ -141,7 +143,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: fiveruns
-rubygems_version: 1.0.1
+rubygems_version: 1.1.1
 signing_key: 
 specification_version: 2
 summary: Instrumentation for the FiveRuns TuneUp product.

data/History.rdoc

@@ -1,7 +0,0 @@
-= History
-
-* v0.8.4. Fixes for forgery protection breaking the panel, significant work on display issues including CSS isolation concerns, and support for environmental configuration.  Support for Rails 2.1 development mode as a gem dependency.
-
-* v0.8.3. Beta release.
-
-* v0.8.1. First gem package with basic functionality