fiveruns_tuneup 0.8.18 → 0.8.20

data/CHANGELOG

@@ -1,3 +1,5 @@
+v0.8.20. Rails 2.3 support, remove old bin/fiveruns_tuneup executable.
+
 v0.8.18. Fix deprecated use of Dependencies.
 
 v0.8.17. Clean build to work around 0.8.16 build snafu (built from a non-clean clone)

data/README.rdoc

@@ -9,25 +9,21 @@
 
 Display call stack information on Rails requests.
 
-*THIS IS A BETA RELEASE*; the normal disclaimers apply.
-
 == Installation
 
+For Rails 2.1+, you can use it as a gem dependency (recommended).
+
 Install the gem:
 
   sudo gem install fiveruns_tuneup
-  
-For Rails 2.0, install the plugin into +vendor/plugins+:
-  
-  fiveruns_tuneup /path/to/app
-  (or you can clone the GitHub repo into vendor/plugins)
-  
-For Rails 2.1+, you can use it as a gem dependency instead; in your +environment.rb+:
+
+In your +environment.rb+:
 
   config.gem 'fiveruns_tuneup'
   
-*Note*: There is an issue in Rails 2.1 that prevents the plugin running as an unpacked 
-gem (via +rake gems:unpack+).
+*Note*: There is an issue in Rails 2.1 that prevents the plugin running as an unpacked gem (via +rake gems:unpack+).
+
+TuneUp can also be used from +vendor/plugins+.
   
 == Configuration
 

data/lib/fiveruns/tuneup/asset_tags.rb

@@ -14,8 +14,7 @@ module Fiveruns
           <script type="text/javascript" src="/javascripts/tuneup/init.js"></script>
           <!-- END FIVERUNS TUNEUP ASSETS -->
           )
-          
-          response.headers["Content-Length"] += insertion.size
+          add_content_length(response, insertion.size)
           response.body.replace(before << insertion << '</head>' << after)
           log :error, "Inserted asset tags"
         else
@@ -25,6 +24,7 @@ module Fiveruns
       
       def show_for?(response)
         return false unless response.body
+        return true if response.headers['ETag'] && response.headers['Content-Type'].to_s.include?('html')
         return false unless response.headers['Status'] && response.headers['Status'].include?('200')
         true
       end
@@ -33,6 +33,20 @@ module Fiveruns
         "<script type='text/javascript' src='/javascripts/tuneup/prototype.js'></script>"
       end
       
+      # Modify the Content-Length header, regardless if String/Fixnum, and
+      # keep it the same type
+      def add_content_length(response, delta)
+        length = response.headers["Content-Length"]
+        response.headers["Content-Length"] = case length
+        when Fixnum
+          length + delta
+        when String
+          (length.to_i + delta).to_s
+        else
+          length # Shouldn't happen
+        end
+      end
+      
     end
     
   end

data/lib/fiveruns/tuneup/version.rb

@@ -75,7 +75,7 @@ module Fiveruns
 
       MAJOR = 0
       MINOR = 8
-      TINY  = 18
+      TINY  = 20
 
       # The current version as a Version instance
       CURRENT = new(MAJOR, MINOR, TINY)

data/lib/tuneup_controller.rb

@@ -95,12 +95,6 @@ class TuneupController < ActionController::Base
   private
   #######
   
-  def log_processing
-    Fiveruns::Tuneup.log :info, "\n\nProcessing #{controller_class_name}\##{action_name} (for #{request_origin}) [#{request.method.to_s.upcase}]"
-    Fiveruns::Tuneup.log :info, "  Session ID: #{@_session.session_id}" if @_session and @_session.respond_to?(:session_id)
-    Fiveruns::Tuneup.log :info, "  Parameters: #{respond_to?(:filter_parameters) ? filter_parameters(params).inspect : params.inspect}"
-  end
-  
   def collect(state)
     Fiveruns::Tuneup.collecting = state
     render :update do |page|

data/views/tuneup/_data.html.erb

@@ -10,7 +10,7 @@
   <ul id="tuneup-details">
     <%= render :partial => 'step.html.erb', :collection => tuneup_data.children %>
 		<li style="clear:both"></li>
-		<li style="padding-top:10px;font-style:italic;float:right;font-size:0.8em;color:#ccc;">For Rails monitoring in production, try 
-		  <a href="http://www.fiveruns.com/products/manage?utm_source=TuneUpBar&utm_medium=ManageURL&utm_campaign=ManageClicks" target="_blank" style="font-style:italic">FiveRuns Manage</a></li>
+		<li style="padding-top:10px;font-style:italic;float:right;font-size:0.8em;color:#ccc;">For production technical and business metrics, try 
+		  <a href="http://dash.fiveruns.com/?utm_source=TuneUpBar&amp;utm_medium=DashURL&amp;utm_campaign=Dash" target="_blank" style="font-style:italic">FiveRuns Dash</a></li>
   </ul>
 </div>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: fiveruns_tuneup
 version: !ruby/object:Gem::Version 
-  version: 0.8.18
+  version: 0.8.20
 platform: ruby
 authors: 
 - FiveRuns Development Team
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-11-14 00:00:00 -06:00
+date: 2009-03-23 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -60,7 +60,6 @@ files:
 - assets/javascripts/tuneup.js
 - assets/stylesheets
 - assets/stylesheets/tuneup.css
-- bin/fiveruns_tuneup
 - lib/bumpspark_helper.rb
 - lib/fiveruns
 - lib/fiveruns/tuneup
@@ -128,7 +127,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: fiveruns_tuneup
-rubygems_version: 1.3.0
+rubygems_version: 1.3.1
 signing_key: 
 specification_version: 2
 summary: Rails plugin that provides the FiveRuns TuneUp Panel (http://tuneup.fiveruns.com)

data/bin/fiveruns_tuneup

@@ -1,26 +0,0 @@
-#!/usr/bin/env ruby
-
-require 'fileutils'
-require File.dirname(__FILE__) << "/../lib/fiveruns/tuneup/version"
-
-# For older Rails versions
-# USAGE: fiveruns_manage [RAILS_ROOT]
-plugin_dir = File.join(ARGV[0] || Dir.pwd, 'vendor/plugins')
-unless File.directory?(plugin_dir)
-  abort "FiveRuns TuneUp: #{plugin_dir} does not exist; cannot install plugin"
-end
-
-FileUtils.rm_rf File.join(plugin_dir, 'fiveruns_tuneup') rescue nil
-
-File.readlines(File.dirname(__FILE__) << "/../Manifest").each do |line|
-  stub = line.strip
-  origin = File.dirname(__FILE__) << "/../#{stub}"
-  next if origin =~ /\/fiveruns_tuneup$/
-  if File.file?(origin)
-    destination = File.join(plugin_dir, 'fiveruns_tuneup', stub)
-    FileUtils.mkdir_p File.dirname(destination)
-    FileUtils.cp origin, destination
-  end
-end
-
-STDERR.puts "Installed FiveRuns TuneUp (#{Fiveruns::Tuneup::Version::STRING}) in vendor/plugins/fiveruns_tuneup"