fiveruns_tuneup 0.8.14 → 0.8.15

data/CHANGELOG

@@ -1,3 +1,5 @@
+v0.8.15. Removed use of all Rails JS helpers, this fixes an issue when jrails is used in the app (Thanks, Chris Zelenak) 
+
 v0.8.13. Improved unobtrusive branding.
 
 v0.8.12. Added some inline branding.

data/CONTRIBUTORS

@@ -1,3 +1,5 @@
+* 2008-09-03: Chris Zelenak; pointed us in the right direction: a bug with tuneup + jrails
+
 * 2008-07-21: Bryan Liles; merged fallback log dir code from git://github.com/bryanl/fiveruns_tuneup.git (master:e5838f47f)
 
 * 2008-06-14: Howard Rauscher; merged javascript sandboxing code from git://github.com/howardr/fiveruns_tuneup.git (master:8cc558dbe)

data/fiveruns_tuneup.gemspec

@@ -1,18 +1,18 @@
 
-# Gem::Specification for Fiveruns_tuneup-0.8.14
+# Gem::Specification for Fiveruns_tuneup-0.8.15
 # Originally generated by Echoe
 
 --- !ruby/object:Gem::Specification 
 name: fiveruns_tuneup
 version: !ruby/object:Gem::Version 
-  version: 0.8.14
+  version: 0.8.15
 platform: ruby
 authors: 
 - FiveRuns Development Team
 autorequire: 
 bindir: bin
 
-date: 2008-08-29 00:00:00 -05:00
+date: 2008-09-04 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 

data/lib/fiveruns/tuneup/version.rb

@@ -75,7 +75,7 @@ module Fiveruns
 
       MAJOR = 0
       MINOR = 8
-      TINY  = 14
+      TINY  = 15
 
       # The current version as a Version instance
       CURRENT = new(MAJOR, MINOR, TINY)

data/lib/tuneup_controller.rb

@@ -31,9 +31,9 @@ class TuneupController < ActionController::Base
   end
   
   def register
-    render(:update) do |p| 
-      p['tuneup-panel'].hide
-      p.insert_html(:bottom, 'tuneup-content', :partial => 'tuneup/panel/register.html.erb')
+    render :update do |page| 
+      page << "$('tuneup-panel').hide();"
+      page << %[new Insertion.Bottom('tuneup-content', "#{escape_javascript(render(:partial => 'tuneup/panel/register.html.erb'))}");]
     end
   end
   
@@ -45,7 +45,7 @@ class TuneupController < ActionController::Base
     end
     render :update do |page|
       if api_key
-        page.replace('tuneup-save-link', link_to_upload)
+        page << "$('tuneup-save-link').replace('#{escape_javascript(link_to_upload)}');"
         page << redisplay_last_run(false)
       else
         page << tuneup_show_flash(:error,
@@ -103,7 +103,9 @@ class TuneupController < ActionController::Base
   
   def collect(state)
     Fiveruns::Tuneup.collecting = state
-    render(:update) { |p| p['tuneup-panel'].replace(render(:partial => 'tuneup/panel/show.html.erb')) }
+    render :update do |page|
+      page << %[$('tuneup-panel').update("#{escape_javascript(render(:partial => 'tuneup/panel/show.html.erb'))}")]
+    end
   end
 
   def find_config

data/lib/tuneup_helper.rb

@@ -172,8 +172,8 @@ module TuneupHelper #:nodoc:
   
   def tuneup_reload_panel
     update_page do |page|
-      page['tuneup-flash'].removeClassName('tuneup-show');
-      page['tuneup-content'].replace_html(render(:partial => "tuneup/panel/show.html.erb"))
+      page << "$('tuneup-flash').removeClassName('tuneup-show');"
+      page << %[$('tuneup-content').update("#{escape_javascript(render(:partial => 'tuneup/panel/show.html.erb'))}");]
       page << 'TuneUp.adjustAbsoluteElements(_document.body);'
       page << 'TuneUp.adjustFixedElements();'
     end
@@ -182,12 +182,12 @@ module TuneupHelper #:nodoc:
   def tuneup_show_flash(type, locals)
     types = [:error, :notice].reject { |t| t == type }
     update_page do |page|
-      page['tuneup-flash'].replace_html(render(:partial => 'flash.html.erb', :locals => locals.merge(:type => type)))
-      page['tuneup-flash'].addClassName('tuneup-show');
+      page << %[$('tuneup-flash').update("#{escape_javascript(render(:partial => 'flash.html.erb', :locals => locals.merge(:type => type)))}");]
+      page << "$('tuneup-flash').addClassName('tuneup-show')"
       types.each do |other_type|
-        page['tuneup-flash'].removeClassName("tuneup-#{other_type}")
+        page << "$('tuneup-flash').removeClassName('tuneup-#{other_type}')"
       end
-      page['tuneup-flash'].addClassName("tuneup-#{type}");
+      page << "$('tuneup-flash').addClassName('tuneup-#{type}')"
       page << 'TuneUp.adjustAbsoluteElements(_document.body);'
       page << 'TuneUp.adjustFixedElements();'
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: fiveruns_tuneup
 version: !ruby/object:Gem::Version 
-  version: 0.8.14
+  version: 0.8.15
 platform: ruby
 authors: 
 - FiveRuns Development Team
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-08-29 00:00:00 -05:00
+date: 2008-09-04 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency