fiscal_year 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1468592d50121d359747c36cc467fac062fd25b0b50344668b612074133527d3
-  data.tar.gz: b5428700e7f8b6b256e33b854623d1079d5aa3b93ce8a1873a14c6c660b3e1fe
+  metadata.gz: b2a44c87e166920493e3723924cdf5c0a20cbdca0f148fb87e32a69aee645267
+  data.tar.gz: c6a17528d17f0cb3de8143a01227b06c7e8e527eee3a7ccc5677b637b7b3c41a
 SHA512:
-  metadata.gz: 9609eac23bd8fd86a94a7f218d1ed613ac6bc8b0b3f231ebdc0a9f90fe21653170eb996def584b6bd9cf448f9e8f4f8e78c0092fe505c542737cb7c329422711
-  data.tar.gz: 0b4f5c6f0ad8939f62964b72d0fbf10f7aab52108e9de956888b9f038a997d9f6aa458c63ee4e83990fb767157b61ab0fb2a6401b77bcb821355660c11b1f591
+  metadata.gz: 5ade0c96554bc2670317108bb74851ccfd485cf4932709eafe479de937db7fab43c864a8372d895b99d774cebe6bb08520191e5015ca4ef38eb1a85a19f3d8f4
+  data.tar.gz: ca421f4b2fa6fd74c319bab2eb739203391f3c71d0fcd592e78018a62900e72edfcc838e7480e1d2a80af1256266c9863e014ec2873f6e8169e1a52dfbe8d1c8

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [0.5.0] - 2024-03-18
+- [BREAK] rename and move `FiscalYear::Half.normalize_year_by_month` to `FiscalYear.increase_year_by_month`
+- add `FiscalYear.decrease_year_by_month` method
+
+when year normalize, we may want to increase year or decrease year depending on the situation.
+therefore, rename and add decrease method.
+
 ## [0.4.0] - 2023-06-15
 - fix calculate logic of half year to date
 

data/lib/fiscal_year/half.rb

@@ -32,7 +32,7 @@ module FiscalYear
         end_month = first.last
         raise StandardError if end_month.nil?
 
-        end_year = normalize_year_by_month(year, end_month)
+        end_year = FiscalYear.increase_year_by_month(year, end_month)
 
         Date.parse("#{year}/#{first.first}/01")..Date.parse("#{end_year}/#{end_month}/01").end_of_month
       end
@@ -45,8 +45,8 @@ module FiscalYear
         end_month = second.last
         raise StandardError if first_month.nil? || end_month.nil?
 
-        start_year = normalize_year_by_month(year, first_month)
-        end_year = normalize_year_by_month(year, end_month)
+        start_year = FiscalYear.increase_year_by_month(year, first_month)
+        end_year = FiscalYear.increase_year_by_month(year, end_month)
 
         Date.parse("#{start_year}/#{first_month}/01")..Date.parse("#{end_year}/#{end_month}/01").end_of_month
       end
@@ -55,19 +55,11 @@ module FiscalYear
         month = date.month
         year = date.year
         # if passed crossed year value, normalize to not crossed year value
-        year -= 1 if FiscalYear.cross_year_month?(month)
+        year = FiscalYear.decrease_year_by_month(year, month)
 
         first?(month) ? first_range_by(year) : second_range_by(year)
       end
 
-      def normalize_year_by_month(year, month)
-        if FiscalYear.cross_year_month?(month)
-          year + 1
-        else
-          year
-        end
-      end
-
       def cross_year_in_half?(half)
         FiscalYear.cross_year? && half.any? { |month| month == 12 }
       end

data/lib/fiscal_year/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FiscalYear
-  VERSION = "0.4.0"
+  VERSION = "0.5.0"
 end

data/lib/fiscal_year.rb

@@ -52,5 +52,21 @@ module FiscalYear
       # @type self: singleton(FiscalYear)
       months.in_groups(4)
     end
+
+    def increase_year_by_month(year, month)
+      if FiscalYear.cross_year_month?(month)
+        year + 1
+      else
+        year
+      end
+    end
+
+    def decrease_year_by_month(year, month)
+      if FiscalYear.cross_year_month?(month)
+        year - 1
+      else
+        year
+      end
+    end
   end
 end

data/sig/fiscal_year/half.rbs

@@ -7,7 +7,6 @@ module FiscalYear
     def self.first_range_by: (Integer) -> Range[Date]
     def self.second_range_by: (Integer) -> Range[Date]
     def self.range_by: (Date) -> Range[Date]
-    def self.normalize_year_by_month: (Integer, Integer) -> Integer
     def self.cross_year_in_half?: (Array[Integer]) -> bool
   end
-end
+end

data/sig/fiscal_year.rbs

@@ -10,4 +10,6 @@ module FiscalYear
   def self.cross_year_months: () -> Array[Integer]
   def self.halfs: () -> [Array[Integer], Array[Integer]]
   def self.quarters: () -> [Array[Integer], Array[Integer], Array[Integer], Array[Integer]]
+  def self.increase_year_by_month: (Integer, Integer) -> Integer
+  def self.decrease_year_by_month: (Integer, Integer) -> Integer
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fiscal_year
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Tsubasa Kawajiri
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-06-15 00:00:00.000000000 Z
+date: 2024-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport