firstgiving 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,15 @@
 ---
-SHA1:
-  metadata.gz: 6a6851db81358b18da79f91eddc7d506c891ac2f
-  data.tar.gz: ebda58663a88fad10c5274b5633519c3aca1b132
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    ZTBmYmNjYzNmNGMwODhjN2QzMTE1ZWIyZjU4MGIyYmRhMGM4ZmRiOA==
+  data.tar.gz: !binary |-
+    NmNhYTY2YTA5OGY4ZWQxZTIzZmMwNmFiMDMwNzQzNjllNTM5ZGQ1ZQ==
 SHA512:
-  metadata.gz: 4c66bc3913b0dcedc174fd58a6699f7263c029b5c1aa99da25fb3d4aae1568c2f9eb8fb00d47343c415253087caef84cfdffe1ac104716905dfd2443340ba4dd
-  data.tar.gz: 62d3afb72ee953eeba799b0584ffd8c6cea06d0b0c4ea6d6add7be675c4886a1ba2ef82ad17f84b9e53c71ddefb4ecb16bd6245e55b9217726219587247f4bbf
+  metadata.gz: !binary |-
+    MjM2NjBjMDQ4ZDkzOTc3MGYyNzg5MDcxZTEzNjNjM2IxODJmMzk0N2ZiMjFi
+    NTNlZTRmZjM1YzVkMzQ1NDNhMzIzOWQzZWNlYjA1ZjA2YzBiMmIzMTAyM2Ri
+    NjU4ZDE4NzZmOWM2MGU5ZDMxMTQ5NDhkNGI0ZWM4OGViOTc0MTE=
+  data.tar.gz: !binary |-
+    ZWY4YjNlMTZkMjQ5NzRmNGFiYjc2NGMzZmI0MzM5MWU1NjMwZTQzYTU2ODUw
+    MTYwNDM4ZDBlYzg4Y2QwM2FiZTBjODAwMTg2YTljM2I0MWY1MTZhNDQyNGVm
+    MGVkYTc0ZDJhYTI0YjJiNjllMDU3YTFjZGE1ZTcyMGQ1MThkOTQ=

data/.gitignore

@@ -15,3 +15,4 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+.rubocop.yml

data/firstgiving.gemspec

@@ -4,24 +4,24 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'firstgiving/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "firstgiving"
+  spec.name          = 'firstgiving'
   spec.version       = FirstGiving::VERSION
-  spec.authors       = ["Faizal Zakaria"]
-  spec.email         = ["phaibusiness@gmail.com"]
-  spec.description   = %q{FirstGiving Ruby API client}
-  spec.summary       = %q{FirstGiving API client}
-  spec.homepage      = "https://github.com/boosterllc/firstgiving_ruby"
-  spec.license       = "MIT"
+  spec.authors       = ['Faizal Zakaria']
+  spec.email         = ['phaibusiness@gmail.com']
+  spec.description   = %q(FirstGiving Ruby API client)
+  spec.summary       = %q(FirstGiving API client)
+  spec.homepage      = 'https://github.com/boosterllc/firstgiving_ruby'
+  spec.license       = 'MIT'
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec"
-  spec.add_development_dependency "json"
-  spec.add_development_dependency "crack"
-  spec.add_development_dependency "faraday"
+  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec'
+  spec.add_development_dependency 'json'
+  spec.add_development_dependency 'crack'
+  spec.add_development_dependency 'faraday'
 end

data/lib/firstgiving.rb

@@ -10,7 +10,6 @@ require 'firstgiving/search'
 # Search API
 
 module FirstGiving
-
   class Configuration
     attr_accessor :application_key, :security_token, :options
 
@@ -22,10 +21,10 @@ module FirstGiving
     end
 
     def set_defaults
-      self.options[:verbose] ||= false
-      self.options[:read_timeout] ||= 30
-      self.options[:use_ssl] ||= false
-      self.options[:use_staging] ||= true
+      options[:verbose] ||= false
+      options[:read_timeout] ||= 30
+      options[:use_ssl] ||= false
+      options[:use_staging] ||= true
     end
   end
 
@@ -48,7 +47,6 @@ module FirstGiving
   def self.donation
     @donation ||= Donation.new
   end
-
 end
 
 FG = FirstGiving

data/lib/firstgiving/base.rb

@@ -1,12 +1,10 @@
 require 'faraday'
 
 module FirstGiving
-
   module Base
-
-    DONATION_SANDBOX_ENDPOINT    = "http://usapisandbox.fgdev.net"
-    DONATION_PRODUCTION_ENDPOINT = "https://api.firstgiving.com"
-    SEARCH_ENDPOINT = "http://graphapi.firstgiving.com"
+    DONATION_SANDBOX_ENDPOINT    = 'http://usapisandbox.fgdev.net'
+    DONATION_PRODUCTION_ENDPOINT = 'https://api.firstgiving.com'
+    SEARCH_ENDPOINT = 'http://graphapi.firstgiving.com'
 
     def headers_json
       {
@@ -23,12 +21,12 @@ module FirstGiving
     end
 
     def post_call(api_endpoint, action, params, headers)
-      conn = Faraday.new(:url => api_endpoint) do |faraday|
+      conn = Faraday.new(url: api_endpoint) do |faraday|
         faraday.request  :url_encoded
         faraday.adapter  Faraday.default_adapter
       end
 
-      response = conn.post do |req|
+      conn.post do |req|
         req.url action
         req.params = params
         req.headers = headers
@@ -36,12 +34,12 @@ module FirstGiving
     end
 
     def get_call(api_endpoint, action, params, headers)
-      conn = Faraday.new(:url => api_endpoint) do |faraday|
+      conn = Faraday.new(url: api_endpoint) do |faraday|
         faraday.request  :url_encoded             # form-encode POST params
         faraday.adapter  Faraday.default_adapter  # make requests with Net::HTTP
       end
 
-      response = conn.get do |req|
+      conn.get do |req|
         req.url action
         req.params = params
         req.headers = headers
@@ -51,7 +49,5 @@ module FirstGiving
     def logging(msg)
       puts "[FG-LOG] #{msg}" if FirstGiving.configuration.options[:verbose]
     end
-
   end
 end
-

data/lib/firstgiving/donation.rb

@@ -1,15 +1,13 @@
 require 'crack'
 
 module FirstGiving
-
   class Donation
-
     include Base
 
     module Actions
-      CREDITCARD = "/donation/creditcard"
-      RECURRING_CREDITCARD_PROFILE = "/donation/recurringcreditcardprofile"
-      VERIFY = "/verify"
+      CREDITCARD = '/donation/creditcard'
+      RECURRING_CREDITCARD_PROFILE = '/donation/recurringcreditcardprofile'
+      VERIFY = '/verify'
     end
 
     def initialize
@@ -39,6 +37,4 @@ module FirstGiving
       Crack::XML.parse(body)
     end
   end
-
 end
-

data/lib/firstgiving/lookup.rb

@@ -2,14 +2,12 @@ require 'crack'
 # lookup API
 
 module FirstGiving
-
   class Lookup
-
     include Base
 
     module Actions
-      TRANSACTION_LIST = "/transaction/list"
-      TRANSACTION_DETAIL = "/transaction/detail"
+      TRANSACTION_LIST = '/transaction/list'
+      TRANSACTION_DETAIL = '/transaction/detail'
     end
 
     def initialize
@@ -38,5 +36,4 @@ module FirstGiving
       Crack::XML.parse(body)
     end
   end
-
 end

data/lib/firstgiving/search.rb

@@ -3,13 +3,11 @@ require 'json'
 # Search API
 
 module FirstGiving
-
   class Search
-
     include Base
 
     module Actions
-      LIST_ORGANIZATION = "/v1/list/organization"
+      LIST_ORGANIZATION = '/v1/list/organization'
     end
 
     def initialize
@@ -17,7 +15,7 @@ module FirstGiving
     end
 
     def headers
-      {'Accept' => 'application/json'}
+      { 'Accept' => 'application/json' }
     end
 
     def query(params)
@@ -30,5 +28,4 @@ module FirstGiving
       response['payload']
     end
   end
-
 end

data/lib/firstgiving/version.rb

@@ -1,3 +1,3 @@
 module FirstGiving
-  VERSION = "1.0.0"
+  VERSION = '1.0.1'
 end

data/spec/first_giving_spec.rb

@@ -2,11 +2,11 @@ require 'spec_helper'
 
 describe FirstGiving do
 
-  APPLICATION_KEY = "ADD YOUR APP KEY HERE"
-  SECURITY_TOKEN  = "ADD YOUR SECURITY TOKEN HERE"
+  APPLICATION_KEY = ''
+  SECURITY_TOKEN  = ''
 
   OPTIONS = {
-    :use_staging => true
+    use_staging: true
   }
 
   FirstGiving.configure do |config|
@@ -15,73 +15,75 @@ describe FirstGiving do
     config.options = OPTIONS
   end
 
-  @transacionId = "a-a8ca75adcda6874abd9c5b"
+  raise 'Set your APPLICATION_KEY and SECURITY_TOKEN' if APPLICATION_KEY.empty? || SECURITY_TOKEN.empty?
 
-  describe "Test Donation API" do
+  @transaction_id = 'a-a8ca75adcda6874abd9c5b'
 
-    it "should donate" do
+  describe 'Test Donation API' do
+
+    it 'should donate' do
       params = {
-        :ccNumber            => "4457010000000009",
-        :ccType              => "VI",
-        :ccExpDateMonth      => "01",
-        :ccExpDateYear       => "14",
-        :billToAddressLine1  => "1 Main St.",
-        :billToCity          => "Burlington",
-        :billToState         => "MA",
-        :billToZip           => "01803",
-        :remoteAddr          => "120.138.91.2",
-        :amount              => "10.00",
-        :currencyCode        => "USD",
-        :charityId           => "1234",
-        :description         => "Test transaction",
-        :ccCardValidationNum => "349",
-        :billToFirstName     => "Smith",
-        :billToLastName      => "John",
-        :billToCountry       => "US",
-        :billToEmail         => "test@example.com"
+        ccNumber: '4457010000000009',
+        ccType: 'VI',
+        ccExpDateMonth: '01',
+        ccExpDateYear: '2020',
+        billToAddressLine1: '1 Main St.',
+        billToCity: 'Burlington',
+        billToState: 'MA',
+        billToZip: '01803',
+        remoteAddr: '120.138.91.2',
+        amount: '10.00',
+        currencyCode: 'USD',
+        charityId: '1234',
+        description: 'Test transaction',
+        ccCardValidationNum: '349',
+        billToFirstName: 'Smith',
+        billToLastName: 'John',
+        billToCountry: 'US',
+        billToEmail: 'test@example.com'
       }
 
       response = FG.donation.creditcard(params)
       ## Response should success
       assert_acknowledgement(response)
       ## Response should contain transaction ID
-      @transactionId = response["firstGivingDonationApi"]["firstGivingResponse"]["transactionId"]
-      @transactionId.should_not be_nil
+      @transaction_id = response['firstGivingDonationApi']['firstGivingResponse']['transactionId']
+      @transaction_id.should_not be_nil
     end
 
-    it "should verify" do
+    it 'should verify' do
       params = {
-        :message   => "value1",
-        :signature => "value2"
+        message: 'value1',
+        signature: 'value2'
       }
 
       response = FG.donation.verify(params)
       ## Response should return the same message and signature
-      response["firstGivingDonationApi"]["firstGivingResponse"]["signature"] == "value2"
-      response["firstGivingDonationApi"]["firstGivingResponse"]["message"] == "value1"
+      response['firstGivingDonationApi']['firstGivingResponse']['signature'] == 'value2'
+      response['firstGivingDonationApi']['firstGivingResponse']['message'] == 'value1'
     end
 
-    it "shoould recure the payment" do
+    it 'shoould recure the payment' do
     end
 
   end
 
-  describe "Test Lookup API" do
+  describe 'Test Lookup API' do
 
-    it "should return a list of transactions" do
+    it 'should return a list of transactions' do
       params = {
         page_size: 10,
-        date_from: "1388707200",
-        count: 100,
+        date_from: '1388707200',
+        count: 10,
         page: 1
       }
       resp = FG.lookup.list(params)
       assert_acknowledgement(resp)
     end
 
-    it "should return a transaction detail" do
+    it 'should return a transaction detail' do
       params = {
-        transactionId: "a-0070dde28ca48048a1fc24"
+        transactionId: 'a-0070dde28ca48048a1fc24'
       }
       resp = FG.lookup.detail(params)
       assert_acknowledgement(resp)
@@ -89,53 +91,53 @@ describe FirstGiving do
 
   end
 
-  context "Test Search API" do
+  context 'Test Search API' do
 
-    describe "retrieving a charity by EIN" do
-      it "should return data for charities" do
+    describe 'retrieving a charity by EIN' do
+      it 'should return data for charities' do
         params = {
-          q: "government_id:260046127"
+          q: 'government_id:260046127'
         }
 
         response = FG.search.query(params)
         response.should_not be_nil
-        response[0]["government_id"].should eq "260046127"
+        response[0]['government_id'].should eq '260046127'
       end
     end
 
-    describe "searching for records by organization name" do
-      it "exact name matching and partial or name start" do
+    describe 'searching for records by organization name' do
+      it 'exact name matching and partial or name start' do
         params = {
-          q: "organization_name:humane society"
+          q: 'organization_name:humane society'
         }
 
         response = FG.search.query(params)
         response.should_not be_nil
-        response[0]["organization_name"].should include "HUMANE SOCIETY"
+        response[0]['organization_name'].should include 'HUMANE SOCIETY'
       end
 
-      it "country constraints" do
+      it 'country constraints' do
         params = {
-          q: "organization_name:bat AND country:US"
+          q: 'organization_name:bat AND country:US'
         }
 
         response = FG.search.query(params)
         response.should_not be_nil
-        response[0]["organization_name"].should include "BAT"
-        response[0]["country"].should eq "US"
+        response[0]['organization_name'].should include 'BAT'
+        response[0]['country'].should eq 'US'
       end
 
-      it "pagination" do
+      it 'pagination' do
         params = {
-          q: "organization_name:bat AND country:US",
-          page_size: "10",
+          q: 'organization_name:bat AND country:US',
+          page_size: '10',
           page: 1
         }
 
         response = FG.search.query(params)
         response.should_not be_nil
-        response[0]["organization_name"].should include "BAT"
-        response[0]["country"].should eq "US"
+        response[0]['organization_name'].should include 'BAT'
+        response[0]['country'].should eq 'US'
         response.count.should eq 10
       end
     end
@@ -144,6 +146,6 @@ describe FirstGiving do
   private
 
   def assert_acknowledgement(response)
-    response["firstGivingDonationApi"]["firstGivingResponse"]["acknowledgement"].should eq "Success"
+    response['firstGivingDonationApi']['firstGivingResponse']['acknowledgement'].should eq 'Success'
   end
 end

data/spec/spec_helper.rb

@@ -3,4 +3,3 @@ require 'firstgiving'
 require 'coveralls'
 require 'faraday'
 Coveralls.wear!
-

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: firstgiving
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Faizal Zakaria
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-17 00:00:00.000000000 Z
+date: 2014-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -28,70 +28,70 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: crack
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: FirstGiving Ruby API client
@@ -126,12 +126,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []