first_after_created_at 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5c68bc6c2fd25b8e8646e822183a0684353732dc
-  data.tar.gz: ba8096158884184921139077a615b9c03ce53b67
+  metadata.gz: 205c6fbed97f1fdcd252bac9639c675ff593784c
+  data.tar.gz: 21f6e6be86b437c3fc27d1db0fe44b3dec2036e2
 SHA512:
-  metadata.gz: c4cfbc06f5f302a71fa89bf5ad9ebb33cfe60b79e3e3ff803f9abf4c3c99e555df5f6a7c74fe003f4f59d31570eb542512000179e2a64589a5d86f857c44e3ae
-  data.tar.gz: aeaee80b37b92e2c74705c030adc7ad230f5717b61d1b1629005ca9d5636c64294ce161caa44ba8ac724dbd68f36366087313e7ee13cdd3f31973d5f84325c32
+  metadata.gz: 16291ec36459c4a89cee2adb15036b0765cfd0fd249a234c82ef873680522b2797ddbc57c4dbfce55b5b62a224208cf6cdc84086a2191d842c6fb0b3fc945c84
+  data.tar.gz: 0ab38332154389810490d66150bd791470982d149e79b816377e45f2a520042212e7e33a94be3b7627301fedc9d8ebaaf2120ad17ab1d129b8198f7bc2157f37

data/lib/first_after_created_at/version.rb

@@ -1,3 +1,3 @@
 module FirstAfterCreatedAt
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/first_after_created_at.rb

@@ -1,44 +1,38 @@
 require 'active_record'
 
+# This module extends ActiveRecord::Base to provide the
+# .first_after_created_at(date) and .first_after_id(id) functions
 module FirstAfterCreatedAt
   def first_after_created_at(date)
-    first_id = first.id
-    last_id = last.id
-    jump_size = (last_id - first_id) / 2
-    center = first_after_id(first_id + jump_size)
-    best_distance = 1/0.0
-    new_center = nil
+    first = select(:id, :created_at).first
+    last = select(:id, :created_at).last
+    jump_size = (last.id - first.id) / 2
+    best = _best(last, _best(first, nil, date), date)
+    center = _first_after_id(first.id + jump_size)
+
     while jump_size != 0
-      logger.debug('iterated')
-      new_center =
-        if center.created_at < date
-          # move forward
-          first_after_id(center.id + jump_size)
-        else
-          # move backwards
-          first_after_id(center.id - jump_size)
-        end
-
-
-      distance = new_center.created_at - date
-      if distance == 0
-        return new_center
-      elsif distance > 0 && distance < best_distance
-        best = new_center
-        best_distance = distance
-      end
-
-      break if new_center.id == center.id
+      jump_size /= 2
+      direction = center.created_at < date ? 1 : -1 # moving forward or backward
+      new_center = _first_after_id(center.id + jump_size * direction)
 
-      center = new_center
+      best = _best(new_center, best, date)
 
-      jump_size /= 2
+      center = new_center
     end
 
-    best
+    find(best.id) if best
+  end
+
+  def _best(center, best, date)
+    distance = center.created_at - date
+    if distance >= 0 && (!best || distance < (best.created_at - date))
+      center
+    else
+      best
+    end
   end
 
-  def first_after_id(id)
+  def _first_after_id(id)
     select(:id, :created_at).where('id >= ?', id).order('id asc').first
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: first_after_created_at
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Michael Glass
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-21 00:00:00.000000000 Z
+date: 2017-07-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord