firmenwissen 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 479f8a1bea375d5c4af1c8980981c1fc2f0d4d0bfe7c8b7ac60cf17821b76672
-  data.tar.gz: e4aa6079c3be8d66819ff0d49e8f7c8fef9261c61f4b5353174c4227788593c2
+  metadata.gz: 6adfb097f5362cf6c61da4ab5a1b49501d8bb280c7686a8245478482156b2d5c
+  data.tar.gz: 65a1fc2c1a83192992aff5ed5345b596129e6cb233266f9a39878815833d5a97
 SHA512:
-  metadata.gz: c877c1e82ffde13a74f956d72d94d5b7eb7106e27dabb66e377c40d7983076706a34276be83bb0c325d7fa3dde0b735f5164b62a86666c380e31d20851fb2acb
-  data.tar.gz: '095e5255d2bb6c45cea6151bd5acafeba67fc07fa074db666c56e06c0c7c9748690bded252489748ed23c0f913c038af9e3e6be7a4258e02712735c96f2cbc5e'
+  metadata.gz: f5e6dc634c6a65a9bcb5913b7d854767b89f9378831897044cd36f5792bd451e17dbef4bfb28342e7b64a4c119bee46be78cc69ecab37d643046a96063bda084
+  data.tar.gz: ab9d35487f11cb5d1086d681d931322e17abbc6a55dd3d52017b30db72aa3518d97a6fa41f30990ca7747dd7fde8aefbc995b165a53931d4b6fe450cae022270

data/lib/firmenwissen.rb

@@ -10,6 +10,7 @@ require 'firmenwissen/suggestion'
 require 'firmenwissen/version'
 
 require 'firmenwissen/errors/credentials_error'
+require 'firmenwissen/errors/unprocessable_response_error'
 
 require 'firmenwissen/request/base'
 require 'firmenwissen/request/mock'

data/lib/firmenwissen/errors/unprocessable_response_error.rb

@@ -0,0 +1,7 @@
+module Firmenwissen
+  class UnprocessableResponseError < RuntimeError
+    def initialize(message = 'The response from Firmenwissen could not be processed')
+      super
+    end
+  end
+end

data/lib/firmenwissen/response/base.rb

@@ -1,18 +1,17 @@
 module Firmenwissen
   module Response
     class Base
+      attr_reader :suggestions
+
       def initialize(http_response)
         @http_response = http_response
-      end
-
-      def suggestions
-        @suggestions ||= data.map { |suggestion| Suggestion.new(suggestion) }
+        @suggestions = build_suggestions
       end
 
       def data
-        api_response = JSON.parse(http_response.body).fetch('companyNameSuggestions', [])
-
-        map_response(api_response)
+        @data ||= parsed_response.map { |hash| map_keys(hash) }
+      rescue JSON::ParserError
+        raise UnprocessableResponseError, "The response from Firmenwissen could not be processed:\n#{body}"
       end
 
       def status_code
@@ -27,10 +26,20 @@ module Firmenwissen
 
       attr_reader :http_response
 
-      def map_response(api_response)
-        api_response.map do |hash|
-          KeyMapper.from_api(hash)
-        end
+      def body
+        http_response.body
+      end
+
+      def build_suggestions
+        data.map { |suggestion| Suggestion.new(suggestion) }
+      end
+
+      def map_keys(hash)
+        KeyMapper.from_api(hash)
+      end
+
+      def parsed_response
+        JSON.parse(body).fetch('companyNameSuggestions', [])
       end
     end
   end

data/lib/firmenwissen/response/mock.rb

@@ -5,6 +5,7 @@ module Firmenwissen
         @mock_data = mock_data
         @query = query
         @params = params
+        @suggestions = build_suggestions
 
         raise ArgumentError, 'mock data must either be an array, a hash or respond to `call`' unless mock_data_valid?
       end

data/lib/firmenwissen/version.rb

@@ -1,3 +1,3 @@
 module Firmenwissen
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: firmenwissen
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Gerrit Seger
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-30 00:00:00.000000000 Z
+date: 2017-12-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -93,6 +93,7 @@ files:
 - lib/firmenwissen.rb
 - lib/firmenwissen/configuration.rb
 - lib/firmenwissen/errors/credentials_error.rb
+- lib/firmenwissen/errors/unprocessable_response_error.rb
 - lib/firmenwissen/http_request.rb
 - lib/firmenwissen/key_mapper.rb
 - lib/firmenwissen/request.rb