firefox_zip 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 528aef293150b87023a6d499cd08a33f7e67c9c6
-  data.tar.gz: 9e3c271a67b3205e196b1f3895f54c0bc6389f02
+  metadata.gz: ade035f1d03dcbcb9921977812575da95b04f93a
+  data.tar.gz: dfab4f23fb0d4fd3d3880b7173fdeb8ba5e1e4e6
 SHA512:
-  metadata.gz: 8bb52e59cd61ef65165a35b554530d1fd21cc3ab44d4b410ca37e4fa849864ef887f577aa2b4080af16c58e80c23dbba07300eeb01223cf3ae738b4d6eb3b587
-  data.tar.gz: 3e63ba9ff1a46b6d39d257a81c252ad123653c3a4f27422870a7470555436ea7e6821d307e23faea36eb6c112d6eeb13edd0616d3a12c29f9feedfd3e926b528
+  metadata.gz: 998521c5d0e4f8204f96badb83803fd95cb6c1011f72976dad78c173f6860166171b3d3ae9c68baad487538cfd01570e16c60802b641cc45caacc0ab71f55287
+  data.tar.gz: b142c9980a75e7beec137da7ebfbdfee93fbbe04b1c224f919c9564ea36ab06d3ba898657fb5532edbde8effe0bbb769230b06c471992efe263ef1b826d18048

data/Gemfile.lock

@@ -1,8 +1,9 @@
 PATH
   remote: .
   specs:
-    firefox_zip (0.1.0)
+    firefox_zip (0.2.0)
       rubyzip (~> 1.1)
+      systemu (~> 2.6)
 
 GEM
   remote: https://rubygems.org/
@@ -22,6 +23,7 @@ GEM
       rspec-support (~> 3.1.0)
     rspec-support (3.1.2)
     rubyzip (1.1.6)
+    systemu (2.6.4)
 
 PLATFORMS
   ruby

data/README.md

@@ -19,7 +19,7 @@ $ bundle install
 ```rb
 require 'firefox_zip'
 
-app = FirefoxZip.analyze('/path/to/firefox_app.zip')
+app = FirefoxZip.analyze('/path/to/firefox_app.zip', valid: true) # valid default false
 
 app.name           # [String] app name
 app.description    # [String] app description
@@ -37,5 +37,8 @@ app.size           # [Fixnum] app zip file size
 app.to_hash        # [Hash] app info to hash
 ```
 
+## Validation
+Use [app-validator](https://github.com/mozilla/app-validator) tool.
+
 ## License
 MIT

data/firefox_zip.gemspec

@@ -17,6 +17,7 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
 
   s.add_runtime_dependency 'rubyzip', '~> 1.1'
+  s.add_runtime_dependency 'systemu', '~> 2.6'
   s.add_development_dependency 'rake', '~> 10.4'
   s.add_development_dependency 'rspec', '~> 3.1'
 end

data/lib/firefox_zip.rb

@@ -1,5 +1,6 @@
 require 'firefox_zip/parses/manifest'
 require 'firefox_zip/files/project'
+require 'firefox_zip/valid'
 
 module FirefoxZip
   class << self
@@ -8,7 +9,9 @@ module FirefoxZip
                 :developer, :locales, :default_locale,
                 :version, :size
 
-    def analyze(file_path)
+    def analyze(file_path, option={})
+      valid = option[:valid] != nil ? option[:valid] : false
+
       @project = Files::Project.new(file_path)
       @name = @project.manifest_data.name
       @description = @project.manifest_data.description
@@ -23,6 +26,8 @@ module FirefoxZip
       @version = @project.manifest_data.version
       @size = @project.size
 
+      FirefoxZip::Valid.run(file_path) if valid
+
       self
     end
 

data/lib/firefox_zip/valid.rb

@@ -0,0 +1,17 @@
+require 'systemu'
+require 'json'
+
+module FirefoxZip
+  class Valid
+    def self.run(zip_file_path)
+      return raise 'not zip file' unless File.exists? zip_file_path
+
+      status, stdout, stderr = systemu "app-validator #{zip_file_path} -o json"
+
+      raise 'Not run validation error' if status.exitstatus != 0
+      result = JSON.parse(stdout)
+
+      raise "Validation error: #{result['message']}" if result['errors'] != 0
+    end
+  end
+end

data/lib/firefox_zip/version.rb

@@ -1,3 +1,3 @@
 module FirefoxZip
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/spec/firefox_zip/valid_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe FirefoxZip::Valid do
+  context 'self.run' do
+    before do
+      @status, stdout, stderr = systemu 'app-validator --help'
+    end
+
+    it 'success' do
+      expect { FirefoxZip::Valid.run(File.expand_path('../../test_files/package.zip', __FILE__)) }.not_to raise_error if @status.exitstatus == 0
+    end
+
+    it 'error' do
+      expect { FirefoxZip::Valid.run(File.expand_path('../../test_files/error_package.zip', __FILE__)) }.to raise_error if @status.exitstatus == 0
+    end
+  end
+
+end

data/spec/firefox_zip_spec.rb

@@ -70,4 +70,18 @@ describe FirefoxZip do
       expect{ FirefoxZip.analyze('') }.to raise_error
     end
   end
+
+  context 'self.analyze valid false' do
+    before do
+      @status, stdout, stderr = systemu 'app-validator --help'
+    end
+
+    it 'not raise error' do
+      expect { FirefoxZip.analyze(File.expand_path('../test_files/error_package.zip', __FILE__)) }.not_to raise_error if @status.exitstatus == 0
+    end
+
+    it 'raise error' do
+      expect { FirefoxZip.analyze(File.expand_path('../test_files/error_package.zip', __FILE__), valid: true) }.to raise_error if @status.exitstatus == 0
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: firefox_zip
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - henteko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-02 00:00:00.000000000 Z
+date: 2015-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubyzip
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.1'
+- !ruby/object:Gem::Dependency
+  name: systemu
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.6'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -70,11 +84,14 @@ files:
 - lib/firefox_zip.rb
 - lib/firefox_zip/files/project.rb
 - lib/firefox_zip/parses/manifest.rb
+- lib/firefox_zip/valid.rb
 - lib/firefox_zip/version.rb
 - spec/firefox_zip/files/project_spec.rb
 - spec/firefox_zip/parses/manifest_spec.rb
+- spec/firefox_zip/valid_spec.rb
 - spec/firefox_zip_spec.rb
 - spec/spec_helper.rb
+- spec/test_files/error_package.zip
 - spec/test_files/manifest.webapp
 - spec/test_files/package.zip
 homepage: https://github.com/henteko/firefox_zip
@@ -104,7 +121,9 @@ summary: Firefox os app analyzer
 test_files:
 - spec/firefox_zip/files/project_spec.rb
 - spec/firefox_zip/parses/manifest_spec.rb
+- spec/firefox_zip/valid_spec.rb
 - spec/firefox_zip_spec.rb
 - spec/spec_helper.rb
+- spec/test_files/error_package.zip
 - spec/test_files/manifest.webapp
 - spec/test_files/package.zip