firebase-admin 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e89fa65facd66a7e21d693667661a8606669580f70d8c538a21fe08a3ef8cff0
-  data.tar.gz: 27ca309672952d220435693027320e58497055345054a80a6ae41b6a2b541707
+  metadata.gz: 1e0160923e857a6f2bb9010287cdc66fc7f7b06f10ed9644a13d8423f06ed417
+  data.tar.gz: 469ed074842e19e352ec98c0e1232c85eed7dd56464e33a7b7669f6a7e35c619
 SHA512:
-  metadata.gz: 7f0b56ee6d005dad74eb3bdeae6fbb2b6f6ea3e151e0957690cee98d521348893e74ef179eebe9f67e08c9066903aaf79a25a4b8870c979105aa01ed5020800d
-  data.tar.gz: c3a6dc64332ee9b362f2c6399c57f684233b1e697d3ddd14d64f55f77915bebec36309e173049ea6d2150359971de68361dedb219b401870ba24f473297dabff
+  metadata.gz: 634a6bb2e8ccb27851b527859e98460b9fa2b101ff24ec87fbcff5843474529d2fa71f0c20794659ab9938dda3e891cb6c2fda9116ffb00969c0b6ef00e2faf6
+  data.tar.gz: 8eb5c88f3b47ec5f0a8aff837d5c6db40d6ae890a70e39b0cfcb024b6dd443da449a6091dbcbe19091d255870a8edc3fa40240b8c7d5e07be453b8f7f3c97b67

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    firebase-admin (0.1.3)
+    firebase-admin (0.1.4)
       addressable (~> 2.7)
       faraday (~> 1.3)
       faraday_middleware (~> 1.0)

data/lib/firebase-admin/client/accounts.rb

@@ -165,19 +165,39 @@ module FirebaseAdmin
       end
 
       def service_account_email
-        default_credentials.fetch('client_email') { ENV['GOOGLE_CLIENT_EMAIL'] }
+        email = default_credentials.fetch('client_email') { ENV['GOOGLE_CLIENT_EMAIL'] }
+        if email.nil? || email == ''
+          raise InvalidCredentials,
+                "No client email provided via 'GOOGLE_APPLICATION_CREDENTIALS' or 'GOOGLE_CLIENT_EMAIL'"
+        end
+
+        email
       end
 
       def private_key
         key = default_credentials.fetch('private_key') { unescape(ENV['GOOGLE_PRIVATE_KEY']) }
+        if key.nil? || key == ''
+          raise InvalidCredentials,
+                "No private key provided via 'GOOGLE_APPLICATION_CREDENTIALS' or 'GOOGLE_PRIVATE_KEY'"
+        end
+
         OpenSSL::PKey::RSA.new(key)
       end
 
       def default_credentials
-        @default_credentials ||= begin
-          credentials_path = ENV['GOOGLE_APPLICATION_CREDENTIALS']
-          JSON.parse(File.read(credentials_path)) if credentials_path
+        @default_credentials ||= read_default_credentials
+      end
+
+      def read_default_credentials
+        credentials_path = ENV['GOOGLE_APPLICATION_CREDENTIALS']
+        if credentials_path && File.exist?(credentials_path)
+          JSON.parse(File.read(credentials_path))
+        else
+          {}
         end
+      rescue StandardError => e
+        raise InvalidCredentials,
+              "Failed reading credentials from '#{ENV['GOOGLE_APPLICATION_CREDENTIALS']}'. Error: #{e.message}"
       end
     end
   end

data/lib/firebase-admin/error.rb

@@ -25,4 +25,7 @@ module FirebaseAdmin
 
   # Raised when Firebase returns the HTTP status code 429
   class RateLimitExceeded < Error; end
+
+  # Raised when no valid credentials are found
+  class InvalidCredentials < Error; end
 end

data/lib/firebase-admin/version.rb

@@ -1,3 +1,3 @@
 module FirebaseAdmin
-  VERSION = '0.1.3'.freeze unless defined?(::FirebaseAdmin::VERSION)
+  VERSION = '0.1.4'.freeze unless defined?(::FirebaseAdmin::VERSION)
 end

data/spec/firebase-admin/client/accounts_spec.rb

@@ -50,11 +50,22 @@ describe FirebaseAdmin::Client do
       end
     end
 
+    context 'when GOOGLE_APPLICATION_CREDENTIALS points to an invalid file' do
+      before do
+        ENV['GOOGLE_APPLICATION_CREDENTIALS'] = fixture('google_credentials_invalid.json').path
+      end
+
+      it 'raises an error' do
+        expect { @client.create_custom_token('user-123') }.to raise_error FirebaseAdmin::InvalidCredentials
+      end
+    end
+
     context 'when credentials are set via GOOGLE_CLIENT_EMAIL / GOOGLE_PRIVATE_KEY' do
       let(:email) { 'example@example.com' }
       let(:private_key) { fixture('example_key').read }
 
       before do
+        ENV['GOOGLE_APPLICATION_CREDENTIALS'] = nil
         ENV['GOOGLE_CLIENT_EMAIL'] = email
         ENV['GOOGLE_PRIVATE_KEY'] = private_key
       end
@@ -65,6 +76,18 @@ describe FirebaseAdmin::Client do
         expect(token_data['uid']).to eq('user-123')
       end
     end
+
+    context 'when no credentials are provided' do
+      before do
+        ENV['GOOGLE_APPLICATION_CREDENTIALS'] = nil
+        ENV['GOOGLE_CLIENT_EMAIL'] = nil
+        ENV['GOOGLE_PRIVATE_KEY'] = nil
+      end
+
+      it 'raises an error' do
+        expect { @client.create_custom_token('user-123') }.to raise_error FirebaseAdmin::InvalidCredentials
+      end
+    end
   end
 
   describe '.sign_in_for_uid' do

data/spec/fixtures/google_credentials_invalid.json

@@ -0,0 +1 @@
+invalid

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: firebase-admin
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Colin Harris
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-31 00:00:00.000000000 Z
+date: 2021-04-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -188,6 +188,7 @@ files:
 - spec/fixtures/example_key
 - spec/fixtures/gateway_timeout.html
 - spec/fixtures/google_credentials.json
+- spec/fixtures/google_credentials_invalid.json
 - spec/fixtures/update_account.json
 - spec/spec_helper.rb
 homepage: https://github.com/col/firebase-admin
@@ -225,5 +226,6 @@ test_files:
 - spec/fixtures/example_key
 - spec/fixtures/gateway_timeout.html
 - spec/fixtures/google_credentials.json
+- spec/fixtures/google_credentials_invalid.json
 - spec/fixtures/update_account.json
 - spec/spec_helper.rb