fio_api 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 13a5ab858a6e9b441eb53773dbe28611e6754bf2
-  data.tar.gz: 9c9d9e3089fdd10c092d3ecfee8c35d17a2fdeb8
+  metadata.gz: 886ed6df6b92f3fda8e544c1a92d409b0d63e771
+  data.tar.gz: 5254de00eeb387619475d8a5fcdb4a9f1e8ebe02
 SHA512:
-  metadata.gz: e19bf77982f36c837797367f617c7a66d2a4ae0ea29fb9888071f4965ff47469c6bdff10983d17fe034d13589ffeb6463ab85464eaaf09b77355f7a51935a9ae
-  data.tar.gz: 56c4ea9d17bb41eb1120998d1bfc7d60853f64c9fecfba7e4ac63b5a291b13bfc4690d424284bcda59cae0eec883fef5920de0fc867d262bfa255a6dacd01ed1
+  metadata.gz: a3d88c90b4e1b54b33c80ceaa85586e0e2455e2943a87600486a428f60bd14ca20c23febfb049d966f7aa9baaf9354d84a28358d3d3b5128556fda9f371adb19
+  data.tar.gz: 8998e7992115cae5c652ed7633439815cc65a4fedf971554f6854520d82bd5bde55cb2577ef739388ab644f07cb56f378e9394249d6351074252b6dd2a704b71

data/README.rdoc

@@ -19,9 +19,14 @@ This gem is a wrapper for Fio bank API.
   list.by_date_range(Date.new(2012,11,05), Date.new(2012,12,26))  # Specify listing condition and fetch request
   list.response                                                   # Return deserialized response
 
+=== Request to get transactions form last request
+  list = FioAPI::List.new
+  list.from_last_fetch
+  list.response
+
 === Request transactions by listing_id and year
   list = FioAPI::List.new
-  list.by_listing_id_and_year("43XC6362ASD", 2012)
+  list.by_listing_id_and_year(1, 2012)
   list.response
 
 === Request to set last request id
@@ -35,10 +40,12 @@ This gem is a wrapper for Fio bank API.
   list.response
 
 === Import domestic payments for authorization
-  domestic = FioAPI::Payments::Domestic.new(***)                  # Create new payment
-  service = FioAPI::Payment.new domestic                          # Pass one payment or array of payments
+  payment = FioAPI::Payments::Domestic.new(:account_from, :currency, :amount, :account_to,
+          :bank_code, :ks, :vs, :ss, :date, :message_for_recipient, :comment)
+  service = FioAPI::Payment.new [payment]                         # Pass one payment or array of payments
   service.import                                                  # Call API
   service.response                                                # Return deserialized response with status code etc.
+  service.success?                                                # => true / false
 
 == Contributing to fio_api
 

data/VERSION

@@ -1 +1 @@
-0.0.6
+0.0.7

data/fio_api.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: fio_api 0.0.6 ruby lib
+# stub: fio_api 0.0.7 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "fio_api".freeze
-  s.version = "0.0.6"
+  s.version = "0.0.7"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Robin Bortlik".freeze, "Adam Martinik".freeze]
-  s.date = "2018-06-04"
+  s.date = "2018-06-06"
   s.description = "API wrapper for FIO bank".freeze
   s.email = "a.martinik@gmail.com".freeze
   s.extra_rdoc_files = [
@@ -58,8 +58,10 @@ Gem::Specification.new do |s|
     "spec/fixtures/vcr_cassettes/from_last_fetch.yml",
     "spec/fixtures/vcr_cassettes/import.yml",
     "spec/fixtures/vcr_cassettes/invalid_import.yml",
+    "spec/fixtures/vcr_cassettes/old_import.yml",
     "spec/fixtures/vcr_cassettes/set_last_fetch_date.yml",
     "spec/fixtures/vcr_cassettes/set_last_fetch_id.yml",
+    "spec/fixtures/vcr_cassettes/wrong_token_import.yml",
     "spec/spec_helper.rb",
     "spec/utils/hash_spec.rb"
   ]

data/lib/base/deserializers/import_response_deserializer.rb

@@ -39,6 +39,7 @@ module FioAPI
     # == Returns:
     #   Status
     def deserialize_import(response_json)
+      return FioAPI::Payments::Status.new(error_code: 500) unless response_json
       FioAPI::Payments::Status.new(
         error_code: response_json.try_path('errorCode').to_i,
         error_message: response_json.try_path('message').to_s,

data/lib/base/payment.rb

@@ -17,6 +17,10 @@ module FioAPI
       self.request
     end
 
+    def success?
+      response.status.error_code.zero?
+    end
+
     private
 
     def headers

data/spec/base/payment_spec.rb

@@ -1,18 +1,20 @@
 require_relative '../spec_helper'
 
 describe FioAPI::Payment do
+  let(:date) { '2018-06-15' }
+  let(:amount) { 100.0 }
   before(:each) do
-    @payment = FioAPI::Payments::Domestic.new(account_from: '11111111', currency: 'CZK', amount: amount, account_to: '22222222', bank_code: '3030', date: '2018-06-15')
+    @payment = FioAPI::Payments::Domestic.new(account_from: '11111111', currency: 'CZK', amount: amount, account_to: '22222222', bank_code: '3030', date: date)
     @service = FioAPI::Payment.new [@payment]
   end
 
   context 'payment with valid data' do
-    let(:amount) { 100.0 }
     it 'should make request' do
       VCR.use_cassette 'import', erb: true do
         expect(@service.import).to be_a HTTParty::Response
         expect(@service.request).to be_a HTTParty::Response
         expect(@service.response).to be_a FioAPI::ImportResponseDeserializer
+        expect(@service.success?).to eq true
       end
     end
 
@@ -21,13 +23,46 @@ describe FioAPI::Payment do
     end
   end
 
-  context 'payment with invalid data' do
+  context 'payment with old payment' do
+    let(:date) { '2018-05-05' }
+    it 'should make request' do
+      VCR.use_cassette 'old_import', erb: true do
+        expect(@service.import).to be_a HTTParty::Response
+        expect(@service.request).to be_a HTTParty::Response
+        expect(@service.response).to be_a FioAPI::ImportResponseDeserializer
+        expect(@service.success?).to eq false
+      end
+    end
+
+    it 'should build path' do
+      expect(@service.path).to eq "/import/?token=#{FioAPI.token}&type=xml"
+    end
+  end
+
+  context 'payment with wrong token' do
+    let(:date) { '2018-05-05' }
+    it 'should make request' do
+      VCR.use_cassette 'wrong_token_import', erb: true do
+        expect(@service.import).to be_a HTTParty::Response
+        expect(@service.request).to be_a HTTParty::Response
+        expect(@service.response).to be_a FioAPI::ImportResponseDeserializer
+        expect(@service.success?).to eq false
+      end
+    end
+
+    it 'should build path' do
+      expect(@service.path).to eq "/import/?token=#{FioAPI.token}&type=xml"
+    end
+  end
+
+  context 'payment with zero amount data' do
     let(:amount) { '' }
     it 'should make request' do
       VCR.use_cassette 'invalid_import', erb: true do
         expect(@service.import).to be_a HTTParty::Response
         expect(@service.request).to be_a HTTParty::Response
         expect(@service.response).to be_a FioAPI::ImportResponseDeserializer
+        expect(@service.success?).to eq false
       end
     end
 

data/spec/fixtures/vcr_cassettes/old_import.yml

@@ -0,0 +1,51 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://www.fio.cz/ib_api/rest/import/?token=<%= FioAPI.token %>&type=xml
+    body:
+      encoding: UTF-8
+      string: "--------------------------YU5IeT1XYDoNHP6A\r\nContent-Disposition:
+        form-data; name=\"file\"; filename=\"fio20180606-86151-1fg6aja\"\r\nContent-Type:
+        application/octet-stream\r\n\r\n<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Import
+        xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xsi:noNamespaceSchemaLocation=\"http://www.fio.cz/schema/importIB.xsd\">\n
+        \ <Orders>\n    <DomesticTransaction>\n      <accountFrom>11111111</accountFrom>\n
+        \     <currency>CZK</currency>\n      <amount>100.0</amount>\n      <accountTo>22222222</accountTo>\n
+        \     <bankCode>3030</bankCode>\n      <ks/>\n      <vs/>\n      <ss/>\n      <date>2018-05-05</date>\n
+        \     <messageForRecipient/>\n      <comment/>\n      <paymentType>431001</paymentType>\n
+        \   </DomesticTransaction>\n  </Orders>\n</Import>\n\r\n--------------------------YU5IeT1XYDoNHP6A--\r\n"
+    headers:
+      Content-Type:
+      - multipart/form-data; boundary=------------------------YU5IeT1XYDoNHP6A
+      Boundary:
+      - "-----------RubyMultipartPost"
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Date:
+      - Wed, 06 Jun 2018 11:14:56 GMT
+      Server:
+      - Apache-Coyote/1.1
+      X-Content-Type-Options:
+      - nosniff
+      X-Xss-Protection:
+      - 1; mode=block
+      Referrer-Policy:
+      - strict-origin-when-cross-origin
+      Content-Type:
+      - application/xml;charset=UTF-8
+      X-Frame-Options:
+      - SAMEORIGIN
+      Strict-Transport-Security:
+      - max-age=31536000
+      Transfer-Encoding:
+      - chunked
+    body:
+      encoding: ASCII-8BIT
+      string: !binary |-
+        PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiIHN0YW5kYWxvbmU9InllcyI/PjxyZXNwb25zZUltcG9ydCB4bWxuczp4c2k9Imh0dHA6Ly93d3cudzMub3JnLzIwMDEvWE1MU2NoZW1hLWluc3RhbmNlIiB4c2k6bm9OYW1lc3BhY2VTY2hlbWFMb2NhdGlvbj0iaHR0cDovL3d3dy5maW8uY3ovc2NoZW1hL3Jlc3BvbnNlSW1wb3J0LnhzZCI+PHJlc3VsdD48ZXJyb3JDb2RlPjE8L2Vycm9yQ29kZT48c3RhdHVzPmVycm9yPC9zdGF0dXM+PHN1bXM+PHN1bSBpZD0iQ1pLIj48c3VtQ3JlZGl0PjA8L3N1bUNyZWRpdD48c3VtRGViZXQ+MTAwLjA8L3N1bURlYmV0Pjwvc3VtPjwvc3Vtcz48L3Jlc3VsdD48b3JkZXJzRGV0YWlscz48ZGV0YWlsIGlkPSIxIj48bWVzc2FnZXM+PG1lc3NhZ2Ugc3RhdHVzPSJlcnJvciIgZXJyb3JDb2RlPSIxNCI+RGF0dW0gcGxhdGJ5IGplIHYgbWludWxvc3RpPC9tZXNzYWdlPjxtZXNzYWdlIHN0YXR1cz0iZXJyb3IiIGVycm9yQ29kZT0iMjciPlogdG9ob3RvIGtvbnRhIG5lbHplIHBvZMOhdmF0IMW+w6FkbsOpIHDFmcOta2F6eS48L21lc3NhZ2U+PG1lc3NhZ2Ugc3RhdHVzPSJlcnJvciIgZXJyb3JDb2RlPSI1NSI+WmFkYW7DqSDEjcOtc2xvIHByb3Rpw7rEjXR1IG5lb2Rwb3bDrWTDoSBwb3Zpbm7DqW11IGZvcm3DoXR1IMSMTkIgYSBOQlMuPC9tZXNzYWdlPjxtZXNzYWdlIHN0YXR1cz0iZXJyb3IiIGVycm9yQ29kZT0iMTA4Ij7EjMOtc2xvIMO6xI10dSBwxZnDrWplbWNlIGplIGlkZW50aWNrw6kgcyDEjcOtc2xlbSDDusSNdHUgcGzDoXRjZS48L21lc3NhZ2U+PG1lc3NhZ2Ugc3RhdHVzPSJ3YXJuaW5nIiBlcnJvckNvZGU9IjE1NyI+VXBvem9ybsSbbsOtOiBwb2TDoXbDoXRlIHBva3luIGsgcGxhdGLEmyB2IG3Em27Emywga3RlcsOhIG5lbsOtIG3Em25vdSB0b2hvdG8gw7rEjXR1LiBaa29udHJvbHVqdGUgcHJvc8OtbSwgemRhIG3DoXRlIHNwcsOhdm7EmyB6dm9sZW5vdSBtxJtudSBWYcWhw60gcGxhdGJ5LjwvbWVzc2FnZT48bWVzc2FnZSBzdGF0dXM9ImVycm9yIiBlcnJvckNvZGU9IjIwMDEiPlZhxaFlIHXFvml2YXRlbHNrw6kgb3Byw6F2bsSbbsOtIG5lcG92b2x1amUgcG9kw6Fuw60gcG9reW51IHogdG9ob3RvIMO6xI10dTwvbWVzc2FnZT48L21lc3NhZ2VzPjwvZGV0YWlsPjwvb3JkZXJzRGV0YWlscz48L3Jlc3BvbnNlSW1wb3J0Pg==
+    http_version:
+  recorded_at: Wed, 06 Jun 2018 11:14:56 GMT
+recorded_with: VCR 4.0.0

data/spec/fixtures/vcr_cassettes/wrong_token_import.yml

@@ -0,0 +1,52 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://www.fio.cz/ib_api/rest/import/?token=somelongtoken&type=xml
+    body:
+      encoding: UTF-8
+      string: "--------------------------UFUFp-y_DGK55ls6\r\nContent-Disposition:
+        form-data; name=\"file\"; filename=\"fio20180606-86327-8ctjzc\"\r\nContent-Type:
+        application/octet-stream\r\n\r\n<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Import
+        xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xsi:noNamespaceSchemaLocation=\"http://www.fio.cz/schema/importIB.xsd\">\n
+        \ <Orders>\n    <DomesticTransaction>\n      <accountFrom>11111111</accountFrom>\n
+        \     <currency>CZK</currency>\n      <amount>100.0</amount>\n      <accountTo>22222222</accountTo>\n
+        \     <bankCode>3030</bankCode>\n      <ks/>\n      <vs/>\n      <ss/>\n      <date>2018-05-05</date>\n
+        \     <messageForRecipient/>\n      <comment/>\n      <paymentType>431001</paymentType>\n
+        \   </DomesticTransaction>\n  </Orders>\n</Import>\n\r\n--------------------------UFUFp-y_DGK55ls6--\r\n"
+    headers:
+      Content-Type:
+      - multipart/form-data; boundary=------------------------UFUFp-y_DGK55ls6
+      Boundary:
+      - "-----------RubyMultipartPost"
+  response:
+    status:
+      code: 500
+      message: Internal Server Error
+    headers:
+      Date:
+      - Wed, 06 Jun 2018 11:16:43 GMT
+      Server:
+      - Apache-Coyote/1.1
+      X-Content-Type-Options:
+      - nosniff
+      X-Xss-Protection:
+      - 1; mode=block
+      Referrer-Policy:
+      - strict-origin-when-cross-origin
+      Content-Type:
+      - text/plain;charset=UTF-8
+      Content-Length:
+      - '1'
+      X-Frame-Options:
+      - SAMEORIGIN
+      Strict-Transport-Security:
+      - max-age=31536000
+      Connection:
+      - close
+    body:
+      encoding: UTF-8
+      string: " "
+    http_version: 
+  recorded_at: Wed, 06 Jun 2018 11:16:43 GMT
+recorded_with: VCR 4.0.0

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fio_api
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Robin Bortlik
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-04 00:00:00.000000000 Z
+date: 2018-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -170,8 +170,10 @@ files:
 - spec/fixtures/vcr_cassettes/from_last_fetch.yml
 - spec/fixtures/vcr_cassettes/import.yml
 - spec/fixtures/vcr_cassettes/invalid_import.yml
+- spec/fixtures/vcr_cassettes/old_import.yml
 - spec/fixtures/vcr_cassettes/set_last_fetch_date.yml
 - spec/fixtures/vcr_cassettes/set_last_fetch_id.yml
+- spec/fixtures/vcr_cassettes/wrong_token_import.yml
 - spec/spec_helper.rb
 - spec/utils/hash_spec.rb
 homepage: http://github.com/14113/fio_api