fintecture 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2b24c5b1997acc13cf4f0921fbf18bfbf1b12a1670f944f275c93656aa8e654e
-  data.tar.gz: 92be2f3475b55a90824f7beb07174180c62bff3bcf83e8882dac9d62222911b8
+  metadata.gz: 9d2e328d5922996c4f88d8bd4931fd0fe10b9e2ded4270918160dbd03a3c9054
+  data.tar.gz: c45cc0c0988156002c75f41f09cdb5584973157131f090d532ed1336c86dc156
 SHA512:
-  metadata.gz: 501e9cd146fb25f86c872c2a1c412f47adbb78f5a225dcb9b65d63133adee30210b6180686625c0c16d6848e6ae962fe587b1ab66bc30e79bbfc60310a2dfb78
-  data.tar.gz: 2ad8a2e141344d1a384beff9592fd8a0fc247e2599a4c058ab0a64aa3a7646762b51d543f14784f915974d0ab84565a98c27474d07b5d12331a19699511bbd54
+  metadata.gz: 250762c82c3e56553028dfbc16a8c5927204720c685440c87d067eae785682f143abde7a9588093ad426f7bc80d57f0fdbedb36587c64bcd638a8c71923168cb
+  data.tar.gz: a8ef6c986acbde371ae675953d0dd26a41d441e661d92097c8bca0d33070fc9f28073ca938c4a7f5d0957f475c1d359b18cc7bec52beb314506c2c0e457468ad

data/README.md

@@ -66,17 +66,29 @@ Fintecture::Authentication.access_token
 payment_attrs = {
     amount: 123,
     currency: 'EUR',
-    order_id: 123,
-    customer_id: 123,
+    communication: 'Thanks Mom!',
     customer_full_name: 'John Doe',
     customer_email: 'john.doe@email.com',
     customer_ip: '127.0.0.1',
     end_to_end_id: '5f78e902907e4209aa8df63659b05d24', # uuid optional
-    redirect_uri: '',
-    origin_uri: ''
+    redirect_uri: 'http://example.com/callback',
+    origin_uri: '',
+    state: 'somestate'
 }
 url = Fintecture::Connect.connect_url_pis payment_attrs
 ```
+Explanation of each field:
+
+* amount: **[mandatory]** The amount of the payment initiation request. Min 1.00 and Max is variable based on bank's policy.
+* currency: **[mandatory]** The currency of the payment initiation request. Currently, only EUR and GBP is supported.
+* communication: **[optional]** A message sent to the beneficiary of the payment and visible on his bank statement. In the context of ecommerce payment collection, the order reference is inputted here (with an optional prefer ex: REF#23444)
+* customer_full_name: **[mandatory]** the full name of the payer
+* customer_email: **[mandatory]** the email of the payer
+* customer_ip: **[mandatory]** the ip address of the payer
+* end_to_end_id: **[optional]** unique id of the payment which is sent to the bank but is invisible to the customer. Max 42 character string.
+* redirect_uri: **[mandatory]** the callback URL to which the customer is redirected after authentication with his bank
+* origin_uri: **[optional]** a  URL to which the customer will be redirected if he wants to exit Fintecture Connect
+* state: **[optional]** A state parameter which is sent back on callback
     
 #### Verify URL parameters
 

data/lib/fintecture/connect.rb

@@ -43,19 +43,27 @@ module Fintecture
       end
 
       def validate_payment_integrity
-        # raise_if_klass_mismatch @payment_attrs, Hash, 'payment_attrs'
+        raise_if_klass_mismatch @payment_attrs, Hash, 'payment_attrs'
 
         error_msg = 'invalid payment payload parameter'
 
         raise "#{error_msg} type" unless %w[pis ais].include? @type
 
-        %w[amount currency order_id customer_id customer_full_name customer_email customer_ip].each do |param|
-          raise "#{error_msg} #{param}" if @payment_attrs[param].nil?
+        raise 'end_to_end_id must be an alphanumeric string' if(@payment_attrs['end_to_end_id'] && !@payment_attrs['end_to_end_id'].match(/^[0-9a-zA-Z]*$/))
+
+        %w[amount currency customer_full_name customer_email customer_ip redirect_uri].each do |param|
+          raise "#{param} is a mandatory field" if @payment_attrs[param].nil?
+        end
+
+        # Check if string
+        %w[communication redirect_uri].each do |param|
+          raise_if_klass_mismatch(@payment_attrs[param], String, param) if(@payment_attrs[param])
         end
+
       end
 
       def validate_post_payment_integrity
-        # raise_if_klass_mismatch @post_payment_attrs, Hash, 'post_payment_attrs'
+        raise_if_klass_mismatch @post_payment_attrs, Hash, 'post_payment_attrs'
 
         %w[s state status session_id customer_id provider].each do |param|
           raise "invalid post payment parameter #{param}" if @post_payment_attrs[param].nil?
@@ -66,12 +74,11 @@ module Fintecture
         attributes = {
             amount: @payment_attrs['amount'],
             currency: @payment_attrs['currency'],
-            communication: @payment_attrs['communication'].to_s,
+            communication: @payment_attrs['communication'],
             end_to_end_id: @payment_attrs['end_to_end_id']
         }
 
         meta = {
-            psu_local_id: @payment_attrs['customer_id'],
             psu_name: @payment_attrs['customer_full_name'],
             psu_email: @payment_attrs['customer_email'],
             psu_ip: @payment_attrs['customer_ip']
@@ -102,7 +109,6 @@ module Fintecture
             signature: build_signature(payload),
             redirect_uri: @payment_attrs['redirect_uri'] || '',
             origin_uri: @payment_attrs['origin_uri'] || '',
-            order_id: @payment_attrs['order_id'],
             state: @payment_attrs['state'],
             payload: payload,
             version: Fintecture::VERSION,
@@ -130,7 +136,11 @@ module Fintecture
       def as_json(element)
           return JSON(element.to_json) if element.is_a? Hash
 
-          return element.as_json
+          begin
+            element.as_json
+          rescue NoMethodError
+            raise "invalid parameter format, the parameter should be a Hash or an Object Model instead a #{element.class.name}"
+          end
       end
     end
   end

data/lib/fintecture/version.rb

@@ -1,3 +1,3 @@
 module Fintecture
-  VERSION = "0.1.5"
+  VERSION = '0.1.6'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fintecture
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Fintecture
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-01-16 00:00:00.000000000 Z
+date: 2020-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler