finstyle 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 37d02430e54744acfe24be81474d9f7a40001b93
-  data.tar.gz: c3801b57d928c15d5b78de5e68355f2b5210d0d1
+  metadata.gz: 84538f975b126cba240de14cd84c5e779af130d2
+  data.tar.gz: 2dd8828b126037fab9cfcd9d9a509a33ce6a05c8
 SHA512:
-  metadata.gz: b7a3b9050dd0ea3cbee1022bd317a62978e0b0a90564cd0302ca3d76a8378f124d6232e651f4b7f9f199c8b507a18c8e243209b0af620c07f0d9d33a6e538568
-  data.tar.gz: fd17b7be5e221a0ab91b8ebadf030d9e62d08e08b653c6bec30ce8c7717bc049707f261079a0929f5e2bc42b1864c5a9250733353a13c21d169cc20be4d72f74
+  metadata.gz: 0000b23989b5942d3793bf9ef4fa31711d051d5d0b8ffdc49590192403496e582d1ba1959ff5b4c9d3efe8698a96bd3d8c9e850a697918d521b30611dd4686e4
+  data.tar.gz: 9025636bf7b8334f60e984f3633597177ab13e61fee82bd5a06d7eb2f4cd7bb5f4591d3ec87b64cd4b4a9364bc4a7a56079440c129e378f45434a886eaa01e1a

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## 1.4.0 / 2014-12-15
+
+### Breaking changes
+
+* Upgrade to RuboCop 0.28.0 support. ([@fnichol][])
+* Removed temporary fixes due to issues in RuboCop 0.27.0 release. ([@fnichol][])
+
+
 ## 1.3.0 / 2014-11-06
 
 ### Breaking changes

data/config/disabled.yml

@@ -23,3 +23,8 @@ Style/SymbolArray:
   Description: 'Use %i or %I for arrays of symbols.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#percent-i'
   Enabled: false
+
+Style/ExtraSpacing:
+  Description: 'Do not use unnecessary spacing.'
+  Enabled: false
+

data/config/enabled.yml

@@ -87,7 +87,7 @@ Style/Blocks:
   Enabled: true
 
 Style/BracesAroundHashParameters:
-  Description: 'Enforce braces style inside hash parameters.'
+  Description: 'Enforce braces style around hash parameters.'
   Enabled: true
 
 Style/CaseEquality:
@@ -181,6 +181,10 @@ Style/ElseAlignment:
   Description: 'Align elses and elsifs correctly.'
   Enabled: true
 
+Style/EmptyElse:
+  Description: 'Avoid empty else-clauses.'
+  Enabled: true
+
 Style/EmptyLineBetweenDefs:
   Description: 'Use empty lines between defs.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#empty-lines-between-methods'
@@ -194,6 +198,10 @@ Style/EmptyLinesAroundAccessModifier:
   Description: "Keep blank lines around access modifiers."
   Enabled: true
 
+Style/EmptyLinesAroundBlockBody:
+  Description: "Keeps track of empty lines around block bodies."
+  Enabled: true
+
 Style/EmptyLinesAroundClassBody:
   Description: "Keeps track of empty lines around class bodies."
   Enabled: true
@@ -271,7 +279,7 @@ Style/IfUnlessModifier:
   Enabled: true
 
 Style/IfWithSemicolon:
-  Description: 'Never use if x; .... Use the ternary operator instead.'
+  Description: 'Do not use if x; .... Use the ternary operator instead.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-semicolon-ifs'
   Enabled: true
 
@@ -352,7 +360,7 @@ Style/MultilineBlockLayout:
   Enabled: true
 
 Style/MultilineIfThen:
-  Description: 'Never use then for multi-line if/unless.'
+  Description: 'Do not use then for multi-line if/unless.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-then'
   Enabled: true
 
@@ -544,7 +552,7 @@ Style/SpaceAfterControlKeyword:
 
 Style/SpaceAfterMethodName:
   Description: >-
-                 Never put a space between a method name and the opening
+                 Do not put a space between a method name and the opening
                  parenthesis in a method definition.
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#parens-no-spaces'
   Enabled: true
@@ -670,7 +678,7 @@ Style/TrivialAccessors:
 
 Style/UnlessElse:
   Description: >-
-                 Never use unless with else. Rewrite these with the positive
+                 Do not use unless with else. Rewrite these with the positive
                  case first.
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-else-with-unless'
   Enabled: true
@@ -742,7 +750,7 @@ Metrics/ClassLength:
 
 Metrics/CyclomaticComplexity:
   Description: >-
-                 A complexity metric that is strongy correlated to the number
+                 A complexity metric that is strongly correlated to the number
                  of test cases needed to validate a method.
   Enabled: true
 
@@ -832,7 +840,7 @@ Lint/EndInMethod:
   Enabled: true
 
 Lint/EnsureReturn:
-  Description: 'Never use return in an ensure block.'
+  Description: 'Do not use return in an ensure block.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-return-ensure'
   Enabled: true
 

data/config/finstyle.yml

@@ -50,6 +50,9 @@ Style/AlignParameters:
 Style/Blocks:
   Enabled: false
 
+BracesAroundHashParameters:
+  EnforcedStyle: context_dependent
+
 # Words help us convey meaning and Ruby aliased methods help with this.
 Style/CollectionMethods:
   PreferredMethods:
@@ -66,14 +69,16 @@ Style/DotPosition:
 Style/EachWithObject:
   Enabled: false
 
-# Temporarily disabled, pending release of Rubocop later than 0.27.0 which
-# includes https://github.com/bbatsov/rubocop/issues/1416 fix
-# @TODO Remove when Rubocop > 0.27.0 is released.
-Style/ElseAlignment:
+# In cases where this has come up, else blocks typically contain an explicit
+# nil value which can reduce certain future return clause bugs
+Style/EmptyElse:
   Enabled: false
 
 # Whitespace between modules/classes/methods can be helpful to read and
 # don't hurt anybody.
+Style/EmptyLinesAroundBlockBody:
+  Enabled: false
+
 Style/EmptyLinesAroundClassBody:
   Enabled: false
 
@@ -141,11 +146,8 @@ Style/SignalException:
 Style/StringLiterals:
   EnforcedStyle: double_quotes
 
-# Temporarily disabled, pending releas of Rubocop later than 0.27.0, which
-# includes https://github.com/bbatsov/rubocop/issues/1415 fix
-# @TODO Remve when Rubocop > 0.27.0 is released.
 Style/StringLiteralsInInterpolation:
-  Enabled: false
+  EnforcedStyle: double_quotes
 
 # Nothing but a single-quoting strings rule in disguise
 Style/UnneededCapitalW:

data/config/upstream.yml

@@ -139,8 +139,16 @@ Style/BarePercentLiterals:
 Style/BracesAroundHashParameters:
   EnforcedStyle: no_braces
   SupportedStyles:
+    # The `braces` style enforces braces around all method parameters that are
+    # hashes.
     - braces
+    # The `no_braces` style checks that the last parameter doesn't have braces
+    # around it.
     - no_braces
+    # The `context_dependent` style checks that the last parameter doesn't have
+    # braces around it, but requires braces if the second to last parameter is
+    # also a hash literal.
+    - context_dependent
 
 # Indentation of `when`.
 Style/CaseIndentation:
@@ -214,6 +222,12 @@ Style/EmptyLineBetweenDefs:
   # need an empty line between them.
   AllowAdjacentOneLineDefs: false
 
+Style/EmptyLinesAroundBlockBody:
+  EnforcedStyle: no_empty_lines
+  SupportedStyles:
+    - empty_lines
+    - no_empty_lines
+
 Style/EmptyLinesAroundClassBody:
   EnforcedStyle: no_empty_lines
   SupportedStyles:
@@ -605,7 +619,7 @@ Rails/Output:
     - config/**/*.rb
     - db/**/*.rb
     - lib/**/*.rb
-    
+
 Rails/ReadWriteAttribute:
   Include:
     - app/models/**/*.rb

data/finstyle.gemspec

@@ -21,7 +21,7 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = ">= 1.9.3"
 
-  spec.add_dependency("rubocop", "0.27.0")
+  spec.add_dependency("rubocop", "0.28.0")
 
   spec.add_development_dependency("bundler", "~> 1.6")
   spec.add_development_dependency("rake", "~> 10.0")

data/lib/finstyle/version.rb

@@ -1,5 +1,5 @@
 # -*- encoding: utf-8 -*-
 
 module Finstyle
-  VERSION = "1.3.0"
+  VERSION = "1.4.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finstyle
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Fletcher Nichol
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-06 00:00:00.000000000 Z
+date: 2014-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.27.0
+        version: 0.28.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.27.0
+        version: 0.28.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement