finnlabs-ci_reporter 1.6.5 → 1.6.6

data/lib/ci/reporter/rspec.rb

@@ -156,15 +156,15 @@ module CI
 
       private
       def description_for(name_or_example)
+        name = "UNKOWN"
         if name_or_example.respond_to?(:full_description)
-          name_or_example.full_description
+          name = name_or_example.full_description
         elsif name_or_example.respond_to?(:metadata)
-          name_or_example.metadata[:example_group][:full_description]
+          name = name_or_example.metadata[:example_group][:full_description]
         elsif name_or_example.respond_to?(:description)
-          name_or_example.description
-        else
-          "UNKNOWN"
+          name = name_or_example.description
         end
+        name.gsub('?', '')
       end
 
       def write_report

data/lib/ci/reporter/version.rb

@@ -1,5 +1,5 @@
 module CI
   module Reporter
-    VERSION = "1.6.5"
+    VERSION = "1.6.6"
   end
 end

data/spec/ci/reporter/rspec_spec.rb

@@ -107,6 +107,28 @@ describe "The RSpec reporter" do
     @fmt.dump_summary(0.1, 1, 0, 0)
   end
 
+  it "should remove dangerous question marks from the name" do
+    group = mock "example group"
+    group.stub!(:description).and_return "group description"
+    example = mock "example"
+    example.stub!(:description).and_return "should do something?"
+
+    @formatter.should_receive(:start)
+    @formatter.should_receive(:example_group_started).with(group)
+    @formatter.should_receive(:example_started).with(example).once
+    @formatter.should_receive(:example_passed).once
+    @formatter.should_receive(:dump_summary)
+    @report_mgr.should_receive(:write_report).and_return do |suite|
+      suite.testcases.last.name.should == "should do something"
+    end
+
+    @fmt.start(2)
+    @fmt.example_group_started(group)
+    @fmt.example_started(example)
+    @fmt.example_passed(example)
+    @fmt.dump_summary(0.1, 1, 0, 0)
+  end
+
   it "should create a test suite with failure in before(:all)" do
     example_group = mock "example group"
     example_group.stub!(:description).and_return "A context"

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: finnlabs-ci_reporter
 version: !ruby/object:Gem::Version 
-  hash: 5
+  hash: 3
   prerelease: 
   segments: 
   - 1
   - 6
-  - 5
-  version: 1.6.5
+  - 6
+  version: 1.6.6
 platform: ruby
 authors: 
 - Nick Sieger