finishing_moves 0.18 → 0.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ea386064f3ddd76587cfc19a0f3fa451bc5df6fe
-  data.tar.gz: 68de87aee88555b846024b4edcbad5a6872c3f64
+  metadata.gz: 8d258c9fa2aa428c334917b3ed6f93e8e753cb22
+  data.tar.gz: 66b42d8c9755e15f7ccd6f0039b688b5a20fea87
 SHA512:
-  metadata.gz: 2577531144756e18069014d715f319e3512e028840ae6a255de0bd0c51816c6714613cfaba67379c08316b36ec3d96266d8625473d2c2b6ebc7ecacbb3ae1ebb
-  data.tar.gz: be79b56034b36aadb87fd36f1a35156134be6aef557d35a14c4d9f6f499d4fe4e9ba68977fe584754797bb73dff61b36bf3f4372d5bd033a576e2d42c9f4e13f
+  metadata.gz: 8dbc5e8995eef233120cf390d4671087d39c1752845c69b988f5354fbe06b2b2b3c0549bc40eb8a62715b3e841907fec01576e9277b9769db814c8a3a995b106
+  data.tar.gz: 4fe766497b240c4f6ad6793133c4bd7e87b32b0315f8978b368c1a511ca1de86a409f9a981ef47ce2bc12310eb7d3c06e7c62adc1861e336c31a9f87f462bc97

data/.travis.yml

@@ -6,9 +6,8 @@ rvm:
   - 2.0.0
   - 2.1.0
   - 2.2.0
-  - 2.2.1
-  - 2.2.2
   - 2.3.0
+  - 2.4.0
   - ruby-head
 
 script: bundle exec rspec spec

data/lib/finishing_moves/array.rb

@@ -14,7 +14,7 @@ class Array
 
   def to_indexed_hash(starting_key = 0)
     raise ArgumentError, "#{starting_key.inspect} is not an integer" unless starting_key.is_a? Integer
-    to_hash_values(starting_key) { |i| i + 1 }
+    to_hash_values(starting_key)
   end
 
   def to_hash_keys(starting_value = 0, &block)

data/lib/finishing_moves/hash.rb

@@ -24,16 +24,4 @@ class Hash
     return self
   end
 
-  # auto-nesting hashes
-  # https://dzone.com/articles/create-nested-hashes-ruby
-  # Goal:
-  #       a = {}
-  #       a[2][1] = 2
-  #       a[2][2][3] = 4
-  #       a[3][1][1][1] = 1
-  def Hash.new_nested_hash
-    Hash.new{ |h,k| h[k] = Hash.new(&h.default_proc) }
-  end
-
-
 end

data/lib/finishing_moves/kernel.rb

@@ -5,8 +5,7 @@ module Kernel
       result = yield
       return ret_val if result.nil?
       result
-    rescue NoMethodError
-    rescue NameError
+    rescue NoMethodError, NameError
       return ret_val
     end
   end

data/lib/finishing_moves/object.rb

@@ -12,11 +12,7 @@ class Object
   alias_method :is_not_an?, :is_not_a?
 
   def same_as(compare)
-    if compare.respond_to? :to_s
-      self.to_s == compare.to_s
-    else
-      raise ArgumentError.new("Cannot compare \"#{self.class.name}\" to \"#{compare.class.name}\", no string conversion")
-    end
+    self.to_s == compare.to_s
   end
   alias_method :same_as?, :same_as
 
@@ -26,10 +22,18 @@ class Object
     name.keyify
   end
 
+  def self.keyify!
+    name.keyify!
+  end
+
   def self.slugify
     name.slugify
   end
 
+  def self.slugify!
+    name.slugify!
+  end
+
   def false?
     return true if self.is_a? FalseClass
     return false

data/lib/finishing_moves/symbol.rb

@@ -1,11 +1,5 @@
 class Symbol
 
-  # TODO
-  # Credit: http://thingsinabucket.com/2015/07/01/three_little_hacks/
-  def ~@
-    -> (o) { o.respond_to?(self) }
-  end
-
   def keyify
     to_s.keyify
   end
@@ -14,4 +8,12 @@ class Symbol
     to_s.slugify
   end
 
+  def keyify!
+    to_s.keyify!
+  end
+
+  def slugify!
+    to_s.slugify!
+  end
+
 end

data/lib/finishing_moves/to_bool.rb

@@ -6,7 +6,7 @@ class String
   end
 end
 
-class Fixnum
+class Integer
   def to_bool
     return true if self == 1
     return false if self == 0

data/lib/finishing_moves/version.rb

@@ -1,3 +1,3 @@
 module FinishingMoves
-  VERSION = "0.18"
+  VERSION = "0.19"
 end

data/provision.sh

@@ -3,7 +3,7 @@
 # Shell user settings.
 USER_NAME=vagrant
 USER_HOME=/home/$USER_NAME
-DEFAULT_RUBY='2.2.2'
+DEFAULT_RUBY='2.4.1'
 
 ###############################################################################
 # Functions

data/spec/kernel_spec.rb

@@ -24,6 +24,7 @@ describe Kernel do
     expect( nil_chain(false) { bogus_variable } ).to equal false
     expect( nil_chain('gotcha!') { bogus_variable } ).to eq 'gotcha!'
     expect( nil_chain('gotcha!') { params[:bogus_key] } ).to eq 'gotcha!'
+    expect( nil_chain('gotcha!') { raise NoMethodError } ).to eq 'gotcha!'
     expect( nil_chain('gotcha!') { params[:foo] } ).to eq 'bar'
 
     # alias

data/spec/numeric_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe "Numeric methods" do
 
-  it "Fixnum#length" do
+  it "Integer#length" do
     expect(1.length).to eq 1
     expect(5.length).to eq 1
     expect(9.length).to eq 1
@@ -12,9 +12,6 @@ describe "Numeric methods" do
     expect(-9000.length).to eq 4
     # alias
     expect(-9000.digits).to eq 4
-  end
-
-  it "Bignum#length" do
     expect(12356469787881584554556.length).to eq 23
     expect(-12356469787881584554556.length).to eq 23
     # alias
@@ -40,7 +37,7 @@ describe "Numeric methods" do
     expect{ -0.9999999999999062.digits }.to raise_error(ArgumentError)
   end
 
-  it "Fixnum#subtract_percent" do
+  it "Integer#subtract_percent" do
     expect(1.subtract_percent(10)).to eq 0.9
     expect(10.subtract_percent(10)).to eq 9.0
     expect(25.subtract_percent(5)).to eq 23.75
@@ -70,16 +67,13 @@ describe "Numeric methods" do
   end
 
 
-  it "Fixnum#add_percent" do
+  it "Integer#add_percent" do
     expect(1.add_percent(10)).to eq 1.1
     expect(10.add_percent(10)).to eq 11.0
     expect(25.add_percent(5)).to eq 26.25
     expect(76.add_percent(40)).to eq 106.4
     expect(76.markup_by_percent(40)).to eq 106.4
     expect(200.markup_by_percent(100)).to eq 400
-  end
-
-  it "Bignum#add_percent" do
     expect(12356469787881584554556.add_percent(10)).to eq 1.3592116766669745e+22
     expect(12356469787881584554556.markup_by_percent(10)).to eq 1.3592116766669745e+22
   end

data/spec/object_spec.rb

@@ -105,5 +105,9 @@ describe Object do
     expect{ :symbol.false_? }.to raise_error(RuntimeError)
   end
 
+end
+
+#############################
 
+class NoStringObject
 end

data/spec/string_spec.rb

@@ -154,36 +154,57 @@ describe String do
     expect("\n\n".newline_to(0)).to eq '00'
     expect("\n\n".newline_to(true)).to eq 'truetrue'
 
+    # should return a modified object, leaving original intact
+    newline = "\n"
+    bar = newline.newline_to(:bar)
+    expect(newline).to eq "\n"
+    expect(bar).to eq 'bar'
+
     expect("Let's play Global Thermonuclear War.\n\r".newline_to).to eq "Let's play Global Thermonuclear War. "
     expect("A strange game.\n\nThe only winning move is not to play.\r\nHow about a nice game of chess?\r".newline_to).
       to eq "A strange game.  The only winning move is not to play. How about a nice game of chess? "
   end
 
+  it "#newline_to!" do
+    var = "\n"
+    var.newline_to! :foo
+    expect(var).to eq 'foo'
+  end
+
+  keyify_sets = [
+    [Integer, :integer],
+    [Math::DomainError, :math_domain_error],
+    ['FooBarBaz', :foo_bar_baz],
+    [:FooBarBaz, :foo_bar_baz],
+    ["Foo-Bar'Baz", :foo_bar_baz],
+    ['(Foo*&Bar!Baz?', :foo_bar_baz],
+    ['1234FooBAR', :foo_bar],
+    ['!@#$Foo0987', :foo0987],
+    ["Bill O'Shea", :bill_o_shea],
+    ["Bill O Shea", :bill_o_shea],
+    ["Bill O   Shea", :bill_o_shea],
+  ]
+
   it '#keyify' do
-    expect(Integer.keyify).to eq :integer
-    expect(Math::DomainError.keyify).to eq :math_domain_error
-    expect('FooBarBaz'.keyify).to eq :foo_bar_baz
-    expect(:FooBarBaz.keyify).to eq :foo_bar_baz
-    expect("Foo-Bar'Baz".keyify).to eq :foo_bar_baz
-    expect('(Foo*&Bar!Baz?'.keyify).to eq :foo_bar_baz
-    expect('1234FooBAR'.keyify).to eq :foo_bar
-    expect('!@#$Foo0987'.keyify).to eq :foo0987
+    keyify_sets.each do |set|
+      inc, out = set
+      expect(inc.keyify).to eq out
+    end
     expect('!@#$%^'.keyify).to eq nil
     expect('12345678'.keyify).to eq nil
-    expect("Bill O'Shea".keyify).to eq :bill_o_shea
-    expect("Bill O Shea".keyify).to eq :bill_o_shea
-    expect("Bill O   Shea".keyify).to eq :bill_o_shea
-
     # make sure we're not performing in place
     str = 'FooBarBaz'
     expect(str.keyify).to eq :foo_bar_baz
     expect(str).to eq 'FooBarBaz'
-
     # should work on frozen values
     expect('FooBarBaz'.freeze.keyify).to eq :foo_bar_baz
   end
 
   it '#keyify!' do
+    keyify_sets.each do |set|
+      inc, out = set
+      expect(inc.keyify!).to eq out
+    end
     expect{ '!@#$%^'.keyify! }.to raise_error(ArgumentError)
     expect{ '12345678'.keyify! }.to raise_error(ArgumentError)
   end
@@ -193,19 +214,25 @@ describe String do
     expect('1   2 3 4  5'.dedupe(' ').replace_whitespace('+')).to eq '1+2+3+4+5'
   end
 
+  slugify_sets = [
+    [Integer, 'integer'],
+    [Math::DomainError, 'math-domain-error'],
+    ['FooBarBaz', 'foo-bar-baz'],
+    [:FooBarBaz, 'foo-bar-baz'],
+    ["Foo-Bar'Baz", 'foo-bar-baz'],
+    ['(Foo*&Bar!Baz?', 'foo-bar-baz'],
+    ["Bill O'Shea", 'bill-o-shea'],
+    ["Bill O Shea", 'bill-o-shea'],
+    ["Bill O   Shea", 'bill-o-shea'],
+  ]
+
   it '#slugify' do
-    expect(Integer.slugify).to eq 'integer'
-    expect(Math::DomainError.slugify).to eq 'math-domain-error'
-    expect('FooBarBaz'.slugify).to eq 'foo-bar-baz'
-    expect(:FooBarBaz.slugify).to eq 'foo-bar-baz'
-    expect("Foo-Bar'Baz".slugify).to eq 'foo-bar-baz'
-    expect('(Foo*&Bar!Baz?'.slugify).to eq 'foo-bar-baz'
+    slugify_sets.each do |set|
+      inc, out = set
+      expect(inc.slugify).to eq out
+    end
     expect('!@#$Foo0987'.slugify).to eq 'foo0987'
     expect('!@#$%^'.slugify).to eq nil
-    expect("Bill O'Shea".slugify).to eq 'bill-o-shea'
-    expect("Bill O Shea".slugify).to eq 'bill-o-shea'
-    expect("Bill O   Shea".slugify).to eq 'bill-o-shea'
-
     # make sure we're not performing in place
     str = 'FooBarBaz'
     expect(str.slugify).to eq 'foo-bar-baz'
@@ -221,6 +248,10 @@ describe String do
   end
 
   it '#slugify!' do
+    slugify_sets.each do |set|
+      inc, out = set
+      expect(inc.slugify!).to eq out
+    end
     expect{ '!@#$%^'.slugify! }.to raise_error(ArgumentError)
     expect{ '12345678'.slugify! }.not_to raise_error
   end

data/spec/to_bool_spec.rb

@@ -20,7 +20,7 @@ describe "Boolean typecasting" do
     expect{ "000".to_bool }.to raise_error(ArgumentError)
   end
 
-  it "Fixnum#to_bool" do
+  it "Integer#to_bool" do
     expect(1.to_bool).to eq true
     expect(0.to_bool).to eq false
     expect{ 2.to_bool }.to raise_error(ArgumentError)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: finishing_moves
 version: !ruby/object:Gem::Version
-  version: '0.18'
+  version: '0.19'
 platform: ruby
 authors:
 - Frank Koehl
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-22 00:00:00.000000000 Z
+date: 2017-06-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rb-readline
@@ -135,7 +135,6 @@ files:
 - spec/object_spec.rb
 - spec/spec_helper.rb
 - spec/string_spec.rb
-- spec/symbol_spec.rb
 - spec/to_bool_spec.rb
 homepage: https://github.com/forgecrafted/finishing_moves
 licenses:
@@ -171,5 +170,4 @@ test_files:
 - spec/object_spec.rb
 - spec/spec_helper.rb
 - spec/string_spec.rb
-- spec/symbol_spec.rb
 - spec/to_bool_spec.rb

data/spec/symbol_spec.rb

@@ -1,19 +0,0 @@
-require 'spec_helper'
-
-describe Symbol do
-
-  it "unary respond_to" do
-    a_thing = TestThing.new 'foo bar'
-    expect(a_thing).to eq 'foo bar'
-  end
-
-end
-
-
-class TestThing < String
-
-  def custom_method
-    'it works!'
-  end
-
-end