finishing_moves 0.15 → 0.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e36f55195a69cb9de0d770520eb85dcae3c37e77
-  data.tar.gz: 92a7b57e0cd6e5a3eb589b5b4e67cf997689f1c7
+  metadata.gz: 7a1eb69dc879d8b4af5acecf3fcc1713a7a57b34
+  data.tar.gz: 19530406deb74bd1e5bf75eda64b4700298fef7a
 SHA512:
-  metadata.gz: 42a4403be772317ccec7afadf3b370e7274c0d484de64d536eee85f916b6aa0d8ef853f1753ab7e40828f1dc538b18eb1935e7d9d74ed51bcd554a9e76df3328
-  data.tar.gz: 8dfdc2bf9b947602b28cf8cde6c4b767dbb466711db5193b34ce59ee6b4142bc0cec2663832f91047b20d2e8c993b5a84603030c3d777bcdca9ab8b50a3f7b77
+  metadata.gz: a422ae85c7db779e2b27732c609a69f4abedca3dc5ff4111db1ebdfd205e4a50603bc6861cf83f32ad63d7ee8f04bedc08a379f914647f9b63bfbb706c11be3d
+  data.tar.gz: dbbb324d10de76afb224f9188e2324fbff896ec037514f66bd5da6c51e8bb0131a55de546c3f829c69dbdf32a251795bb42fc57d5b91c3ea1381eab2657106af

data/README.md

@@ -51,7 +51,6 @@ gem install 'finishing_moves'
   - [`String#nl2br`](https://github.com/forgecrafted/finishing_moves/wiki/String#stringnl2br)
   - [`String#numeric?`](https://github.com/forgecrafted/finishing_moves/wiki/String#stringnumeric) :boom:
   - [`String#remove_whitespace`](https://github.com/forgecrafted/finishing_moves/wiki/String#stringremove_whitespace)
-  - [`String#replace_whitespace`](https://github.com/forgecrafted/finishing_moves/wiki/String#stringreplace_whitespace)
   - [`String#strip_all`](https://github.com/forgecrafted/finishing_moves/wiki/String#stringstrip_all) :boom:
 
 *Multi-class logic enhancements*

data/lib/finishing_moves/string.rb

@@ -1,15 +1,7 @@
 class String
 
   def nl2br
-    gsub _nl_gsub_regex, "<br />\n"
-  end
-
-  def newline_to(rep = ' ')
-    gsub _nl_gsub_regex, rep.to_s
-  end
-
-  def newline_to!(rep = ' ')
-    gsub! _nl_gsub_regex, rep.to_s
+    self.gsub(/(?:\n\r?|\r\n?)/, "<br />\n")
   end
 
   def keyify
@@ -73,19 +65,11 @@ class String
     str.each_char { |c| gsub! /#{Regexp.escape c}{2,}/, c }
   end
 
-  def remove_whitespace(_ignored = nil)
-    replace_whitespace('')
-  end
-
-  def remove_whitespace!(_ignored = nil)
-    replace_whitespace!('')
-  end
-
-  def replace_whitespace(replace = '')
+  def remove_whitespace(replace = '')
     gsub /[ ]/, replace
   end
 
-  def replace_whitespace!(replace = '')
+  def remove_whitespace!(replace = '')
     gsub! /[ ]/, replace
   end
 
@@ -102,18 +86,8 @@ class String
     Float(self) != nil rescue false
   end
 
-  # TODO
-  # def each_char_index(&block)
-    # how to return enumerator if no block given?
-    # http://blog.arkency.com/2014/01/ruby-to-enum-for-enumerator/
-  # end
-
   protected
 
-    def _nl_gsub_regex
-      /(?:\n\r?|\r\n?)/
-    end
-
     def _lstrip_all_regex(expr)
       /\A[#{expr}]+/
     end

data/lib/finishing_moves/version.rb

@@ -1,3 +1,3 @@
 module FinishingMoves
-  VERSION = "0.15"
+  VERSION = "0.16"
 end

data/spec/string_spec.rb

@@ -99,9 +99,9 @@ describe String do
     expect(' [  foo ]   '.remove_whitespace).to eq '[foo]'
     expect('   '.remove_whitespace).to eq ''
     expect('. $ ^ { [ ( | ) * + ? \ '.remove_whitespace).to eq '.$^{[(|)*+?\\'
-    expect('a b c d e'.remove_whitespace('+')).to eq 'abcde'
-    expect('a  b c d e'.remove_whitespace('+')).to eq 'abcde'
-    expect('a b c d e'.remove_whitespace('__')).to eq 'abcde'
+    expect('a b c d e'.remove_whitespace('+')).to eq 'a+b+c+d+e'
+    expect('a  b c d e'.remove_whitespace('+')).to eq 'a++b+c+d+e'
+    expect('a b c d e'.remove_whitespace('__')).to eq 'a__b__c__d__e'
   end
 
   it '#remove_whitespace!' do
@@ -110,19 +110,6 @@ describe String do
     expect(str).to eq 'abcde'
   end
 
-  it '#replace_whitespace' do
-    expect('   a b c d     e'.replace_whitespace).to eq 'abcde'
-    expect('a b c d e'.replace_whitespace('+')).to eq 'a+b+c+d+e'
-    expect('a  b c d e'.replace_whitespace('+')).to eq 'a++b+c+d+e'
-    expect('a b c d e'.replace_whitespace('__')).to eq 'a__b__c__d__e'
-  end
-
-  it '#replace_whitespace!' do
-    str = 'a b c d e'
-    str.replace_whitespace!('-')
-    expect(str).to eq 'a-b-c-d-e'
-  end
-
   it '#nl2br' do
     expect("\n".nl2br).to       eq "<br />\n"
     expect("\n\r".nl2br).to     eq "<br />\n"
@@ -138,27 +125,6 @@ describe String do
       to eq "A strange game.<br />\n<br />\nThe only winning move is not to play.<br />\nHow about a nice game of chess?<br />\n"
   end
 
-  it "#newline_to" do
-    expect("\n".newline_to).to       eq " "
-    expect("\n\r".newline_to).to     eq " "
-    expect("\r\n".newline_to).to     eq " "
-    expect("\n\r\n".newline_to).to   eq "  "
-    expect("\r\n\r\n".newline_to).to eq "  "
-    expect("\r\r\n".newline_to).to   eq "  "
-    expect("\r\r".newline_to).to     eq "  "
-    expect("\n\r\r".newline_to).to   eq "  "
-
-    # replacements should end up as strings
-    expect("\n".newline_to(:bar)).to eq 'bar'
-    expect("\n\n".newline_to('+')).to eq '++'
-    expect("\n\n".newline_to(0)).to eq '00'
-    expect("\n\n".newline_to(true)).to eq 'truetrue'
-
-    expect("Let's play Global Thermonuclear War.\n\r".newline_to).to eq "Let's play Global Thermonuclear War. "
-    expect("A strange game.\n\nThe only winning move is not to play.\r\nHow about a nice game of chess?\r".newline_to).
-      to eq "A strange game.  The only winning move is not to play. How about a nice game of chess? "
-  end
-
   it '#keyify' do
     expect(Integer.keyify).to eq :integer
     expect(Math::DomainError.keyify).to eq :math_domain_error
@@ -189,8 +155,7 @@ describe String do
   end
 
   it "dedupe + remove_whitespace" do
-    expect('1   2 3 4  5'.dedupe(' ').remove_whitespace('+')).to eq '12345'
-    expect('1   2 3 4  5'.dedupe(' ').replace_whitespace('+')).to eq '1+2+3+4+5'
+    expect('1   2 3 4  5'.dedupe(' ').remove_whitespace('+')).to eq '1+2+3+4+5'
   end
 
   it '#slugify' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: finishing_moves
 version: !ruby/object:Gem::Version
-  version: '0.15'
+  version: '0.16'
 platform: ruby
 authors:
 - Frank Koehl