finicity 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3bdd449e8495e55c19dba35b84698f9ecdd3881d
-  data.tar.gz: a2d7276438ddb21b0401e5c55cd29763a10975bf
+  metadata.gz: 9b3be7fb06d75de49e424102c9294f0af58ef843
+  data.tar.gz: 34082cab8784ccebff332c8257d4c6223a49aa6a
 SHA512:
-  metadata.gz: 826f60559ea6e003196b151d3a0502482d2af3676f76fe3c237adc3f4456f24ed631d35f37439ef852509d272ae315de32a69db85cea0da9f0e1a30b9d430c01
-  data.tar.gz: 9eebfd4a6f96d929b7981aef2a197c984c18038ec8c680f9495123823820cb446954ce590addc035611d8b7604dc72384108ae4f61ebe1defa9c944183f5dd35
+  metadata.gz: 67a7c6663069a3ee002bc994ff6015cced7f2d3412e7e2ff2b08defe187c3b8c3e77cbf9d0c9bfd913304f1e11063bf1f277d6bedcf86061040300fe93c881b4
+  data.tar.gz: 3157c40b03bde2c3c3922017d4b2857c80f23bd16458c084280b48ea847ba5fc69c7ec3f08c5ddf95a00d6221ace27bf2f76762f2f70250aa56b404f530f32eb

data/README.md

@@ -19,10 +19,10 @@ You can configure the finicity gem with the following initializer
 
 ```Ruby
 Finicity::V1.configure do |config|
-  config.base_url = "https://finicity.com"
-  config.partner_key = "key"
-  config.username = "moneydesktop"
-  config.password = "password"
+  config.base_url = "https://api.finicity.com/aggregation/"
+  config.partner_id = 1
+  config.partner_secret = "1234"
+  config.app_key = "5678"
 end
 ```
 
@@ -42,28 +42,28 @@ will contain a token that is valid for a limited time.
 Creating a session can be done by making a new client and then authenticating
 
 ```Ruby
-client = Finicity::V1::Client.new
+client = Finicity::Client.new
 client.authenticate!
 ```
 
 If you have an existing session, you can re-open your existing session
 
 ```Ruby
-client = Finicity::V1::Client.new("token-123")
+client = Finicity::Client.new("token-123")
 ```
 
 If you have an existing session, and also need to re-open a mfa session,
 you can pass both tokens into the client when you create it
 
 ```Ruby
-client = Finicity::V1::Client.new("token-123", "mfa_session-123")
+client = Finicity::Client.new("token-123", "mfa_session-123")
 ```
 
 Once you have established a session, you can begin to issue commands to the API
 using your finicity client
 
 ```Ruby
-client.get_institutions_by_name("Chase")
+client.get_institutions("Chase")
 ```
 
 TODO: link to docs to list all API commands we support

data/lib/finicity/client.rb

@@ -374,7 +374,13 @@ module Finicity
         error_code = nil
       end
 
-      fail ::Finicity::GenericError.new(error_message, response.status_code, error_code)
+      # Finicity API uses 500 status code, with a 103 code in the body to communicate
+      # that the credentials are invalid.
+      if response.status_code == 500 && error_code == 103
+        fail ::Finicity::InvalidCredentialsError.new(103)
+      else
+        fail ::Finicity::GenericError.new(error_message, response.status_code, error_code)
+      end
     end
 
   end

data/lib/finicity/version.rb

@@ -1,3 +1,3 @@
 module Finicity
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/spec/finicity/client_spec.rb

@@ -22,6 +22,15 @@ describe ::Finicity::Client do
       :content_type => "text/plain"
     )
   }
+  let(:aggregation_error) {
+    instance_double(
+      ::HTTP::Message,
+      :ok? => false,
+      :status_code => 500,
+      :body => '<?xml version="1.0" encoding="UTF-8" standalone="yes"?><error><code>103</code><message>Aggregation error.</message></error>',
+      :content_type => "application/xml"
+    )
+  }
 
   describe "#activate_accounts" do
     context "when the response is successful" do
@@ -222,6 +231,15 @@ describe ::Finicity::Client do
         expect { subject.discover_accounts(123, 1, []) }.to raise_error(::Finicity::GenericError)
       end
     end
+
+    context "when the response is an aggregation error" do
+      it "fails with InvalidCredentials" do
+        allow_any_instance_of(::Finicity::V1::Request::DiscoverAccounts).to(
+          receive(:discover_accounts).and_return(aggregation_error)
+        )
+        expect { subject.discover_accounts(123, 1, []) }.to raise_error(::Finicity::InvalidCredentialsError)
+      end
+    end
   end
 
   describe "#discover_accounts_with_mfa" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finicity
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Moneydesktop
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-10 00:00:00.000000000 Z
+date: 2014-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpclient