fingertips-adyen 0.3.8.20100930.2 → 0.3.8.20101007

data/TODO

@@ -10,5 +10,3 @@
   * adyen-activemerchant
 
 = API
-
-* Add Response#errors which returns validation errors from the SOAP API

data/lib/adyen.rb

@@ -13,7 +13,7 @@ module Adyen
   # Version constant for the Adyen plugin.
   # DO NOT CHANGE THIS VALUE BY HAND. It will be updated automatically by
   # the gem:release rake task.
-  VERSION = "0.3.8.20100930.2"
+  VERSION = "0.3.8.20101007"
 
   # Loads configuration settings from a Hash.
   #

data/lib/adyen/api.rb

@@ -325,7 +325,7 @@ module Adyen
               :psp_reference  => result.text('./payment:pspReference'),
               :result_code    => result.text('./payment:resultCode'),
               :auth_code      => result.text('./payment:authCode'),
-              :refusal_reason => result.text('./payment:refusalReason')
+              :refusal_reason => (invalid_request? ? fault_message : result.text('./payment:refusalReason'))
             }
           end
         end
@@ -399,9 +399,10 @@ module Adyen
 
         def params
           @params ||= xml_querier.xpath('//recurring:listRecurringDetailsResponse/recurring:result') do |result|
-            {
+            details = result.xpath('.//recurring:RecurringDetail')
+            details.empty? ? {} : {
               :creation_date            => DateTime.parse(result.text('./recurring:creationDate')),
-              :details                  => result.xpath('.//recurring:RecurringDetail').map { |node| parse_recurring_detail(node) },
+              :details                  => details.map { |node| parse_recurring_detail(node) },
               :last_known_shopper_email => result.text('./recurring:lastKnownShopperEmail'),
               :shopper_reference        => result.text('./recurring:shopperReference')
             }

data/spec/api_spec.rb

@@ -440,6 +440,11 @@ describe Adyen::API do
           @response.should be_invalid_request
         end
 
+        it "returns the fault message from #refusal_reason" do
+          @response.refusal_reason.should == 'validation 101 Invalid card number'
+          @response.params[:refusal_reason].should == 'validation 101 Invalid card number'
+        end
+
         it "returns creditcard validation errors" do
           [
             ["validation 101 Invalid card number",                           [:number,       'is not a valid creditcard number']],
@@ -676,6 +681,11 @@ describe Adyen::API do
         end
 
         it_should_have_shortcut_methods_for_params_on_the_response
+
+        it "returns an empty hash when there are no details" do
+          stub_net_http(LIST_EMPTY_RESPONSE)
+          @recurring.list.params.should == {}
+        end
       end
 
       describe "disable_request_body" do
@@ -867,6 +877,21 @@ LIST_RESPONSE = <<EOS
 </soap:Envelope>
 EOS
 
+LIST_EMPTY_RESPONSE = <<EOS
+<?xml version="1.0"?>
+<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+  <soap:Body>
+    <ns1:listRecurringDetailsResponse xmlns:ns1="http://recurring.services.adyen.com">
+      <ns1:result>
+        <details xmlns="http://recurring.services.adyen.com"/>
+        <lastKnownShopperEmail xmlns="http://recurring.services.adyen.com" xsi:nil="true"/>
+        <shopperReference xmlns="http://recurring.services.adyen.com" xsi:nil="true"/>
+      </ns1:result>
+    </ns1:listRecurringDetailsResponse>
+  </soap:Body>
+</soap:Envelope>
+EOS
+
 DISABLE_RESPONSE = <<EOS
 <?xml version="1.0"?>
 <soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification 
 name: fingertips-adyen
 version: !ruby/object:Gem::Version 
-  hash: 80403907
+  hash: 40202089
   prerelease: false
   segments: 
   - 0
   - 3
   - 8
-  - 20100930
-  - 2
-  version: 0.3.8.20100930.2
+  - 20101007
+  version: 0.3.8.20101007
 platform: ruby
 authors: 
 - Willem van Bergen
@@ -20,7 +19,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-09-30 00:00:00 +02:00
+date: 2010-10-07 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency