fingertips-adyen 0.3.8.20100930 → 0.3.8.20100930.2

data/adyen.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
-  s.name    = 'adyen'
-  s.version = "0.3.8"
-  s.date    = "2010-09-23"
+  s.name    = 'fingertips-adyen'
+  s.version = "0.3.8.20100929"
+  s.date    = "2010-09-29"
 
   s.summary = "Integrate Adyen payment services in your Ruby on Rails application."
   s.description = <<-EOS
@@ -13,23 +13,22 @@ Gem::Specification.new do |s|
 
   s.authors  = ['Willem van Bergen', 'Michel Barbosa', 'Stefan Borsje', 'Eloy Duran']
   s.email    = ['willem@vanbergen.org', 'cicaboo@gmail.com', 'mail@sborsje.nl', 'eloy.de.enige@gmail.com']
-  s.homepage = 'http://github.com/wvanbergen/adyen/wiki'
+  s.homepage = 'http://wiki.github.com/wvanbergen/adyen'
 
   s.add_development_dependency('rake')
   s.add_development_dependency('rspec', '>= 1.1.4')
+  s.add_development_dependency('git', '>= 1.1.0')
+  s.add_development_dependency('gemcutter')
   
   # Drop or make runtime dependency.
   s.add_development_dependency('activerecord')
-  s.add_development_dependency('handsoap')
   s.add_development_dependency('nokogiri')
 
-  s.requirements << 'Handsoap is required for accessing the SOAP services. See http://github.com/troelskn/handsoap.'
   s.requirements << 'ActiveRecord is required for storing the notifications in your database.'
 
   s.rdoc_options << '--title' << s.name << '--main' << 'README.rdoc' << '--line-numbers' << '--inline-source'
   s.extra_rdoc_files = ['README.rdoc']
 
-  s.files = %w(spec/spec_helper.rb spec/adyen_spec.rb lib/adyen/form.rb .gitignore spec/notification_spec.rb lib/adyen/soap.rb LICENSE spec/soap_spec.rb init.rb adyen.gemspec Rakefile spec/form_spec.rb README.rdoc lib/adyen/notification.rb lib/adyen/formatter.rb tasks/github-gem.rake lib/adyen/encoding.rb TODO lib/adyen/matchers.rb lib/adyen.rb)
-  s.test_files = %w(spec/adyen_spec.rb spec/notification_spec.rb spec/soap_spec.rb spec/form_spec.rb)
+  s.files = %w(spec/spec_helper.rb spec/adyen_spec.rb lib/adyen/form.rb .gitignore spec/notification_spec.rb lib/adyen/api.rb LICENSE spec/api_spec.rb init.rb adyen.gemspec Rakefile spec/form_spec.rb README.rdoc lib/adyen/notification.rb lib/adyen/formatter.rb tasks/github-gem.rake lib/adyen/encoding.rb TODO lib/adyen/matchers.rb lib/adyen.rb)
+  s.test_files = %w(spec/adyen_spec.rb spec/notification_spec.rb spec/api_spec.rb spec/form_spec.rb)
 end
-

data/lib/adyen/api.rb

@@ -44,6 +44,16 @@ module Adyen
     #
 
     class SimpleSOAPClient
+      class ClientError < StandardError
+        def initialize(response, action, endpoint)
+          @response, @action, @endpoint = response, action, endpoint
+        end
+
+        def message
+          "[#{@response.code} #{@response.message}] A client error occurred while calling SOAP action `#{@action}' on endpoint `#{@endpoint}'."
+        end
+      end
+
       # from http://curl.haxx.se/ca/cacert.pem
       CACERT = File.expand_path('../../../support/cacert.pem', __FILE__)
 
@@ -78,7 +88,9 @@ module Adyen
           request.verify_mode = OpenSSL::SSL::VERIFY_PEER
 
           request.start do |http|
-            response_class.new(http.request(post))
+            http_response = http.request(post)
+            raise ClientError.new(http_response, action, endpoint) if http_response.is_a?(Net::HTTPClientError)
+            response_class.new(http_response)
           end
         end
       end

data/lib/adyen.rb

@@ -13,7 +13,7 @@ module Adyen
   # Version constant for the Adyen plugin.
   # DO NOT CHANGE THIS VALUE BY HAND. It will be updated automatically by
   # the gem:release rake task.
-  VERSION = "0.3.8.20100930"
+  VERSION = "0.3.8.20100930.2"
 
   # Loads configuration settings from a Hash.
   #

data/spec/api_spec.rb

@@ -267,6 +267,18 @@ describe Adyen::API do
         @response.should be_instance_of(Adyen::API::Response)
         @response.xml_querier.to_s.should == AUTHORISE_RESPONSE
       end
+
+      it "raises when the HTTP response is a subclass of Net::HTTPClientError" do
+        Net::HTTP.stubbed_response = Net::HTTPBadRequest.new('1.1', '401', 'Bad request')
+        exception = nil
+        begin
+          @client.call_webservice_action('Action', '<bananas>Yes, please</bananas>', Adyen::API::Response)
+        rescue Adyen::API::SimpleSOAPClient::ClientError => e
+          exception = e
+        end
+        msg = "[401 Bad request] A client error occurred while calling SOAP action `Action' on endpoint `https://test.example.com/soap/Action'."
+        exception.message.should == msg
+      end
     end
   end
 

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification 
 name: fingertips-adyen
 version: !ruby/object:Gem::Version 
-  hash: 40201971
+  hash: 80403907
   prerelease: false
   segments: 
   - 0
   - 3
   - 8
   - 20100930
-  version: 0.3.8.20100930
+  - 2
+  version: 0.3.8.20100930.2
 platform: ruby
 authors: 
 - Willem van Bergen