fingertips-adyen 0.3.8.20100929 → 0.3.8.20100930

data/adyen.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
-  s.name    = 'fingertips-adyen'
-  s.version = "0.3.8.20100929"
-  s.date    = "2010-09-29"
+  s.name    = 'adyen'
+  s.version = "0.3.8"
+  s.date    = "2010-09-23"
 
   s.summary = "Integrate Adyen payment services in your Ruby on Rails application."
   s.description = <<-EOS
@@ -13,22 +13,23 @@ Gem::Specification.new do |s|
 
   s.authors  = ['Willem van Bergen', 'Michel Barbosa', 'Stefan Borsje', 'Eloy Duran']
   s.email    = ['willem@vanbergen.org', 'cicaboo@gmail.com', 'mail@sborsje.nl', 'eloy.de.enige@gmail.com']
-  s.homepage = 'http://wiki.github.com/wvanbergen/adyen'
+  s.homepage = 'http://github.com/wvanbergen/adyen/wiki'
 
   s.add_development_dependency('rake')
   s.add_development_dependency('rspec', '>= 1.1.4')
-  s.add_development_dependency('git', '>= 1.1.0')
-  s.add_development_dependency('gemcutter')
   
   # Drop or make runtime dependency.
   s.add_development_dependency('activerecord')
+  s.add_development_dependency('handsoap')
   s.add_development_dependency('nokogiri')
 
+  s.requirements << 'Handsoap is required for accessing the SOAP services. See http://github.com/troelskn/handsoap.'
   s.requirements << 'ActiveRecord is required for storing the notifications in your database.'
 
   s.rdoc_options << '--title' << s.name << '--main' << 'README.rdoc' << '--line-numbers' << '--inline-source'
   s.extra_rdoc_files = ['README.rdoc']
 
-  s.files = %w(spec/spec_helper.rb spec/adyen_spec.rb lib/adyen/form.rb .gitignore spec/notification_spec.rb lib/adyen/api.rb LICENSE spec/api_spec.rb init.rb adyen.gemspec Rakefile spec/form_spec.rb README.rdoc lib/adyen/notification.rb lib/adyen/formatter.rb tasks/github-gem.rake lib/adyen/encoding.rb TODO lib/adyen/matchers.rb lib/adyen.rb)
-  s.test_files = %w(spec/adyen_spec.rb spec/notification_spec.rb spec/api_spec.rb spec/form_spec.rb)
+  s.files = %w(spec/spec_helper.rb spec/adyen_spec.rb lib/adyen/form.rb .gitignore spec/notification_spec.rb lib/adyen/soap.rb LICENSE spec/soap_spec.rb init.rb adyen.gemspec Rakefile spec/form_spec.rb README.rdoc lib/adyen/notification.rb lib/adyen/formatter.rb tasks/github-gem.rake lib/adyen/encoding.rb TODO lib/adyen/matchers.rb lib/adyen.rb)
+  s.test_files = %w(spec/adyen_spec.rb spec/notification_spec.rb spec/soap_spec.rb spec/form_spec.rb)
 end
+

data/lib/adyen/api.rb

@@ -22,16 +22,19 @@ module Adyen
     # Shortcut methods
     #
 
-    def self.authorise_payment(params = {})
+    def self.authorise_payment(params)
       PaymentService.new(params).authorise_payment
     end
 
-    def self.authorise_recurring_payment(params = {})
+    def self.authorise_recurring_payment(params)
       PaymentService.new(params).authorise_recurring_payment
     end
 
-    def self.disable_recurring_contract(params = {})
-      RecurringService.new(params).disable
+    def self.disable_recurring_contract(shopper_reference, recurring_detail_reference = nil)
+      RecurringService.new({
+        :shopper => { :reference => shopper_reference },
+        :recurring_detail_reference => recurring_detail_reference
+      }).disable
     end
 
     # TODO: the rest
@@ -44,8 +47,12 @@ module Adyen
       # from http://curl.haxx.se/ca/cacert.pem
       CACERT = File.expand_path('../../../support/cacert.pem', __FILE__)
 
-      def self.endpoint
-        @endpoint ||= URI.parse(const_get('ENDPOINT_URI') % Adyen.environment)
+      class << self
+        attr_accessor :stubbed_response
+
+        def endpoint
+          @endpoint ||= URI.parse(const_get('ENDPOINT_URI') % Adyen.environment)
+        end
       end
 
       attr_reader :params
@@ -55,19 +62,24 @@ module Adyen
       end
 
       def call_webservice_action(action, data, response_class)
-        endpoint = self.class.endpoint
-
-        post = Net::HTTP::Post.new(endpoint.path, 'Accept' => 'text/xml', 'Content-Type' => 'text/xml; charset=utf-8', 'SOAPAction' => action)
-        post.basic_auth(API.username, API.password)
-        post.body = data
-
-        request = Net::HTTP.new(endpoint.host, endpoint.port)
-        request.use_ssl = true
-        request.ca_file = CACERT
-        request.verify_mode = OpenSSL::SSL::VERIFY_PEER
-
-        request.start do |http|
-          response_class.new(http.request(post))
+        if response = self.class.stubbed_response
+          self.class.stubbed_response = nil
+          response
+        else
+          endpoint = self.class.endpoint
+
+          post = Net::HTTP::Post.new(endpoint.path, 'Accept' => 'text/xml', 'Content-Type' => 'text/xml; charset=utf-8', 'SOAPAction' => action)
+          post.basic_auth(API.username, API.password)
+          post.body = data
+
+          request = Net::HTTP.new(endpoint.host, endpoint.port)
+          request.use_ssl = true
+          request.ca_file = CACERT
+          request.verify_mode = OpenSSL::SSL::VERIFY_PEER
+
+          request.start do |http|
+            response_class.new(http.request(post))
+          end
         end
       end
     end
@@ -179,6 +191,38 @@ module Adyen
     class PaymentService < SimpleSOAPClient
       ENDPOINT_URI = 'https://pal-%s.adyen.com/pal/servlet/soap/Payment'
 
+      class << self
+        def success_stub
+          http_response = Net::HTTPOK.new('1.1', '200', 'OK')
+          def http_response.body; AUTHORISE_RESPONSE; end
+          AuthorizationResponse.new(http_response)
+        end
+
+        def refused_stub
+          http_response = Net::HTTPOK.new('1.1', '200', 'OK')
+          def http_response.body; AUTHORISATION_REFUSED_RESPONSE; end
+          AuthorizationResponse.new(http_response)
+        end
+
+        def invalid_stub
+          http_response = Net::HTTPOK.new('1.1', '200', 'OK')
+          def http_response.body; AUTHORISATION_REQUEST_INVALID_RESPONSE; end
+          AuthorizationResponse.new(http_response)
+        end
+
+        def stub_success!
+          @stubbed_response = success_stub
+        end
+
+        def stub_refused!
+          @stubbed_response = refused_stub
+        end
+
+        def stub_invalid!
+          @stubbed_response = invalid_stub
+        end
+      end
+
       def authorise_payment
         make_payment_request(authorise_payment_request_body)
       end
@@ -255,8 +299,12 @@ module Adyen
           !fault_message.nil?
         end
 
-        def error
-          ERRORS[fault_message] || [:base, fault_message]
+        def error(prefix = nil)
+          if error = ERRORS[fault_message]
+            prefix ? ["#{prefix}_#{error[0]}".to_sym, error[1]] : error
+          else
+            [:base, fault_message]
+          end
         end
 
         def params
@@ -273,7 +321,10 @@ module Adyen
         private
 
         def fault_message
-          @fault_message ||= xml_querier.text('//soap:Fault/faultstring')
+          @fault_message ||= begin
+            message = xml_querier.text('//soap:Fault/faultstring')
+            message unless message.empty?
+          end
         end
       end
     end
@@ -281,6 +332,18 @@ module Adyen
     class RecurringService < SimpleSOAPClient
       ENDPOINT_URI = 'https://pal-%s.adyen.com/pal/servlet/soap/Recurring'
 
+      class << self
+        def disabled_stub
+          http_response = Net::HTTPOK.new('1.1', '200', 'OK')
+          def http_response.body; DISABLE_RESPONSE % DisableResponse::DISABLED_RESPONSES.first; end
+          DisableResponse.new(http_response)
+        end
+
+        def stub_disabled!
+          @stubbed_response = disabled_stub
+        end
+      end
+
       # TODO: rename to list_details and make shortcut method take the only necessary param
       def list
         call_webservice_action('listRecurringDetails', list_request_body, ListResponse)
@@ -304,8 +367,16 @@ module Adyen
       end
 
       class DisableResponse < Response
+        DISABLED_RESPONSES = %w{ [detail-successfully-disabled] [all-details-successfully-disabled] }
+
         response_attrs :response
 
+        def success?
+          super && DISABLED_RESPONSES.include?(params[:response])
+        end
+
+        alias disabled? success?
+
         def params
           @params ||= { :response => xml_querier.text('//recurring:disableResponse/recurring:result/recurring:response') }
         end
@@ -429,6 +500,65 @@ EOS
         :email     => '        <payment:shopperEmail>%s</payment:shopperEmail>',
         :ip        => '        <payment:shopperIP>%s</payment:shopperIP>',
       }
+
+      # Test responses
+
+      AUTHORISE_RESPONSE = <<EOS
+<?xml version="1.0" encoding="UTF-8"?>
+<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+  <soap:Body>
+    <ns1:authoriseResponse xmlns:ns1="http://payment.services.adyen.com">
+      <ns1:paymentResult>
+        <additionalData xmlns="http://payment.services.adyen.com" xsi:nil="true"/>
+        <authCode xmlns="http://payment.services.adyen.com">1234</authCode>
+        <dccAmount xmlns="http://payment.services.adyen.com" xsi:nil="true"/>
+        <dccSignature xmlns="http://payment.services.adyen.com" xsi:nil="true"/>
+        <fraudResult xmlns="http://payment.services.adyen.com" xsi:nil="true"/>
+        <issuerUrl xmlns="http://payment.services.adyen.com" xsi:nil="true"/>
+        <md xmlns="http://payment.services.adyen.com" xsi:nil="true"/>
+        <paRequest xmlns="http://payment.services.adyen.com" xsi:nil="true"/>
+        <pspReference xmlns="http://payment.services.adyen.com">9876543210987654</pspReference>
+        <refusalReason xmlns="http://payment.services.adyen.com" xsi:nil="true"/>
+        <resultCode xmlns="http://payment.services.adyen.com">Authorised</resultCode>
+      </ns1:paymentResult>
+    </ns1:authoriseResponse>
+  </soap:Body>
+</soap:Envelope>
+EOS
+
+      AUTHORISATION_REFUSED_RESPONSE = <<EOS
+<?xml version="1.0" encoding="UTF-8"?>
+<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+  <soap:Body>
+    <ns1:authoriseResponse xmlns:ns1="http://payment.services.adyen.com">
+      <ns1:paymentResult>
+        <additionalData xmlns="http://payment.services.adyen.com" xsi:nil="true"/>
+        <authCode xmlns="http://payment.services.adyen.com">1234</authCode>
+        <dccAmount xmlns="http://payment.services.adyen.com" xsi:nil="true"/>
+        <dccSignature xmlns="http://payment.services.adyen.com" xsi:nil="true"/>
+        <fraudResult xmlns="http://payment.services.adyen.com" xsi:nil="true"/>
+        <issuerUrl xmlns="http://payment.services.adyen.com" xsi:nil="true"/>
+        <md xmlns="http://payment.services.adyen.com" xsi:nil="true"/>
+        <paRequest xmlns="http://payment.services.adyen.com" xsi:nil="true"/>
+        <pspReference xmlns="http://payment.services.adyen.com">9876543210987654</pspReference>
+        <refusalReason xmlns="http://payment.services.adyen.com">You need to actually own money.</refusalReason>
+        <resultCode xmlns="http://payment.services.adyen.com">Refused</resultCode>
+      </ns1:paymentResult>
+    </ns1:authoriseResponse>
+  </soap:Body>
+</soap:Envelope>
+EOS
+
+      AUTHORISATION_REQUEST_INVALID_RESPONSE = <<EOS
+<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+  <soap:Body>
+    <soap:Fault>
+      <faultcode>soap:Server</faultcode>
+      <faultstring>validation 101 Invalid card number</faultstring>
+    </soap:Fault>
+  </soap:Body>
+</soap:Envelope>
+EOS
     end
 
     class RecurringService
@@ -466,6 +596,23 @@ EOS
 
       RECURRING_DETAIL_PARTIAL = <<EOS
         <recurring:recurringDetailReference>%s</recurring:recurringDetailReference>
+EOS
+    
+    # Test responses
+
+      DISABLE_RESPONSE = <<EOS
+<?xml version="1.0"?>
+<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+  <soap:Body>
+    <ns1:disableResponse xmlns:ns1="http://recurring.services.adyen.com">
+      <ns1:result>
+        <response xmlns="http://recurring.services.adyen.com">
+          %s
+        </response>
+      </ns1:result>
+    </ns1:disableResponse>
+  </soap:Body>
+</soap:Envelope>
 EOS
     end
   end

data/lib/adyen.rb

@@ -13,7 +13,7 @@ module Adyen
   # Version constant for the Adyen plugin.
   # DO NOT CHANGE THIS VALUE BY HAND. It will be updated automatically by
   # the gem:release rake task.
-  VERSION = "0.3.8.20100929"
+  VERSION = "0.3.8.20100930"
 
   # Loads configuration settings from a Hash.
   #

data/spec/api_spec.rb

@@ -285,175 +285,193 @@ describe Adyen::API do
       Adyen::API.authorise_recurring_payment(:reference => 'order-id')
     end
 
-    it "performs a `disable recurring contract' request" do
+    it "performs a `disable recurring contract' request for all details" do
       recurring = mock('RecurringService')
-      Adyen::API::RecurringService.should_receive(:new).with(:shopper => { :reference => 'user-id' }).and_return(recurring)
+      Adyen::API::RecurringService.should_receive(:new).
+        with(:shopper => { :reference => 'user-id' }, :recurring_detail_reference => nil).
+          and_return(recurring)
       recurring.should_receive(:disable)
-      Adyen::API.disable_recurring_contract(:shopper => { :reference => 'user-id' })
+      Adyen::API.disable_recurring_contract('user-id')
+    end
+
+    it "performs a `disable recurring contract' request for a specific detail" do
+      recurring = mock('RecurringService')
+      Adyen::API::RecurringService.should_receive(:new).
+        with(:shopper => { :reference => 'user-id' }, :recurring_detail_reference => 'detail-id').
+          and_return(recurring)
+      recurring.should_receive(:disable)
+      Adyen::API.disable_recurring_contract('user-id', 'detail-id')
     end
   end
 
   describe Adyen::API::PaymentService do
-    describe "for a normal payment request" do
-      before do
-        @params = {
-          :reference => 'order-id',
-          :amount => {
-            :currency => 'EUR',
-            :value => '1234',
-          },
-          :shopper => {
-            :email => 's.hopper@example.com',
-            :reference => 'user-id',
-            :ip => '61.294.12.12',
-          },
-          :card => {
-            :expiry_month => 12,
-            :expiry_year => 2012,
-            :holder_name => 'Simon わくわく Hopper',
-            :number => '4444333322221111',
-            :cvc => '737',
-            # Maestro UK/Solo only
-            #:issue_number => ,
-            #:start_month => ,
-            #:start_year => ,
-          }
+    before do
+      @params = {
+        :reference => 'order-id',
+        :amount => {
+          :currency => 'EUR',
+          :value => '1234',
+        },
+        :shopper => {
+          :email => 's.hopper@example.com',
+          :reference => 'user-id',
+          :ip => '61.294.12.12',
+        },
+        :card => {
+          :expiry_month => 12,
+          :expiry_year => 2012,
+          :holder_name => 'Simon わくわく Hopper',
+          :number => '4444333322221111',
+          :cvc => '737',
+          # Maestro UK/Solo only
+          #:issue_number => ,
+          #:start_month => ,
+          #:start_year => ,
         }
-        @payment = Adyen::API::PaymentService.new(@params)
+      }
+      @payment = Adyen::API::PaymentService.new(@params)
+    end
+
+    describe "authorise_payment_request_body" do
+      before :all do
+        @method = :authorise_payment_request_body
       end
 
-      describe "authorise_payment_request_body" do
-        before :all do
-          @method = :authorise_payment_request_body
+      it_should_behave_like "payment requests"
+
+      it "includes the creditcard details" do
+        xpath('./payment:card') do |card|
+          # there's no reason why Nokogiri should escape these characters, but as long as they're correct
+          card.text('./payment:holderName').should == 'Simon わくわく Hopper'
+          card.text('./payment:number').should == '4444333322221111'
+          card.text('./payment:cvc').should == '737'
+          card.text('./payment:expiryMonth').should == '12'
+          card.text('./payment:expiryYear').should == '2012'
         end
+      end
 
-        it_should_behave_like "payment requests"
+      it "formats the creditcard’s expiry month as a two digit number" do
+        @payment.params[:card][:expiry_month] = 6
+        text('./payment:card/payment:expiryMonth').should == '06'
+      end
 
-        it "includes the creditcard details" do
-          xpath('./payment:card') do |card|
-            # there's no reason why Nokogiri should escape these characters, but as long as they're correct
-            card.text('./payment:holderName').should == 'Simon わくわく Hopper'
-            card.text('./payment:number').should == '4444333322221111'
-            card.text('./payment:cvc').should == '737'
-            card.text('./payment:expiryMonth').should == '12'
-            card.text('./payment:expiryYear').should == '2012'
-          end
-        end
+      it "includes the necessary recurring contract info if the `:recurring' param is truthful" do
+        xpath('./payment:recurring/payment:contract').should be_empty
+        @payment.params[:recurring] = true
+        text('./payment:recurring/payment:contract').should == 'RECURRING'
+      end
+    end
+
+    describe "authorise_payment" do
+      before do
+        stub_net_http(AUTHORISE_RESPONSE)
+        @response = @payment.authorise_payment
+        @request, @post = Net::HTTP.posted
+      end
+
+      after do
+        Net::HTTP.stubbing_enabled = false
+      end
 
-        it "formats the creditcard’s expiry month as a two digit number" do
-          @payment.params[:card][:expiry_month] = 6
-          text('./payment:card/payment:expiryMonth').should == '06'
+      it "posts the body generated for the given parameters" do
+        @post.body.should == @payment.authorise_payment_request_body
+      end
+
+      it "posts to the correct SOAP action" do
+        @post.soap_action.should == 'authorise'
+      end
+
+      for_each_xml_backend do
+        it "returns a hash with parsed response details" do
+          @payment.authorise_payment.params.should == {
+            :psp_reference => '9876543210987654',
+            :result_code => 'Authorised',
+            :auth_code => '1234',
+            :refusal_reason => ''
+          }
         end
+      end
 
-        it "includes the necessary recurring contract info if the `:recurring' param is truthful" do
-          xpath('./payment:recurring/payment:contract').should be_empty
-          @payment.params[:recurring] = true
-          text('./payment:recurring/payment:contract').should == 'RECURRING'
+      it_should_have_shortcut_methods_for_params_on_the_response
+
+      describe "with a authorized response" do
+        it "returns that the request was authorised" do
+          @response.should be_success
+          @response.should be_authorized
         end
       end
 
-      describe "authorise_payment" do
+      describe "with a `declined' response" do
         before do
-          stub_net_http(AUTHORISE_RESPONSE)
+          stub_net_http(AUTHORISATION_DECLINED_RESPONSE)
           @response = @payment.authorise_payment
-          @request, @post = Net::HTTP.posted
         end
 
-        after do
-          Net::HTTP.stubbing_enabled = false
+        it "returns that the request was not authorised" do
+          @response.should_not be_success
+          @response.should_not be_authorized
         end
+      end
 
-        it "posts the body generated for the given parameters" do
-          @post.body.should == @payment.authorise_payment_request_body
+      describe "with a `invalid' response" do
+        before do
+          stub_net_http(AUTHORISE_REQUEST_INVALID_RESPONSE % 'validation 101 Invalid card number')
+          @response = @payment.authorise_payment
         end
 
-        it "posts to the correct SOAP action" do
-          @post.soap_action.should == 'authorise'
+        it "returns that the request was not authorised" do
+          @response.should_not be_success
+          @response.should_not be_authorized
         end
 
-        for_each_xml_backend do
-          it "returns a hash with parsed response details" do
-            @payment.authorise_payment.params.should == {
-              :psp_reference => '9876543210987654',
-              :result_code => 'Authorised',
-              :auth_code => '1234',
-              :refusal_reason => ''
-            }
-          end
+        it "it returns that the request was invalid" do
+          @response.should be_invalid_request
         end
 
-        it_should_have_shortcut_methods_for_params_on_the_response
-
-        describe "with a authorized response" do
-          it "returns that the request was authorised" do
-            @response.should be_success
-            @response.should be_authorized
+        it "returns creditcard validation errors" do
+          [
+            ["validation 101 Invalid card number",                           [:number,       'is not a valid creditcard number']],
+            ["validation 103 CVC is not the right length",                   [:cvc,          'is not the right length']],
+            ["validation 128 Card Holder Missing",                           [:holder_name,  'can’t be blank']],
+            ["validation Couldn't parse expiry year",                        [:expiry_year,  'could not be recognized']],
+            ["validation Expiry month should be between 1 and 12 inclusive", [:expiry_month, 'could not be recognized']],
+          ].each do |message, error|
+            response_with_fault_message(message).error.should == error
           end
         end
 
-        describe "with a `declined' response" do
-          before do
-            stub_net_http(AUTHORISATION_DECLINED_RESPONSE)
-            @response = @payment.authorise_payment
-          end
-
-          it "returns that the request was not authorised" do
-            @response.should_not be_success
-            @response.should_not be_authorized
-          end
+        it "returns any other fault messages on `base'" do
+          message = "validation 130 Reference Missing"
+          response_with_fault_message(message).error.should == [:base, message]
         end
 
-        describe "with a `invalid' response" do
-          before do
-            stub_net_http(AUTHORISE_REQUEST_INVALID_RESPONSE % 'validation 101 Invalid card number')
-            @response = @payment.authorise_payment
-          end
-
-          it "returns that the request was not authorised" do
-            @response.should_not be_success
-            @response.should_not be_authorized
-          end
-
-          it "it returns that the request was invalid" do
-            @response.should be_invalid_request
-          end
-
-          it "returns creditcard validation errors" do
-            [
-              ["validation 101 Invalid card number",                           [:number,       'is not a valid creditcard number']],
-              ["validation 103 CVC is not the right length",                   [:cvc,          'is not the right length']],
-              ["validation 128 Card Holder Missing",                           [:holder_name,  'can’t be blank']],
-              ["validation Couldn't parse expiry year",                        [:expiry_year,  'could not be recognized']],
-              ["validation Expiry month should be between 1 and 12 inclusive", [:expiry_month, 'could not be recognized']],
-            ].each do |message, error|
-              response_with_fault_message(message).error.should == error
-            end
-          end
-
-          it "returns any other fault messages on `base'" do
-            message = "validation 130 Reference Missing"
-            response_with_fault_message(message).error.should == [:base, message]
+        it "prepends the error attribute with the given prefix, except for :base" do
+          [
+            ["validation 101 Invalid card number", [:card_number, 'is not a valid creditcard number']],
+            ["validation 130 Reference Missing",   [:base,        "validation 130 Reference Missing"]],
+          ].each do |message, error|
+            response_with_fault_message(message).error(:card).should == error
           end
+        end
 
-          it "returns the original message corresponding to the given attribute and message" do
-            [
-              ["validation 101 Invalid card number",                           [:number,       'is not a valid creditcard number']],
-              ["validation 103 CVC is not the right length",                   [:cvc,          'is not the right length']],
-              ["validation 128 Card Holder Missing",                           [:holder_name,  'can’t be blank']],
-              ["validation Couldn't parse expiry year",                        [:expiry_year,  'could not be recognized']],
-              ["validation Expiry month should be between 1 and 12 inclusive", [:expiry_month, 'could not be recognized']],
-              ["validation 130 Reference Missing",                             [:base,         'validation 130 Reference Missing']],
-            ].each do |expected, attr_and_message|
-              Adyen::API::PaymentService::AuthorizationResponse.original_fault_message_for(*attr_and_message).should == expected
-            end
+        it "returns the original message corresponding to the given attribute and message" do
+          [
+            ["validation 101 Invalid card number",                           [:number,       'is not a valid creditcard number']],
+            ["validation 103 CVC is not the right length",                   [:cvc,          'is not the right length']],
+            ["validation 128 Card Holder Missing",                           [:holder_name,  'can’t be blank']],
+            ["validation Couldn't parse expiry year",                        [:expiry_year,  'could not be recognized']],
+            ["validation Expiry month should be between 1 and 12 inclusive", [:expiry_month, 'could not be recognized']],
+            ["validation 130 Reference Missing",                             [:base,         'validation 130 Reference Missing']],
+          ].each do |expected, attr_and_message|
+            Adyen::API::PaymentService::AuthorizationResponse.original_fault_message_for(*attr_and_message).should == expected
           end
+        end
 
-          private
+        private
 
-          def response_with_fault_message(message)
-            stub_net_http(AUTHORISE_REQUEST_INVALID_RESPONSE % message)
-            @response = @payment.authorise_payment
-          end
+        def response_with_fault_message(message)
+          stub_net_http(AUTHORISE_REQUEST_INVALID_RESPONSE % message)
+          @response = @payment.authorise_payment
         end
       end
 
@@ -520,6 +538,40 @@ describe Adyen::API do
       end
     end
 
+    describe "test helpers that stub responses" do
+      after do
+        Net::HTTP.stubbing_enabled = false
+      end
+
+      it "returns an `authorized' response" do
+        stub_net_http(AUTHORISATION_DECLINED_RESPONSE)
+        Adyen::API::PaymentService.stub_success!
+        @payment.authorise_payment.should be_authorized
+
+        @payment.authorise_payment.should_not be_authorized
+      end
+
+      it "returns a `refused' response" do
+        stub_net_http(AUTHORISE_RESPONSE)
+        Adyen::API::PaymentService.stub_refused!
+        response = @payment.authorise_payment
+        response.should_not be_authorized
+        response.should_not be_invalid_request
+
+        @payment.authorise_payment.should be_authorized
+      end
+
+      it "returns a `invalid request' response" do
+        stub_net_http(AUTHORISE_RESPONSE)
+        Adyen::API::PaymentService.stub_invalid!
+        response = @payment.authorise_payment
+        response.should_not be_authorized
+        response.should be_invalid_request
+
+        @payment.authorise_payment.should be_authorized
+      end
+    end
+
     private
 
     def node_for_current_method
@@ -642,7 +694,7 @@ describe Adyen::API do
 
       describe "disable" do
         before do
-          stub_net_http(DISABLE_RESPONSE)
+          stub_net_http(DISABLE_RESPONSE % '[detail-successfully-disabled]')
           @response = @recurring.disable
           @request, @post = Net::HTTP.posted
         end
@@ -659,6 +711,16 @@ describe Adyen::API do
           @post.soap_action.should == 'disable'
         end
 
+        it "returns whether or not it was disabled" do
+          @response.should be_success
+          @response.should be_disabled
+
+          stub_net_http(DISABLE_RESPONSE % '[all-details-successfully-disabled]')
+          @response = @recurring.disable
+          @response.should be_success
+          @response.should be_disabled
+        end
+
         for_each_xml_backend do
           it "returns a hash with parsed response details" do
             @recurring.disable.params.should == { :response => '[detail-successfully-disabled]' }
@@ -668,6 +730,19 @@ describe Adyen::API do
         it_should_have_shortcut_methods_for_params_on_the_response
       end
     end
+
+    describe "test helpers that stub responses" do
+      after do
+        Net::HTTP.stubbing_enabled = false
+      end
+
+      it "returns a `disabled' response" do
+        stub_net_http(DISABLE_RESPONSE % 'nope')
+        Adyen::API::RecurringService.stub_disabled!
+        @recurring.disable.should be_disabled
+        @recurring.disable.should_not be_disabled
+      end
+    end
   end
 end
 
@@ -787,7 +862,7 @@ DISABLE_RESPONSE = <<EOS
     <ns1:disableResponse xmlns:ns1="http://recurring.services.adyen.com">
       <ns1:result>
         <response xmlns="http://recurring.services.adyen.com">
-          [detail-successfully-disabled]
+          %s
         </response>
       </ns1:result>
     </ns1:disableResponse>

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification 
 name: fingertips-adyen
 version: !ruby/object:Gem::Version 
-  hash: 40201973
+  hash: 40201971
   prerelease: false
   segments: 
   - 0
   - 3
   - 8
-  - 20100929
-  version: 0.3.8.20100929
+  - 20100930
+  version: 0.3.8.20100930
 platform: ruby
 authors: 
 - Willem van Bergen
@@ -19,7 +19,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-09-29 00:00:00 +02:00
+date: 2010-09-30 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency