findex 0.2.1 → 0.2.2

data/.gitignore

@@ -0,0 +1 @@
+pkg

data/README.markdown

@@ -1,22 +1,24 @@
 # Findex #
 
-Findex is a simple collection of Rake tasks that will help you locate missing database indexes in your Rails app. It can also generate migrations and run them, as well as filter by specific column types, names, and tables.
+Findex is a simple collection of Rake tasks that will help you locate missing database indexes in your Rails app.
+It can also generate migrations and run them, as well as filter by specific column types, names, and tables.
 
-**Please note** that Findex designed to find any potentially overlooked indexes. It is not a good practice to index every matching column it returns - that's way too many.
+**Please note** that Findex designed to find any potentially overlooked indexes. It is not a good practice to index every matching column Findex returns -
+that's often overkill.
 
 ## Installation ##
 
 Install Findex as a gem:
 
-	$ gem install findex --source=http://gems.github.com
+	$ gem install findex
 
 You may want to configure it as a gem in environment.rb instead, since you're going to need it in your Rakefile:
 
-	config.gem 'findex', :source => 'http://gemcutter.org'
+	config.gem 'findex'
 
 ... then run:
 
-	rake gems:install
+	$ rake gems:install
 
 Now add it to your projects' Rakefile:
 
@@ -25,9 +27,9 @@ Now add it to your projects' Rakefile:
 	rescue MissingSourceFile
 	end
 
-## Find Missing Indexes ##
+## Usage ##
 
-First, get some instructions:
+Findex is pretty simple to use. To get instructions, try running the Rake task below:
 
 	$ rake db:indexes:help
 	

data/VERSION

@@ -1 +1 @@
-0.2.1
+0.2.2

data/lib/findex/tasks.rb

@@ -61,7 +61,7 @@ namespace :db do
     end
 
     desc 'Generates a migration file with the recommended indexes'
-    task :migration => :environment do
+    task :migration => [:environment, :prepare] do
       @findex.generate_migration = true
       @findex.perform_index = false
       indices = @findex.get_indices(:geo, [:name, [:id, :type]], :reflection, [:type, [:boolean, :date, :datetime, :time]])
@@ -82,7 +82,7 @@ namespace :db do
     end
 
     desc 'Performs a migration with the recommended indexes'
-    task :perform => :environment do
+    task :perform => [:environment, :prepare] do
       @findex.generate_migration = false
       @findex.perform_index = true
       indices = @findex.get_indices(:geo, [:name, [:id, :type]], :reflection, [:type, [:boolean, :date, :datetime, :time]])
@@ -138,9 +138,15 @@ class Findex
     ObjectSpace.each_object(Class) do |model|
       next unless model.ancestors.include?(ActiveRecord::Base) && model != ActiveRecord::Base && model.table_exists?
       next if @tables && !@tables.include?(model.table_name.to_s)
-      existing_indices = connection.indexes(model.table_name).map{|index| index.columns.length == 1 ? index.columns.first.to_sym : index.columns.map(&:to_sym) }
-      args.each do |method, options|
-        indices = send("get_model_#{method}_indices", *[model, options, indices, existing_indices].compact)
+      begin
+        # Check for views... expected to fail.
+        Applicant.connection.execute("SHOW CREATE VIEW #{model.table_name}")
+      rescue ActiveRecord::StatementInvalid
+        existing_indices = connection.indexes(model.table_name).map{|index| index.columns.length == 1 ? index.columns.first.to_sym : index.columns.map(&:to_sym) }
+        args.each do |method, options|
+          indices = send("get_model_#{method}_indices", *[model, options, indices, existing_indices].compact)
+        end
+        
       end
     end
     collect_indices(indices)
@@ -224,7 +230,13 @@ class Findex
           index_up.push("\s\s\s\s# Indices for `#{table}`")
           index_down.push("\s\s\s\s# Remove indices for `#{table}`")
           columns.each do |column|
-            index_up.push("\s\s\s\sadd_index :#{table}, #{column.inspect}")
+            if column.is_a?(Array)
+              index_up.push("\s\s\s\sadd_index :#{table}, #{column.inspect}, :name => :#{table}_#{column.join('_')}")
+            elsif "index_#{table}_on_#{column}".length > 64
+              index_up.push("\s\s\s\sadd_index :#{table}, #{column.inspect}, :name => :#{"#{table.to_s.singularize}_#{column.to_s.singularize}"[0, 64]}")
+            else
+              index_up.push("\s\s\s\sadd_index :#{table}, #{column.inspect}")
+            end
             index_down.push("\s\s\s\sremove_index :#{table}, #{column.inspect}")
           end
           migration_up.push(index_up.join("\n"))

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: findex
 version: !ruby/object:Gem::Version 
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors: 
 - Flip Sasser
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-05 00:00:00 -05:00
+date: 2010-03-10 00:00:00 -05:00
 default_executable: 
 dependencies: []
 
@@ -22,6 +22,7 @@ extensions: []
 extra_rdoc_files: 
 - README.markdown
 files: 
+- .gitignore
 - MIT-LICENSE
 - README.markdown
 - Rakefile