findable 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3d9b4cc9d5f9ac6949eaa3db65f5dc97359a8450
-  data.tar.gz: 3ca9a61d80ea9b8d74f5a4e2df78082f07083012
+  metadata.gz: 87900a069a5960243f4231d883d417f0b39c319c
+  data.tar.gz: 44fe61ca87bf212c297cacec0dd8c429dc371d65
 SHA512:
-  metadata.gz: 68ab5f2cb1c8b3fc443ff1b4d1c8199a07634d3fb7ad08a7587247c0ee9836d711f596e2286566f82e59c9dccb2d815098e84e95adc665b0c878d3a721461a1c
-  data.tar.gz: fdd8b84c3f07ded341d312cc6bd1117f2f64b61f5dc40865fa36877852c27b17562b6b2ff3bcb086344ec7e61317e01f058300c53d745b635e17658363793060
+  metadata.gz: c65b156840c789ea9338d6e574a67befcc28c6f8c3dfcdcff59aef446d3a37bb754b1018d2904b988e26783af48d6a2fa2676fdd570d04f7b385dcda3d079210
+  data.tar.gz: 9c851c3620d17317a35aeda778b80b23997ef0778e44e1de5750d5f403bf324e9eb12920b81726c3724ce54e4e5814241a24e423f3fa970fa424b885561841b0

data/.rspec

@@ -0,0 +1,2 @@
+--format documentation
+--color

data/findable.gemspec

@@ -25,8 +25,10 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec-rails"
+  spec.add_development_dependency "rspec"
+  spec.add_development_dependency "activerecord"
   spec.add_development_dependency "pry"
   spec.add_development_dependency "coveralls"
+  spec.add_development_dependency "simplecov"
 end
 

data/lib/findable.rb

@@ -1,4 +1,5 @@
 require "active_support"
+require "active_support/core_ext"
 require "active_model"
 require "redis/objects"
 require "oj"

data/lib/findable/base.rb

@@ -114,7 +114,7 @@ module Findable
 
       def exists?(obj)
         if _id = id_from(obj)
-          query.exists?(data_key, _id)
+          query.exists?(_id)
         else
           false
         end

data/lib/findable/version.rb

@@ -1,4 +1,4 @@
 module Findable
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end
 

data/spec/active_model_lint_spec.rb

@@ -0,0 +1,72 @@
+require "spec_helper"
+
+describe ActiveModel::Lint::Tests do
+  include_context "FindableModels"
+
+  context "#test_to_key" do
+    it "The model should respond to to_key" do
+      expect(findable_instance).to respond_to(:to_key)
+    end
+
+    it "to_key should return nil when `persisted?` returns false" do
+      allow(findable_instance).to receive(:persisted?).and_return(false)
+      expect(findable_instance.to_key).to be_nil
+    end
+  end
+
+  context "#test_to_param" do
+    it "The model should respond to to_param" do
+      expect(findable_instance).to respond_to(:to_param)
+    end
+
+    it "to_param should return nil when `persisted?` returns false" do
+      allow(findable_instance).to receive(:to_key).and_return([1])
+      allow(findable_instance).to receive(:persisted?).and_return(false)
+      expect(findable_instance.to_param).to be_nil
+    end
+  end
+
+  context "#test_to_partial_path" do
+    it "The model should respond to to_partial_path" do
+      expect(findable_instance).to respond_to(:to_partial_path)
+    end
+
+    it { expect(findable_instance.to_partial_path).to be_kind_of(String) }
+  end
+
+  context "#test_persisted?" do
+    it "The model should respond to persisted?" do
+      expect(findable_instance).to respond_to(:persisted?)
+    end
+
+    it "persisted?" do
+      bool = findable_instance.persisted?
+      expect(bool == true || bool == false).to be_truthy
+    end
+  end
+
+  context "#test_model_naming" do
+    it "The model class should respond to model_name" do
+      expect(findable_instance).to respond_to(:model_name)
+    end
+
+    it { expect(findable_model.model_name).to respond_to(:to_str) }
+    it { expect(findable_model.model_name.human).to respond_to(:to_str) }
+    it { expect(findable_model.model_name.singular).to respond_to(:to_str) }
+    it { expect(findable_model.model_name.plural).to respond_to(:to_str) }
+
+    it { expect(findable_instance).to respond_to(:model_name) }
+    it { expect(findable_instance.model_name).to eq(findable_model.model_name) }
+  end
+
+  context "#test_errors_aref" do
+    it "The model should respond to errors" do
+      expect(findable_instance).to respond_to(:errors)
+    end
+
+    it "errors#[] should return an Array" do
+      expect(findable_instance.errors[:hello]).to be_kind_of(Array)
+    end
+  end
+end
+

data/spec/findable/associations/utils_spec.rb

@@ -0,0 +1,32 @@
+require "spec_helper"
+
+describe Findable::Associations::Utils do
+  let(:utils) { Findable::Associations::Utils }
+
+  describe "#model_for" do
+    include_context "FindableModels"
+    let(:model_name) { findable_model.model_name }
+
+    it { expect(utils.model_for(model_name.singular)).to eq(findable_model) }
+    it { expect(utils.model_for(model_name.plural, collection: true)).to eq(findable_model) }
+    it { expect(utils.model_for("invalid", class_name: model_name.name)).to eq(findable_model) }
+
+    it { expect { utils.model_for("invalid") }.to raise_error }
+    it { expect { utils.model_for("invalid", safe: true) }.not_to raise_error }
+    it { expect(utils.model_for("invalid", safe: true)).to be_nil }
+  end
+
+  describe "#parse_args" do
+    let(:parsed_args) { [:some_name, {class_name: "SomeClass"}] }
+    let(:args) { [parsed_args.first, **parsed_args.last] }
+
+    it { expect(utils.parse_args(args)).to eq(parsed_args) }
+
+    it {
+      expect {
+        utils.parse_args(args)
+      }.not_to change { args }
+    }
+  end
+end
+

data/spec/findable/associations_spec.rb

@@ -0,0 +1,21 @@
+require "spec_helper"
+
+describe Findable::Associations do
+  include_context "AssociationModels"
+  let(:group) { Group.first }
+  let(:info) { Info.first }
+  let(:tag) { Tag.first }
+
+  describe "#has_many" do
+    it { expect(group.tags.map(&:id).sort).to eq(Tag.all.map(&:id).sort) }
+  end
+
+  describe "#has_one" do
+    it { expect(group.info.id).to eq(info.id) }
+  end
+
+  describe "#belongs_to" do
+    it { expect(tag.group.id).to eq(group.id) }
+  end
+end
+

data/spec/spec_helper.rb

@@ -1,7 +1,21 @@
-require "findable"
+require "simplecov"
 require "coveralls"
 Coveralls.wear!
 
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+  SimpleCov::Formatter::HTMLFormatter,
+  Coveralls::SimpleCov::Formatter
+]
+
+SimpleCov.start do
+  add_filter "spec"
+  add_filter ".bundle"
+  add_filter "example"
+end
+
+require "pry"
+require "findable"
+
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
 
 RSpec.configure do |config|

data/spec/support/shard_contexts.rb

@@ -0,0 +1,29 @@
+shared_context "FindableModels" do
+  before { class Tag < Findable::Base; end }
+  after { Object.send(:remove_const, "Tag") }
+
+  let(:findable_model) { Tag }
+  let(:findable_instance) { Tag.new }
+end
+
+shared_context "AssociationModels" do
+  before do
+    class Group < Findable::Base; end
+    class Tag < Findable::Base; end
+    class Info < Findable::Base; end
+    Group.has_many :tags
+    Group.has_one :info
+    Tag.belongs_to :group
+    Info.belongs_to :group
+
+    Group.query.import([{id: 1, name: "group1"}])
+    Tag.query.import([
+      {id: 1, name: "tag1", group_id: 1},
+      {id: 2, name: "tag2", group_id: 1},
+    ])
+    Info.query.import([{id: 1, group_id: 1}])
+  end
+
+  after { %w(Group Tag Info).each {|name| Object.send(:remove_const, name) } }
+end
+

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: findable
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - i2bskn
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-05 00:00:00.000000000 Z
+date: 2015-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -95,7 +95,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-rails
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -136,6 +150,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Redis wrapper with API like ActiveRecord.
 email:
 - i2bskn@gmail.com
@@ -145,6 +173,7 @@ extra_rdoc_files: []
 files:
 - ".coveralls.yml"
 - ".gitignore"
+- ".rspec"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt
@@ -168,12 +197,16 @@ files:
 - lib/generators/findable/templates/findable.rb
 - lib/generators/findable/templates/seeds.rb
 - lib/tasks/findable.rake
+- spec/active_model_lint_spec.rb
 - spec/findable/.keep
+- spec/findable/associations/utils_spec.rb
+- spec/findable/associations_spec.rb
 - spec/findable/base_spec.rb
 - spec/findable/configuration_spec.rb
 - spec/spec_helper.rb
 - spec/support/.keep
 - spec/support/initialize_redis.rb
+- spec/support/shard_contexts.rb
 homepage: https://github.com/i2bskn/findable
 licenses:
 - MIT
@@ -199,9 +232,13 @@ signing_key:
 specification_version: 4
 summary: Redis wrapper with API like ActiveRecord.
 test_files:
+- spec/active_model_lint_spec.rb
 - spec/findable/.keep
+- spec/findable/associations/utils_spec.rb
+- spec/findable/associations_spec.rb
 - spec/findable/base_spec.rb
 - spec/findable/configuration_spec.rb
 - spec/spec_helper.rb
 - spec/support/.keep
 - spec/support/initialize_redis.rb
+- spec/support/shard_contexts.rb