finapps_core 2.1.1 → 2.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dccff941fb23d4e52867d5895707394afbd1964b
-  data.tar.gz: 855768812fb098270db4b006a30c954c76c45c7a
+  metadata.gz: 41bc937b65e6ecf5335b7cb97699fbe8e82777dd
+  data.tar.gz: 17af81422ffcd553eaa86e7538df811b6c5369a6
 SHA512:
-  metadata.gz: 75b638cf49af713d61eb982e8ee8e53e8e085e87b4d1b87b406b8e3e2c67c10f885eb6e49e2f1bed4536ec5ab099ad3ce11162eb1d561152a667500485db4ff3
-  data.tar.gz: 25949fba5f1303c77ec2234377addaa265761b81b09abb44817c1ca885aa55134b2f6bb7a409ccf08f2204c43af3c17eb5cf7ba89bdb780a79fbe2b8e6b2b643
+  metadata.gz: a8b266d0d81086d294e9456d70870eab4c5041c6a1c19aeaed69f1f1cd69ab1eaac3348c04aa1b036f7296f0b9dba830c8c8f70b2db3597c8082467567f787ae
+  data.tar.gz: fcce2dba8db4d9bd0f2dc500f73737a1bf3620d514e2639e274b8521c0895af7f0b7710a197952cbaac815477fc520b66941cecd660ec62114f39fe12ad746da

data/lib/finapps_core/middleware/response/custom_logger.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'logger'
+
 module FinAppsCore
   module Middleware
     class CustomLogger < Faraday::Response::Middleware
@@ -10,14 +12,11 @@ module FinAppsCore
 
       def initialize(app, logger=nil, options={})
         super(app)
-        @logger = logger || begin
-          require 'logger'
-          ::Logger.new(STDOUT)
-        end
+        @logger = logger || new_logger
         @options = DEFAULT_OPTIONS.merge(options)
       end
 
-      def_delegators :@logger, :debug, :info, :warn, :error, :fatal
+      def_delegators :@logger, :debug
 
       def call(env)
         debug "#{self.class.name}##{__method__} => URL: #{env.method.upcase} #{env.url}"
@@ -33,7 +32,14 @@ module FinAppsCore
       private
 
       def dump(value)
-        skip_sensitive_data(value.is_a?(Array) ? value.to_h : value).to_json
+        s = skip_sensitive_data(value.is_a?(Array) ? value.to_h : value)
+        s.nil? ? 'NO-CONTENT' : s.to_json
+      end
+
+      def new_logger
+        logger = Logger.new(STDOUT)
+        logger.level = FinAppsCore::REST::Defaults::DEFAULTS[:log_level]
+        logger
       end
     end
   end

data/lib/finapps_core/middleware/response/raise_error.rb

@@ -34,13 +34,23 @@ module FinAppsCore
       private
 
       def error_messages(body)
-        return nil if !body || (body.respond_to?(:empty?) && body.empty?)
-        body = body.json_to_hash if body.is_a?(String)
-        has_message_key?(body) ? body['messages'] : nil
+        return nil if empty?(body)
+        hash = to_hash body
+        messages hash
       end
 
-      def has_message_key?(body)
-        body.respond_to?(:key?) && body.key?('messages')
+      def messages(hash)
+        return nil unless hash.respond_to?(:key?) && hash.key?('messages')
+        hash['messages']
+      end
+
+      def to_hash(source)
+        return source unless source.is_a?(String)
+        source.json_to_hash
+      end
+
+      def empty?(o)
+        o.nil? || (o.respond_to?(:empty?) && o.empty?)
       end
     end
   end

data/lib/finapps_core/rest/base_client.rb

@@ -77,7 +77,7 @@ module FinAppsCore
       end
 
       def empty_body?(response)
-        response.respond_to?(:body) && (!response.body || (response.body.respond_to?(:empty?) && response.body.empty?))
+        !response.respond_to?(:body) || !response.body || (response.body.respond_to?(:empty?) && response.body.empty?)
       end
 
       def execute_request(path, method, params)

data/lib/finapps_core/rest/configuration.rb

@@ -7,7 +7,7 @@ module FinAppsCore
       using ObjectExtensions
 
       attr_accessor :tenant_token, :user_identifier, :user_token,
-                    :host, :proxy, :timeout, :retry_limit,
+                    :host, :proxy, :timeout, :retry_limit, :rashify,
                     :log_level
 
       def initialize(options={})

data/lib/finapps_core/rest/connection.rb

@@ -22,7 +22,7 @@ module FinAppsCore
           conn.request :no_encoding_basic_authentication, config.user_token if config.valid_user_credentials?
 
           conn.use FinAppsCore::Middleware::RaiseError
-          conn.response :rashify
+          conn.response :rashify if config.rashify
           conn.response :json, content_type: /\bjson$/
           conn.response :custom_logger, logger, bodies: (ENV['SILENT_LOG_BODIES'] != 'true')
 

data/lib/finapps_core/rest/defaults.rb

@@ -8,8 +8,6 @@ module FinAppsCore
       # noinspection SpellCheckingInspection
       DEFAULTS = {
         host:             'https://api.financialapps.com',
-        user_identifier:  nil,
-        user_token:       nil,
         timeout:          30,
         proxy:            nil,
         retry_limit:      1,

data/lib/finapps_core/rest/resources.rb

@@ -24,23 +24,23 @@ module FinAppsCore
 
       def list(path=nil)
         path = end_point.to_s if path.nil?
-        request_with_body(path, :get, {})
+        send_request path, :get
       end
 
-      def create(params={}, path=nil)
-        request_with_body(path, :post, params)
+      def show(id=nil, path=nil)
+        send_request_for_id path, :get, id
       end
 
-      def update(params={}, path=nil)
-        request_with_body(path, :put, params)
+      def create(params={}, path=nil)
+        send_request path, :post, params
       end
 
-      def show(id=nil, path=nil)
-        request_without_body(path, :get, id)
+      def update(params={}, path=nil)
+        send_request path, :put, params
       end
 
       def destroy(id=nil, path=nil)
-        request_without_body(path, :delete, id)
+        send_request_for_id path, :delete, id
       end
 
       protected
@@ -51,13 +51,17 @@ module FinAppsCore
 
       private
 
-      def request_without_body(path, method, id)
-        not_blank(id, :id) if path.nil?
-        path = "#{end_point}/:id".sub ':id', ERB::Util.url_encode(id) if path.nil?
-        request_with_body path, method, {}
+      def send_request_for_id(path, method, id)
+        path = resource_path(id) if path.nil?
+        send_request path, method
+      end
+
+      def resource_path(id)
+        not_blank id, :id
+        "#{end_point}/#{ERB::Util.url_encode(id)}"
       end
 
-      def request_with_body(path, method, params)
+      def send_request(path, method, params={})
         path = end_point if path.nil?
         logger.debug "#{self.class.name}##{__method__} => path: #{path} params: #{skip_sensitive_data(params)}"
 

data/lib/finapps_core/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinAppsCore
-  VERSION = '2.1.1'
+  VERSION = '2.1.2'
 end

data/spec/rest/defaults_spec.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+RSpec.describe FinAppsCore::REST::Defaults do
+  let(:fake_class) { Class.new }
+
+  describe 'set constants' do
+    before { stub_const(described_class.to_s, fake_class) }
+
+    it('sets API_VERSION') { expect(described_class::API_VERSION).to eq '2' }
+    it('sets DEFAULTS') { expect(described_class::DEFAULTS).to be_a(Hash) }
+    it('freezes DEFAULTS') { expect(described_class::DEFAULTS).to be_frozen }
+    it('sets DEFAULTS[:host]') { expect(described_class::DEFAULTS[:host]).to eq 'https://api.financialapps.com' }
+    it('sets DEFAULTS[:timeout]') { expect(described_class::DEFAULTS[:timeout]).to eq 30 }
+    it('does not set DEFAULTS[:proxy]') { expect(described_class::DEFAULTS[:proxy]).to be_nil }
+    it('sets DEFAULTS[:retry_limit]') { expect(described_class::DEFAULTS[:retry_limit]).to eq 1 }
+    it('sets DEFAULTS[:log_level]') { expect(described_class::DEFAULTS[:log_level]).to eq Logger::INFO }
+  end
+end

data/spec/rest/resources_spec.rb

@@ -1,8 +1,22 @@
 # frozen_string_literal: true
 
+require 'spec_helpers/client'
+
 RSpec.describe FinAppsCore::REST::Resources do
+  include SpecHelpers::Client
+  subject { FinAppsCore::REST::Resources.new client }
+
   describe '#new' do
+    context 'for a valid client param' do
+      it { expect { subject }.not_to raise_error }
+    end
+
+    context 'when missing client param' do
+      subject { FinAppsCore::REST::Resources.new nil }
+      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
+    end
   end
+
   describe '#list' do
   end
   describe '#create' do

data/spec/spec_helpers/client.rb

@@ -3,7 +3,7 @@
 module SpecHelpers
   module Client
     def client
-      FinAppsCore::REST::Client.new :tenant_id, :tenant_token
+      FinAppsCore::REST::BaseClient.new tenant_token: :tenant_token
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps_core
 version: !ruby/object:Gem::Version
-  version: 2.1.1
+  version: 2.1.2
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-19 00:00:00.000000000 Z
+date: 2017-10-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -297,6 +297,7 @@ files:
 - spec/rest/base_client_spec.rb
 - spec/rest/configuration_spec.rb
 - spec/rest/credentials_spec.rb
+- spec/rest/defaults_spec.rb
 - spec/rest/resources_spec.rb
 - spec/spec_helper.rb
 - spec/spec_helpers/client.rb
@@ -340,6 +341,7 @@ signing_key:
 specification_version: 4
 summary: FinApps REST API ruby client - Core.
 test_files:
+- spec/rest/defaults_spec.rb
 - spec/rest/base_client_spec.rb
 - spec/rest/credentials_spec.rb
 - spec/rest/configuration_spec.rb