finapps_core 2.0.6 → 2.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d572a8ff17d98bcb1ce97450aabb466546643c43
-  data.tar.gz: a817625334d11a4913d77dbc5301525ac652416b
+  metadata.gz: 27b7a32bc07de6279792ad72a85a123d42edaa35
+  data.tar.gz: 6d5d8f956fdafef44ae6fc905bc00d4b1f6b00eb
 SHA512:
-  metadata.gz: 7cc72f84ff5c4f4051d56f8a8a59d6313c3516b1541287ca438f04af2658e2c5056bb41845dbbd10a173fd5df9e594ebeb3acb50b4e99fb3949a88f6b53b3d65
-  data.tar.gz: abbde216bd6238f0ebd250ece49ffc7265746baa786635c5cdd14c26eee6de4848073eb5181786c661b64e143196f7ab719a2c5cbca85b88bff07f9c79fc56ec
+  metadata.gz: d49b6df9306ba6e14b73d0f9e2a2733708bf899115411bc79d66be8b6025b755d78db51e68d0383b58bdd664f680b11e1b5a4894c50fbc41f36944f9208084de
+  data.tar.gz: 55ea7d2c683a81d84d65f830484adaa05ce6f34322159b5f4b8b32c0de2f6cbcef09165158fd4a293baafc89351970965d1c607bb94233e7b0536a089e442b24

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    finapps_core (2.0.5)
+    finapps_core (2.0.7)
       faraday (~> 0.11, >= 0.11.0)
       faraday_middleware (~> 0.11, >= 0.11.0.1)
       rash (~> 0.4, >= 0.4.0)
@@ -26,6 +26,7 @@ GEM
     faraday_middleware (0.11.0.1)
       faraday (>= 0.7.4, < 1.0)
     ffi (1.9.17)
+    gem-release (0.7.4)
     hashdiff (0.3.2)
     hashie (2.0.5)
     json (2.0.3)
@@ -87,6 +88,7 @@ DEPENDENCIES
   bundler (~> 1.14, >= 1.14.3)
   codeclimate-test-reporter (~> 1.0, >= 1.0.5)
   finapps_core!
+  gem-release (~> 0.7, >= 0.7.4)
   rake (~> 12.0, >= 12.0.0)
   rspec (~> 3.5, >= 3.5.0)
   rubocop (~> 0.47, >= 0.47.1)

data/finapps_core.gemspec

@@ -20,12 +20,13 @@ Gem::Specification.new do |spec|
   spec.test_files = Dir['spec/**/*.rb']
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'faraday',                        '~> 0.11',  '>= 0.11.0'
-  spec.add_runtime_dependency 'faraday_middleware',             '~> 0.11',  '>= 0.11.0.1'
-  spec.add_runtime_dependency 'typhoeus',                       '~> 1.1',   '>= 1.1.2'
-  spec.add_runtime_dependency 'rash',                           '~> 0.4',   '>= 0.4.0'
+  spec.add_runtime_dependency     'faraday',                    '~> 0.11',  '>= 0.11.0'
+  spec.add_runtime_dependency     'faraday_middleware',         '~> 0.11',  '>= 0.11.0.1'
+  spec.add_runtime_dependency     'typhoeus',                   '~> 1.1',   '>= 1.1.2'
+  spec.add_runtime_dependency     'rash',                       '~> 0.4',   '>= 0.4.0'
 
   spec.add_development_dependency 'bundler',                    '~> 1.14',  '>= 1.14.3'
+  spec.add_development_dependency 'gem-release',                '~> 0.7',   '>= 0.7.4'
   spec.add_development_dependency 'rake',                       '~> 12.0',  '>= 12.0.0'
   spec.add_development_dependency 'rspec',                      '~> 3.5',   '>= 3.5.0'
   spec.add_development_dependency 'webmock',                    '~> 2.3',   '>= 2.3.2'

data/lib/finapps_core/rest/base_client.rb

@@ -2,13 +2,16 @@
 require_relative './configuration.rb'
 require_relative './connection.rb'
 require_relative '../utils/loggeable'
+require_relative '../utils/validatable'
 
 module FinAppsCore
   module REST
     # base client functionality
     class BaseClient
       include ::FinAppsCore::Utils::Loggeable
+      include ::FinAppsCore::Utils::Validatable
       include ::FinAppsCore::REST::Connection
+
       using ObjectExtensions
       using StringExtensions
 
@@ -35,8 +38,8 @@ module FinAppsCore
       # @param [Hash] params
       # @return [Hash,Array<String>]
       def send_request(path, method, params={})
-        raise FinAppsCore::MissingArgumentsError.new 'Missing argument: path.' if path.blank?
-        raise FinAppsCore::MissingArgumentsError.new 'Missing argument: method.' if method.blank?
+        not_blank(path, :path)
+        not_blank(method, :method)
 
         response, error_messages = execute_request(path, method, params)
         result = if empty?(response)

data/lib/finapps_core/utils/validatable.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+module FinAppsCore
+  module Utils
+    # Adds validation capabilities when included into other classes
+    module Validatable
+      using ObjectExtensions
+      using StringExtensions
+
+      def not_blank(value, name=nil)
+        raise FinAppsCore::MissingArgumentsError.new "Missing argument#{": #{name}" unless name.nil?}" if value.blank?
+      end
+    end
+  end
+end

data/lib/finapps_core/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module FinAppsCore
-  VERSION = '2.0.6'
+  VERSION = '2.0.7'
 end

data/lib/finapps_core.rb

@@ -11,6 +11,7 @@ require 'core_extensions/object/is_integer'
 require 'core_extensions/string/json_to_hash'
 
 require 'finapps_core/utils/loggeable'
+require 'finapps_core/utils/validatable'
 require 'finapps_core/utils/parameter_filter'
 require 'finapps_core/error'
 

data/spec/rest/base_client_spec.rb

@@ -33,12 +33,12 @@ RSpec.describe FinAppsCore::REST::BaseClient do
 
     it 'should raise FinAppsCore::MissingArgumentsError if method is NOT provided' do
       expect { subject.send_request(nil, :get) }.to raise_error(FinAppsCore::MissingArgumentsError,
-                                                                'Missing argument: path.')
+                                                                'Missing argument: path')
     end
 
     it 'should raise FinAppsCore::MissingArgumentsError if path is NOT provided' do
       expect { subject.send_request('fake_path', nil) }.to raise_error(FinAppsCore::MissingArgumentsError,
-                                                                       'Missing argument: method.')
+                                                                       'Missing argument: method')
     end
 
     context 'when method and path are provided' do

data/spec/utils/validatable_spec.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+class FakeClass
+  include FinAppsCore::Utils::Validatable
+end
+
+RSpec.describe FinAppsCore::Utils::Validatable do
+  describe '#not_blank' do
+    context 'for null values' do
+      it 'should raise FinAppsCore::MissingArgumentsError' do
+        expect { FakeClass.new.not_blank(nil) }.to raise_error(FinAppsCore::MissingArgumentsError,
+                                                               'Missing argument')
+      end
+
+      it 'should describe the argument name when provided' do
+        expect { FakeClass.new.not_blank(nil, :name) }.to raise_error(FinAppsCore::MissingArgumentsError,
+                                                                      'Missing argument: name')
+      end
+    end
+
+    context 'for non null values' do
+      it 'should not raise' do
+        expect { FakeClass.new.not_blank(true) }.not_to raise_error
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps_core
 version: !ruby/object:Gem::Version
-  version: 2.0.6
+  version: 2.0.7
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-09 00:00:00.000000000 Z
+date: 2017-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -110,6 +110,26 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.14.3
+- !ruby/object:Gem::Dependency
+  name: gem-release
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.7'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.7.4
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.7'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.7.4
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -293,6 +313,7 @@ files:
 - lib/finapps_core/rest/resources.rb
 - lib/finapps_core/utils/loggeable.rb
 - lib/finapps_core/utils/parameter_filter.rb
+- lib/finapps_core/utils/validatable.rb
 - lib/finapps_core/version.rb
 - lib/tasks/releaser.rake
 - spec/core_extensions/object/blank_spec.rb
@@ -317,6 +338,7 @@ files:
 - spec/support/fixtures/resources.json
 - spec/support/fixtures/unauthorized.json
 - spec/utils/parameter_filter_spec.rb
+- spec/utils/validatable_spec.rb
 homepage: https://github.com/finapps/ruby-client-core
 licenses:
 - MIT
@@ -354,6 +376,7 @@ test_files:
 - spec/rest/timeout_spec.rb
 - spec/support/fake_api.rb
 - spec/utils/parameter_filter_spec.rb
+- spec/utils/validatable_spec.rb
 - spec/spec_helpers/client.rb
 - spec/spec_helper.rb
 - spec/core_extensions/object/is_integer_spec.rb