finapps 6.4.2 → 6.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b5bcaa6d95acfee673748592f7f9d9f194ec1613266091cae68c9ec3e4db4492
-  data.tar.gz: 384913ddd890b6c7e4f5bf13ec1a69aa52d8503c72489f526f87f1faca82e42c
+  metadata.gz: 1c47f3bb9f6e6702acf5a530b1e9c243a80271bc66e4eecec1fa6c1a088e99e0
+  data.tar.gz: fe0770b6dbe32afe9997a8d631ff5dae85c1963e0b6b26ac52bfec4cf2794159
 SHA512:
-  metadata.gz: c66633e84b08db5b9aa4047cdbc9aec57e2cf0f73497389f1748a7f952ff4007b83b99dce7c64c34f82cefd2521ec49014ea6aa4489957b947c88df17d21ef44
-  data.tar.gz: ce41307748a75ae249eaea3efee34d465171a55cb7cf5a4c8c05ed33cede52694d2c2518979aad0f4e87d620266598f7110c9d6971ed07d424d0f63cae5aefac
+  metadata.gz: eb6e96b56b2e64f03eef52e9e5f4573eca2c9940421caa3d15dc42b3fd400781a40bfd44fe592b7886ebf4cd0de3f9854e080a60c85454f0228919524ed513a9
+  data.tar.gz: 3762f06a6f148e7dd040c9005e98614f9bcdd54f497a1b6f1e7a1d148bc5e528852592e3ff4ecaec2df5a8419cc95a53f299e02c292d5d1285e5e28b61575060

data/lib/finapps/rest/screenings.rb

@@ -98,18 +98,13 @@ module FinApps
       def from_filter(from_date)
         return {} unless from_date
 
-        {'$gte': to_rfc_date(from_date.to_s)}
+        {'$gte': from_date}
       end
 
       def to_filter(to_date)
         return {} unless to_date
 
-        {'$lt': to_rfc_date(to_date.to_s)}
-      end
-
-      def to_rfc_date(str)
-        date = DateTime.parse(str)
-        date.rfc3339
+        {'$lt': to_date}
       end
 
       def progress_filter(progress)

data/lib/finapps/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinApps
-  VERSION = '6.4.2'
+  VERSION = '6.4.3'
 end

data/spec/rest/screenings_spec.rb

@@ -15,11 +15,14 @@ RSpec.describe FinApps::REST::Screenings do
     context 'with valid params' do
       let(:params) { {} }
 
-      RSpec.shared_examples 'performs a GET request' do
+      RSpec.shared_examples 'a GET request' do
         it { expect(results).to have_key(:records) }
       end
 
       RSpec.shared_examples 'a correct query builder' do |filter|
+        it_behaves_like 'an API request'
+        it_behaves_like 'a successful request'
+        it_behaves_like 'a GET request'
         it 'builds query and sends proper request' do
           list
           encoded_filter = ERB::Util.url_encode filter.to_json
@@ -32,9 +35,6 @@ RSpec.describe FinApps::REST::Screenings do
       context 'without searchTerm' do
         let(:params) { {searchTerm: nil, page: 2} }
 
-        it_behaves_like 'an API request'
-        it_behaves_like 'a successful request'
-        it_behaves_like 'performs a GET request'
         it 'builds query and sends proper request' do
           list
           url = "#{versioned_api_path}/screenings?page=2"
@@ -43,33 +43,45 @@ RSpec.describe FinApps::REST::Screenings do
         end
       end
 
+      context 'with from date' do
+        let(:params) { {fromDate: 'from'} }
+
+        it_behaves_like 'a correct query builder', {
+          '*date_created': {'$gte': 'from'}
+        }
+      end
+
+      context 'with to date' do
+        let(:params) { {toDate: 'to'} }
+
+        it_behaves_like 'a correct query builder', {
+          '*date_created': {'$lt': 'to'}
+        }
+      end
+
       context 'with date range' do
-        let(:params) { {fromDate: '08/01/2021', toDate: '09/01/2021'} }
+        let(:params) { {fromDate: 'from', toDate: 'to'} }
 
-        it_behaves_like 'an API request'
-        it_behaves_like 'a successful request'
-        it_behaves_like 'performs a GET request'
         it_behaves_like 'a correct query builder', {
-          '*date_created': {'$gte': '2021-01-08T00:00:00%2B00:00',
-                            '$lt': '2021-01-09T00:00:00%2B00:00'}
+          '*date_created': {'$gte': 'from', '$lt': 'to'}
         }
       end
 
-      context 'with progress' do
+      context 'with invalid progress' do
+        let(:params) { {progress: 'xyz'} }
+
+        it_behaves_like 'a correct query builder', {progress: 0}
+      end
+
+      context 'with valid progress' do
         let(:params) { {progress: 10} }
 
-        it_behaves_like 'an API request'
-        it_behaves_like 'a successful request'
-        it_behaves_like 'performs a GET request'
         it_behaves_like 'a correct query builder', {progress: 10}
       end
 
       context 'with searchTerm' do
         let(:params) { {searchTerm: 'le term'} }
 
-        it_behaves_like 'an API request'
-        it_behaves_like 'a successful request'
-        it_behaves_like 'performs a GET request'
         it_behaves_like 'a correct query builder', {
           '$or': [{'consumer.public_id': 'le term'},
                   {'consumer.email': 'le term'},
@@ -95,7 +107,7 @@ RSpec.describe FinApps::REST::Screenings do
 
       it_behaves_like 'an API request'
       it_behaves_like 'a successful request'
-      it_behaves_like 'performs a GET request'
+      it_behaves_like 'a GET request'
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 6.4.2
+  version: 6.4.3
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-09-22 00:00:00.000000000 Z
+date: 2021-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: finapps_core