finapps 6.4.0 → 6.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8428ee4965080f78c083fc2e3d0de2fc66b59596bf5ea81bbbc17e2c11ad2b39
-  data.tar.gz: 0656c926f0b3c70929fb6fbe1b69282d766c56c777aa32ed377218ceac9a6824
+  metadata.gz: 685415494dde868b2db873ce98d626c4ed45f4e96604b475c1db6fcd892abbeb
+  data.tar.gz: 0b4b6599766968bee2752b7d2e968c9d856a9f56f0ebfe1d33d411f3d57e6579
 SHA512:
-  metadata.gz: 4163eda4a00e4df6c1a34cd76733d11c53fc4774899aabea933bbfe304e5acbd92ea714ccbbd974f8bd496278e501d7fd0d8591ad503480356e9ca75f98198ee
-  data.tar.gz: 756edbc47cdb115e15efe6dc53be0aeea1610feb93470fed421105ce2a7a6b8fa59c04fc84c99c9c5d75a8914b21de5e68d69c29ff584ab810506f948daed233
+  metadata.gz: eab93c5894770567f201112caf3b93455c4d473aa20c8e466a9aafb0afdbe6a6dd556d55efa10db62af89f6b41d3b332c04b162b4f728c712ff0982c9843bd1b
+  data.tar.gz: c008d2a8dffc8be3e359c95bd7de30f07de6c26b12d2d7bfbb382553eaa108d5228e652fe56ce10ef7be9b91abaafe753fc4644c50ab928d06f86d7db3889370

data/lib/finapps/rest/screenings.rb

@@ -115,7 +115,7 @@ module FinApps
       def progress_filter(progress)
         return {} unless progress
 
-        {progress: progress}
+        {progress: progress.to_int}
       end
 
       def space?(string)

data/lib/finapps/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinApps
-  VERSION = '6.4.0'
+  VERSION = '6.4.1'
 end

data/spec/rest/documents_orders_spec.rb

@@ -215,7 +215,7 @@ RSpec.describe FinApps::REST::DocumentsOrders do
       end
     end
 
-    context 'with missing  params' do
+    context 'with missing params' do
       let(:params) { nil }
 
       it_behaves_like 'a request that raises an error'

data/spec/rest/screenings_spec.rb

@@ -13,74 +13,75 @@ RSpec.describe FinApps::REST::Screenings do
     subject(:list) { described_class.new(client).list(params) }
 
     context 'with valid params' do
+      let(:params) { {} }
+
+      RSpec.shared_examples 'performs a GET request' do
+        it { expect(results).to have_key(:records) }
+      end
+
+      RSpec.shared_examples 'a correct query builder' do |filter|
+        it 'builds query and sends proper request' do
+          list
+          encoded_filter = ERB::Util.url_encode filter.to_json
+          url = "#{versioned_api_path}/screenings?filter=#{encoded_filter}"
+
+          expect(WebMock).to have_requested(:get, url)
+        end
+      end
+
       context 'without searchTerm' do
         let(:params) { {searchTerm: nil, page: 2} }
 
         it_behaves_like 'an API request'
         it_behaves_like 'a successful request'
-        it 'performs a get and returns the response' do
-          expect(results).to have_key(:records)
-        end
-
+        it_behaves_like 'performs a GET request'
         it 'builds query and sends proper request' do
           list
           url = "#{versioned_api_path}/screenings?page=2"
+
           expect(WebMock).to have_requested(:get, url)
         end
       end
 
-      # rubocop:disable RSpec/ExampleLength
       context 'with date range' do
         let(:params) { {fromDate: '08/01/2021', toDate: '09/01/2021'} }
 
         it_behaves_like 'an API request'
         it_behaves_like 'a successful request'
-        it 'performs a get and returns the response' do
-          expect(results).to have_key(:records)
-        end
+        it_behaves_like 'performs a GET request'
+        it_behaves_like 'a correct query builder', {
+          '*date_created': {'$gte': '2021-01-08T00:00:00%2B00:00',
+                            '$lt': '2021-01-09T00:00:00%2B00:00'}
+        }
+      end
 
-        it 'builds query and sends proper request' do
-          list
-          json_filter = {
-            '*date_created': {'$gte': '2021-01-08T00:00:00%2B00:00',
-                              '$lt': '2021-01-09T00:00:00%2B00:00'}
-          }.to_json
-          encoded_filter = ERB::Util.url_encode json_filter
-          url = "#{versioned_api_path}/screenings?filter=#{encoded_filter}"
+      context 'with progress' do
+        let(:params) { {progress: 10} }
 
-          expect(WebMock).to have_requested(:get, url)
-        end
+        it_behaves_like 'an API request'
+        it_behaves_like 'a successful request'
+        it_behaves_like 'performs a GET request'
+        it_behaves_like 'a correct query builder', {progress: 10}
       end
-      # rubocop:enable RSpec/ExampleLength
 
-      # rubocop:disable RSpec/ExampleLength
       context 'with searchTerm' do
         let(:params) { {searchTerm: 'le term'} }
 
         it_behaves_like 'an API request'
         it_behaves_like 'a successful request'
-        it 'performs a get and returns the response' do
-          expect(results).to have_key(:records)
-        end
-
-        it 'builds query and sends proper request' do
-          list
-          json_filter = {'$or': [{'consumer.public_id': 'le term'},
-                                 {'consumer.email': 'le term'},
-                                 {'consumer.first_name': 'le term'},
-                                 {'consumer.last_name': 'le term'},
-                                 {'consumer.external_id': 'le term'},
-                                 {'consumer.first_name': 'le'},
-                                 {'consumer.last_name': 'le'},
-                                 {'consumer.first_name': 'term'},
-                                 {'consumer.last_name': 'term'}]}.to_json
-          encoded_filter = ERB::Util.url_encode json_filter
-          url = "#{versioned_api_path}/screenings?filter=#{encoded_filter}"
-
-          expect(WebMock).to have_requested(:get, url)
-        end
+        it_behaves_like 'performs a GET request'
+        it_behaves_like 'a correct query builder', {
+          '$or': [{'consumer.public_id': 'le term'},
+                  {'consumer.email': 'le term'},
+                  {'consumer.first_name': 'le term'},
+                  {'consumer.last_name': 'le term'},
+                  {'consumer.external_id': 'le term'},
+                  {'consumer.first_name': 'le'},
+                  {'consumer.last_name': 'le'},
+                  {'consumer.first_name': 'term'},
+                  {'consumer.last_name': 'term'}]
+        }
       end
-      # rubocop:enable RSpec/ExampleLength
     end
 
     context 'with invalid params' do
@@ -94,9 +95,7 @@ RSpec.describe FinApps::REST::Screenings do
 
       it_behaves_like 'an API request'
       it_behaves_like 'a successful request'
-      it('performs a get and returns the response') do
-        expect(results).to have_key(:records)
-      end
+      it_behaves_like 'performs a GET request'
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 6.4.0
+  version: 6.4.1
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-09-21 00:00:00.000000000 Z
+date: 2021-09-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: finapps_core