finapps 5.0.5 → 5.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: db44bf32241ed4d54bf29dce14836832397136256eb5fe28821a245c16c7b4d6
-  data.tar.gz: ff07e6b644f1f7465b359086037069017b9c3b4d16852729dafafbcf706c9423
+  metadata.gz: 7a1641f0fe296f8026dbe5423f23b0c521bb0dd7722657f7c46bdeb06fa2fbf2
+  data.tar.gz: 818dd5f516d402ce3ffada206dac6a48531de84b998a031d7b466b9e89d8f5cc
 SHA512:
-  metadata.gz: 041f8b7b3bd9412a8cc712ba996f727bb78a93128c9fbe384f17460bad73b920f13b7c3063e860a6bf3798616fa406cca6505ee12dab76f0b130b9adef5f4f32
-  data.tar.gz: 78fed6e1e88b09e79794ae492bbde7368123c0bfbe0ce790d4f24f849bcd62abf9c76b9cabf958ee01b7dcdc59cfd195b45385cc0f0ff4f1741558f243df47c4
+  metadata.gz: 8088f973f6d1841f1d67b654811a91e795347198fd05c7ec7d82d69d816ff09d09b48ea02d646ffd659a76fef57d88d85f9c0a62f396a442103b127193c79126
+  data.tar.gz: 4391a7c8b7851baa3ffd4338522277d00f00c24964d04b93b1743cb58edab98992e7dbcbfea7f70db1546941d7d959f47e3aa7a0e1433164e08070e5128094d6

data/lib/finapps.rb

@@ -31,6 +31,7 @@ require 'finapps/rest/portfolios_consumers'
 require 'finapps/rest/consumers_portfolios'
 require 'finapps/rest/portfolio_reports'
 
+require 'finapps/rest/plaid/plaid_resources'
 require 'finapps/rest/plaid/plaid_webhooks'
 require 'finapps/rest/plaid/plaid_consumer_institutions'
 

data/lib/finapps/rest/plaid/plaid_consumer_institutions.rb

@@ -2,7 +2,7 @@
 
 module FinApps
   module REST
-    class PlaidConsumerInstitutions < FinAppsCore::REST::Resources # :nodoc:
+    class PlaidConsumerInstitutions < PlaidResources # :nodoc:
       def create(params)
         super(params, 'p/institution/consumer')
       end

data/lib/finapps/rest/plaid/plaid_resources.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module FinApps
+  module REST
+    class PlaidResources < FinAppsCore::REST::Resources # :nodoc:
+      protected
+
+      def end_point
+        super.gsub!('plaid', 'p/')
+      end
+    end
+  end
+end

data/lib/finapps/rest/plaid/plaid_webhooks.rb

@@ -2,9 +2,9 @@
 
 module FinApps
   module REST
-    class PlaidWebhooks < FinAppsCore::REST::Resources # :nodoc:
-      def create
-        super({}, 'p/webhook')
+    class PlaidWebhooks < PlaidResources # :nodoc:
+      def show
+        send_request_for_id 'p/webhook', :get, nil
       end
     end
   end

data/lib/finapps/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinApps
-  VERSION = '5.0.5'
+  VERSION = '5.0.6'
 end

data/spec/rest/plaid/plaid_webhooks_spec.rb

@@ -6,22 +6,22 @@ RSpec.describe FinApps::REST::PlaidWebhooks do
   include SpecHelpers::Client
 
   let(:api_client) { client }
-  subject(:create) { FinApps::REST::PlaidWebhooks.new(api_client).create }
+  subject(:show) { FinApps::REST::PlaidWebhooks.new(api_client).show }
 
-  describe '#create' do
+  describe '#show' do
     RSpec.shared_examples 'an API request' do |_parameter|
-      it { expect { subject }.not_to raise_error }
-      it('returns an array') { expect(subject).to be_a(Array) }
+      it { expect { show }.not_to raise_error }
+      it('returns an array') { expect(show).to be_a(Array) }
     end
 
     context 'when valid tenant token is provided' do
       it_behaves_like 'an API request'
 
       it('performs a post and returns the webhook url') do
-        expect(create[RESULTS]).to have_key(:url)
+        expect(show[RESULTS]).to have_key(:url)
       end
       it('returns no error messages') do
-        expect(create[ERROR_MESSAGES]).to be_empty
+        expect(show[ERROR_MESSAGES]).to be_empty
       end
     end
 
@@ -29,10 +29,11 @@ RSpec.describe FinApps::REST::PlaidWebhooks do
       let(:api_client) { client(:invalid_tenant_token) }
 
       it_behaves_like 'an API request'
-      it('results is nil') { expect(create[RESULTS]).to be_nil }
+
+      it('results is nil') { expect(show[RESULTS]).to be_nil }
       it('error messages array is populated') do
-        expect(create[ERROR_MESSAGES].first.downcase).to eq(
-          'resource not found'
+        expect(show[ERROR_MESSAGES].first.downcase).to eq(
+          'invalid tenant api key or secret'
         )
       end
     end

data/spec/support/fake_api.rb

@@ -16,10 +16,10 @@ class FakeApi < Sinatra::Base
   delete("/#{version}/resources/:id") { status 202 }
 
   # plaid_webhook
-  post("/#{version}/p/webhook") do
+  get("/#{version}/p/webhook") do
     tenant_token = request.env['HTTP_X_TENANT_TOKEN']
     if tenant_token == 'invalid_tenant_token'
-      json_response 404, 'resource_not_found.json'
+      json_response 404, 'invalid_tenant_credentials.json'
     else
       json_response 200, 'plaid/webhook.json'
     end

data/spec/support/fixtures/invalid_tenant_credentials.json

@@ -0,0 +1,5 @@
+{
+  "messages": [
+    "Invalid Tenant API Key or Secret"
+  ]
+}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 5.0.5
+  version: 5.0.6
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-01 00:00:00.000000000 Z
+date: 2019-08-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: finapps_core
@@ -313,6 +313,7 @@ files:
 - lib/finapps/rest/orders.rb
 - lib/finapps/rest/password_resets.rb
 - lib/finapps/rest/plaid/plaid_consumer_institutions.rb
+- lib/finapps/rest/plaid/plaid_resources.rb
 - lib/finapps/rest/plaid/plaid_webhooks.rb
 - lib/finapps/rest/portfolio_reports.rb
 - lib/finapps/rest/portfolios.rb
@@ -365,6 +366,7 @@ files:
 - spec/support/fixtures/error.json
 - spec/support/fixtures/fake_pdf_statement.json
 - spec/support/fixtures/invalid_request_body.json
+- spec/support/fixtures/invalid_tenant_credentials.json
 - spec/support/fixtures/invalid_user_id.json
 - spec/support/fixtures/invalid_user_institution_id.json
 - spec/support/fixtures/mfa_timeout.json