finapps 5.0.16 → 5.0.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5e152bd168f623e4d40787548c86e7c80c056826311cb15c642e1da4930a6312
-  data.tar.gz: 650f2da982b5cddaaa0acebbe83c74cfc9b669a020606f7e542dd6c45760209b
+  metadata.gz: 5512d2f1ee03d53352b24c01d80f7d58828bd6ffe4e6ab2e58d716e1474de6a3
+  data.tar.gz: 0706fa34a43305d15380c0a0ea3f655bed1cbb7439b084c2bbb440218d692e94
 SHA512:
-  metadata.gz: 6f37c24832dec19af8e3760affb07e6d05a4bbde1916f56025047dbc35fe08d1cbda1032bacb35a2acc1c2622b5b806785a9c8890460a986c281ebaa6dd18703
-  data.tar.gz: 46f124acbba56489d2b83ea411c46250c310a526ef1f8b5e73e916eed31f517a47e3640213b738541a95772056693bd419b413c8e28fb2663e7c45ed1393d749
+  metadata.gz: 1a179a210092c0c7692c0ea843780cc6809e5dd8eaa43eba5a2663ea473562fee4d2a45cddc981bcd3a7145878e3b61e9b9ef66443365c207981f5a27834ab29
+  data.tar.gz: f3ee33264346715bedc618730cecd2b0bf5489d9a18907b96defb36de6ab4dc9271fa5864b01f709d2ed8f77cc4babda4aaa435f6765b494576e7b198a6bd4b0

data/.travis.yml

@@ -6,12 +6,11 @@ cache:
 rvm:
   - 2.5
   - 2.6
-  - ruby-head
 
 before_install:
   - "echo 'gem: --no-document' > ~/.gemrc"
   - gem update --system
-  - gem install bundler -v "~>2.0"
+  - gem install bundler --force
 
 script:
   - bundle exec rspec
@@ -23,4 +22,4 @@ addons:
   code_climate:
     repo_token: dc180b31d340bd88cedd0ec3ea8ba8ec5093f2bafe77a7bf5bbdcb1c5ff9dc7f
 after_success:
-  - bundle exec codeclimate-test-reporter
+  - bundle exec codeclimate-test-reporter

data/lib/finapps/rest/plaid/plaid_consumer_institutions.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'erb'
+
 module FinApps
   module REST
     class PlaidConsumerInstitutions < PlaidResources # :nodoc:
@@ -11,7 +13,8 @@ module FinApps
         results, error_messages = super(nil, "p/institution/consumer/#{id}")
 
         if error_messages.empty? && options[:show_accounts]
-          account_results, error_messages = super(nil, "p/institution/consumer/#{id}/account")
+          account_results, error_messages =
+            super(nil, "p/institution/consumer/#{id}/account")
           results[:accounts] = account_results if error_messages.empty?
         end
 
@@ -21,6 +24,12 @@ module FinApps
       def list
         super 'p/institution/consumer'
       end
+
+      def destroy(id)
+        not_blank(id, :consumer_institution_id)
+
+        super id, "p/institution/consumer/#{id}"
+      end
     end
   end
 end

data/lib/finapps/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinApps
-  VERSION = '5.0.16'
+  VERSION = '5.0.17'
 end

data/spec/rest/plaid/plaid_consumer_institutions_spec.rb

@@ -9,8 +9,10 @@ RSpec.describe FinApps::REST::PlaidConsumerInstitutions do
   # noinspection RubyBlockToMethodReference
   let(:api_client) { client }
 
-  RSpec.shared_examples 'a request that returns institution data' do |_parameter|
-    it('returns institution data') { expect(subject[RESULTS]).to have_key(:plaid_institution_id) }
+  RSpec.shared_examples 'a request that returns institution data' do
+    it('returns institution data') do
+      expect(subject[RESULTS]).to have_key(:plaid_institution_id)
+    end
   end
 
   describe '#create' do
@@ -45,15 +47,34 @@ RSpec.describe FinApps::REST::PlaidConsumerInstitutions do
       it_behaves_like 'an API request'
       it_behaves_like 'a successful request'
       it_behaves_like 'a request that returns institution data'
-      it('returns institution account data') { expect(subject[RESULTS]).to have_key(:accounts) }
+      it('returns institution account data') do
+        expect(subject[RESULTS]).to have_key(:accounts)
+      end
     end
   end
 
   describe '#list' do
-    subject(:list) { FinApps::REST::PlaidConsumerInstitutions.new(api_client).list }
+    subject(:list) do
+      FinApps::REST::PlaidConsumerInstitutions.new(api_client).list
+    end
 
     it_behaves_like 'an API request'
     it_behaves_like 'a successful request'
-    it('returns an Array of institution data') { expect(list[RESULTS].first).to have_key(:plaid_institution_id) }
+    it('returns an Array of institution data') do
+      expect(list[RESULTS].first).to have_key(:plaid_institution_id)
+    end
+  end
+
+  describe '#destroy' do
+    subject(:destroy) do
+      FinApps::REST::PlaidConsumerInstitutions.new(api_client)
+                                              .destroy(:consumer_institution_id)
+    end
+
+    it_behaves_like 'an API request'
+    it_behaves_like 'a successful request'
+    it('returns no results') do
+      expect(destroy[RESULTS]).to be_nil
+    end
   end
 end

data/spec/support/fake_api.rb

@@ -48,6 +48,9 @@ class FakeApi < Sinatra::Base
       json_response 200, 'plaid/institution/consumer/add.json'
     end
   end
+  delete("/#{version}/p/institution/consumer/:consumer_institution_id") do
+    status 204
+  end
 
   # plaid_accounts
   get("/#{version}/p/account") do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 5.0.16
+  version: 5.0.17
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-04 00:00:00.000000000 Z
+date: 2019-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: finapps_core
@@ -440,44 +440,44 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: FinApps REST API ruby client.
 test_files:
-- spec/rest/portfolios_alerts_spec.rb
-- spec/rest/alert_definitions_spec.rb
 - spec/rest/portfolios_consumers_spec.rb
-- spec/rest/plaid/plaid_accounts_spec.rb
-- spec/rest/plaid/plaid_institution_logos_spec.rb
-- spec/rest/plaid/plaid_webhooks_spec.rb
-- spec/rest/plaid/plaid_account_permissions_spec.rb
-- spec/rest/plaid/plaid_consumer_institutions_spec.rb
-- spec/rest/order_assignments_spec.rb
-- spec/rest/tenant_settings_spec.rb
-- spec/rest/tenant_app_settings_spec.rb
-- spec/rest/client_spec.rb
-- spec/rest/portfolio_reports_spec.rb
+- spec/rest/consumers_portfolios_spec.rb
+- spec/rest/operators_password_resets_spec.rb
+- spec/rest/portfolios_available_consumers_spec.rb
+- spec/rest/products_spec.rb
+- spec/rest/statements_spec.rb
+- spec/rest/alert_definitions_spec.rb
 - spec/rest/version_spec.rb
-- spec/rest/password_resets_spec.rb
+- spec/rest/consumers_spec.rb
+- spec/rest/orders_spec.rb
+- spec/rest/order_tokens_spec.rb
+- spec/rest/tenant_app_settings_spec.rb
 - spec/rest/operators_spec.rb
-- spec/rest/order_statuses_spec.rb
+- spec/rest/client_spec.rb
+- spec/rest/tenant_settings_spec.rb
+- spec/rest/api_request.rb
 - spec/rest/alert_occurrences_spec.rb
+- spec/rest/password_resets_spec.rb
 - spec/rest/order_reports_spec.rb
-- spec/rest/portfolios_available_consumers_spec.rb
-- spec/rest/consumers_spec.rb
-- spec/rest/sessions_spec.rb
-- spec/rest/orders_spec.rb
-- spec/rest/operators_password_resets_spec.rb
 - spec/rest/portfolios_spec.rb
+- spec/rest/order_statuses_spec.rb
+- spec/rest/plaid/plaid_accounts_spec.rb
+- spec/rest/plaid/plaid_account_permissions_spec.rb
+- spec/rest/plaid/plaid_webhooks_spec.rb
+- spec/rest/plaid/plaid_institution_logos_spec.rb
+- spec/rest/plaid/plaid_consumer_institutions_spec.rb
 - spec/rest/order_refreshes_spec.rb
 - spec/rest/order_notifications_spec.rb
-- spec/rest/statements_spec.rb
-- spec/rest/api_request.rb
-- spec/rest/order_tokens_spec.rb
-- spec/rest/consumers_portfolios_spec.rb
-- spec/rest/products_spec.rb
-- spec/utils/query_builder_spec.rb
+- spec/rest/portfolios_alerts_spec.rb
+- spec/rest/order_assignments_spec.rb
+- spec/rest/sessions_spec.rb
+- spec/rest/portfolio_reports_spec.rb
 - spec/support/fake_api.rb
-- spec/spec_helper.rb
+- spec/utils/query_builder_spec.rb
 - spec/spec_helpers/client.rb
+- spec/spec_helper.rb