finapps 5.0.15 → 5.0.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f34e507fa4a0cf5496d1993d7b064512f1a2237d8bcf79a6c566d15391575881
-  data.tar.gz: 3a021151ddf042be1deb2e372df83cc296e1aa88f8d283a9c0bd68b76d44b815
+  metadata.gz: 5e152bd168f623e4d40787548c86e7c80c056826311cb15c642e1da4930a6312
+  data.tar.gz: 650f2da982b5cddaaa0acebbe83c74cfc9b669a020606f7e542dd6c45760209b
 SHA512:
-  metadata.gz: 0ac04e060de22bb5daed4c8002a23ae7a7e992886b519b553ab7f220c26c2d3066b6cff8d7a7d0fbe52b3f9f76c35ddb1bc73438feaab84fc280d28f1a4c7c7e
-  data.tar.gz: 22198e41021ba24d43ee6a7feacdf3e1298b2747181f5d310a77f91657d23537937b3af22966b84a6cbb481d7d4706ce181f71e576b0208fcf99cfb8e6c085f2
+  metadata.gz: 6f37c24832dec19af8e3760affb07e6d05a4bbde1916f56025047dbc35fe08d1cbda1032bacb35a2acc1c2622b5b806785a9c8890460a986c281ebaa6dd18703
+  data.tar.gz: 46f124acbba56489d2b83ea411c46250c310a526ef1f8b5e73e916eed31f517a47e3640213b738541a95772056693bd419b413c8e28fb2663e7c45ed1393d749

data/finapps.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.test_files = Dir['spec/**/*.rb']
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency     'finapps_core',               '~> 5.0',   '>= 5.0.5'
+  spec.add_runtime_dependency     'finapps_core',               '~> 5.0',   '>= 5.0.6'
 
   spec.add_development_dependency 'bundler',                    '~> 2.0',   '>= 2.0.2'
   spec.add_development_dependency 'codeclimate-test-reporter',  '~> 1.0',   '>= 1.0.9'

data/lib/finapps/rest/orders.rb

@@ -33,11 +33,13 @@ module FinApps
         super build_query_path(end_point, params)
       end
 
-      def update(id)
+      def update(id, params = nil)
+        return super params if params # create&submit
+
         not_blank(id, :id)
         path = "#{end_point}/#{ERB::Util.url_encode(id)}"
 
-        super nil, path
+        super nil, path # submit
       end
 
       def destroy(id)
@@ -47,6 +49,10 @@ module FinApps
         send_request path, :put
       end
 
+      def create_and_submit(params)
+        update(nil, params)
+      end
+
       private
 
       def build_filter(params)

data/lib/finapps/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinApps
-  VERSION = '5.0.15'
+  VERSION = '5.0.16'
 end

data/spec/rest/orders_spec.rb

@@ -150,33 +150,75 @@ RSpec.describe FinApps::REST::Orders do
   describe '#update' do
     subject(:orders) { FinApps::REST::Orders.new(client) }
 
-    context 'when missing id' do
-      let(:update) { subject.update(nil) }
-      it('returns missing argument error') do
-        expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
+    context 'with nil params' do
+      context 'when missing id' do
+        let(:update) { subject.update(nil) }
+        it('returns missing argument error') do
+          expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
+        end
       end
-    end
 
-    context 'when valid id is provided' do
-      let(:update) { subject.update('valid_id') } # how to stub params
-      let(:results) { update[RESULTS] }
-      let(:error_messages) { update[ERROR_MESSAGES] }
+      context 'when valid id is provided' do
+        let(:update) { subject.update('valid_id') } # how to stub params
+        let(:results) { update[RESULTS] }
+        let(:error_messages) { update[ERROR_MESSAGES] }
 
-      it { expect { update }.not_to raise_error }
-      it('results is nil') { expect(results).to be_nil }
-      it('error_messages array is empty') { expect(error_messages).to eq([]) }
+        it { expect { update }.not_to raise_error }
+        it('results is nil') { expect(results).to be_nil }
+        it('error_messages array is empty') { expect(error_messages).to eq([]) }
+      end
+
+      context 'when invalid id is provided' do
+        let(:update) { subject.update('invalid_id') }
+        let(:results) { update[RESULTS] }
+        let(:error_messages) { update[ERROR_MESSAGES] }
+
+        it { expect { update }.not_to raise_error }
+        it('results is nil') { expect(results).to be_nil }
+        it('error messages array is populated') do
+          expect(error_messages.first.downcase).to eq('resource not found')
+        end
+      end
     end
 
-    context 'when invalid id is provided' do
-      let(:update) { subject.update('invalid_id') }
-      let(:results) { update[RESULTS] }
-      let(:error_messages) { update[ERROR_MESSAGES] }
+    context 'with params' do
+      context 'when missing id' do
+        let(:update) { subject.update(nil, params: 'valid') }
+        it('does not raise error') do
+          expect { update }.not_to raise_error
+        end
+      end
 
-      it { expect { update }.not_to raise_error }
-      it('results is nil') { expect(results).to be_nil }
-      it('error messages array is populated') do
-        expect(error_messages.first.downcase).to eq('resource not found')
+      context 'when valid params are provided' do
+        let(:update) { subject.update(nil, params: 'valid') }
+        let(:results) { update[RESULTS] }
+        let(:error_messages) { update[ERROR_MESSAGES] }
+
+        it { expect { update }.not_to raise_error }
+        it('results is nil') { expect(results).to be_nil }
+        it('error_messages array is empty') { expect(error_messages).to eq([]) }
       end
+
+      context 'when invalid params are provided' do
+        let(:update) { subject.update(nil, params: 'invalid') }
+        let(:results) { update[RESULTS] }
+        let(:error_messages) { update[ERROR_MESSAGES] }
+
+        it { expect { update }.not_to raise_error }
+        it('results is nil') { expect(results).to be_nil }
+        it('error messages array is populated') do
+          expect(error_messages.first.downcase).to eq('invalid request body')
+        end
+      end
+    end
+  end
+
+  describe '#create_and_submit' do
+    subject(:orders) { FinApps::REST::Orders.new(client) }
+    let(:params) { { params: 'valid' } }
+    it('calls #update') do
+      expect(subject).to receive(:update).with(nil, params)
+      subject.create_and_submit(params)
     end
   end
 

data/spec/support/fake_api.rb

@@ -148,6 +148,15 @@ class FakeApi < Sinatra::Base
     json_response 404, 'resource_not_found.json'
   end
   put("/#{version}/orders/valid_id") { status 204 }
+  put("/#{version}/orders") do
+    request.body.rewind
+    request_payload = JSON.parse request.body.read
+    if request_payload['params'] == 'invalid'
+      json_response 400, 'invalid_request_body.json'
+    else
+      status 204
+    end
+  end
   post("/#{version}/orders") do
     request.body.rewind
     request_payload = JSON.parse request.body.read

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 5.0.15
+  version: 5.0.16
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-27 00:00:00.000000000 Z
+date: 2019-10-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: finapps_core
@@ -19,7 +19,7 @@ dependencies:
         version: '5.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.0.5
+        version: 5.0.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: '5.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.0.5
+        version: 5.0.6
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement